Commit 4e4e8902e5bec12befd191b6ce412d60ced819f4 | zig | Meg's Mirrors

author	Jacob Young <jacobly@ziglang.org> 2026-09-19 08:20:15-04:00
committer	Jacob Young <jacobly@ziglang.org> 2026-09-26 19:08:50-04:00
log	4e4e8902e5bec12befd191b6ce412d60ced819f4
tree	e1f880c526db3cd0c954bb84578e2f44a2eeacec
parent	e4c1598ac8dd984a480fad41e61cc60c41448cac

Build: fix UAF of step names

4 files changed, 4 insertions(+), 4 deletions(-)

lib
- std
  - Build
    Step.zig
    Step
    CheckFile.zig
    Run.zig
test
- tests.zig

lib/std/Build/Step.zig+1-1

...	...	@@ -95,7 +95,7 @@ pub fn init(options: StepOptions) Step {
95	95
96	96	return .{
97	97	.tag = options.tag,
98		.name = arena.dupe(u8, options.name) catch @panic("OOM"),
	98	.name = options.owner.graph.dupeString(options.name),
99	99	.owner = options.owner,
100	100	.dependencies = .empty,
101	101	.max_rss = options.max_rss,

lib/std/Build/Step/CheckFile.zig+1-1

...	...	@@ -41,5 +41,5 @@ pub fn create(owner: std.Build, file: std.Build.LazyPath, options: Options) Ch
41	41	}
42	42
43	43	pub fn setName(check_file: *CheckFile, name: []const u8) void {
44		check_file.step.name = name;
	44	check_file.step.name = check_file.step.owner.graph.dupeString(name);
45	45	}

lib/std/Build/Step/Run.zig+1-1

...	...	@@ -241,7 +241,7 @@ pub fn create(owner: std.Build, name: []const u8) Run {
241	241	}
242	242
243	243	pub fn setName(run: *Run, name: []const u8) void {
244		run.step.name = name;
	244	run.step.name = run.step.owner.graph.dupeString(name);
245	245	run.rename_step_with_output_arg = false;
246	246	}
247	247

test/tests.zig+1-1

...	...	@@ -2502,7 +2502,7 @@ pub fn addStandaloneTests(
2502	2502	.simple_skip_release_small = mem.findScalar(OptimizeMode, optimize_modes, .small) == null,
2503	2503	});
2504	2504	const test_cases_dep_step = test_cases_dep.builder.default_step;
2505		test_cases_dep_step.name = b.graph.dupeString(test_cases_dep_name);
	2505	test_cases_dep_step.name = test_cases_dep_name;
2506	2506	step.dependOn(test_cases_dep.builder.default_step);
2507	2507	return step;
2508	2508	}