Commit 4e53249d769346683d45d4a4cb4a437388f9e186 | zig

author	Andrew Kelley <andrew@ziglang.org> 2022-07-26 20:09:48-07:00
committer	Andrew Kelley <andrew@ziglang.org> 2022-07-26 20:09:48-07:00
log	4e53249d769346683d45d4a4cb4a437388f9e186
tree	d3b2fa77951f91e3936cbfd473d0638da2df5f59
parent	ea3db3274d890b7d00c907c037ffe203f41adbd3

test-cases harness: improve stage2 compatibility

 * proper skip_stage1 mechanism that doesn't get side-stepped with
   manually added test cases.
 * avoid runtime-known function pointers.
 * check for type equality more simply without checking the type name.

1 files changed, 17 insertions(+), 30 deletions(-)

src
- test.zig

src/test.zig+17-30

 @@ -20,7 +20,7 @@ const enable_wasmtime: bool = build_options.enable_wasmtime;
 const enable_darling: bool = build_options.enable_darling;
 const enable_rosetta: bool = build_options.enable_rosetta;
 const glibc_runtimes_dir: ?[]const u8 = build_options.glibc_runtimes_dir;
-const skip_stage1 = build_options.skip_stage1;
+const skip_stage1 = builtin.zig_backend != .stage1 or build_options.skip_stage1;
 const hr = "=" ** 80;
 @@ -233,11 +233,11 @@ const TestManifest = struct {
     fn ConfigValueIterator(comptime T: type) type {
         return struct {
             inner: std.mem.SplitIterator(u8),
-            parse_fn: ParseFn(T),
             fn next(self: *@This()) !?T {
                 const next_raw = self.inner.next() orelse return null;
-                return try self.parse_fn(next_raw);
+                const parseFn = getDefaultParser(T);
+                return try parseFn(next_raw);
             }
         };
     }
 @@ -313,27 +313,17 @@ const TestManifest = struct {
         return manifest;
     }
-    fn getConfigForKeyCustomParser(
+    fn getConfigForKey(
         self: TestManifest,
         key: []const u8,
         comptime T: type,
-        parse_fn: ParseFn(T),
     ) ConfigValueIterator(T) {
         const bytes = self.config_map.get(key) orelse TestManifestConfigDefaults.get(self.@"type", key);
         return ConfigValueIterator(T){
             .inner = std.mem.split(u8, bytes, ","),
-            .parse_fn = parse_fn,
         };
     }
-    fn getConfigForKey(
-        self: TestManifest,
-        key: []const u8,
-        comptime T: type,
-    ) ConfigValueIterator(T) {
-        return self.getConfigForKeyCustomParser(key, T, getDefaultParser(T));
-    }
     fn getConfigForKeyAlloc(
         self: TestManifest,
         allocator: Allocator,
 @@ -377,6 +367,15 @@ const TestManifest = struct {
     }
     fn getDefaultParser(comptime T: type) ParseFn(T) {
+        if (T == CrossTarget) return struct {
+            fn parse(str: []const u8) anyerror!T {
+                var opts = CrossTarget.ParseOptions{
+                    .arch_os_abi = str,
+                };
+                return try CrossTarget.parse(opts);
+            }
+        }.parse;
         switch (@typeInfo(T)) {
             .Int => return struct {
                 fn parse(str: []const u8) anyerror!T {
 @@ -397,14 +396,7 @@ const TestManifest = struct {
                     };
                 }
             }.parse,
-            .Struct => if (comptime std.mem.eql(u8, @typeName(T), "CrossTarget")) return struct {
+            .Struct => @compileError("no default parser for " ++ @typeName(T)),
-                fn parse(str: []const u8) anyerror!T {
-                    var opts = CrossTarget.ParseOptions{
-                        .arch_os_abi = str,
-                    };
-                    return try CrossTarget.parse(opts);
-                }
-            }.parse else @compileError("no default parser for " ++ @typeName(T)),
             else => @compileError("no default parser for " ++ @typeName(T)),
         }
     }
 @@ -884,8 +876,6 @@ pub const TestContext = struct {
         src: [:0]const u8,
         expected_errors: []const []const u8,
     ) void {
-        if (skip_stage1) return;
         const case = ctx.addObj(name, .{});
         case.backend = .stage1;
         case.addError(src, expected_errors);
 @@ -897,8 +887,6 @@ pub const TestContext = struct {
         src: [:0]const u8,
         expected_errors: []const []const u8,
     ) void {
-        if (skip_stage1) return;
         const case = ctx.addTest(name, .{});
         case.backend = .stage1;
         case.addError(src, expected_errors);
 @@ -910,8 +898,6 @@ pub const TestContext = struct {
         src: [:0]const u8,
         expected_errors: []const []const u8,
     ) void {
-        if (skip_stage1) return;
         const case = ctx.addExe(name, .{});
         case.backend = .stage1;
         case.addError(src, expected_errors);
 @@ -1143,8 +1129,6 @@ pub const TestContext = struct {
                     // Cross-product to get all possible test combinations
                     for (backends) |backend| {
-                        if (backend == .stage1 and skip_stage1) continue;
                         for (targets) |target| {
                             const name = try std.fmt.allocPrint(ctx.arena, "{s} ({s}, {s})", .{
                                 name_prefix,
 @@ -1276,6 +1260,9 @@ pub const TestContext = struct {
                 if (!build_options.have_llvm and case.backend == .llvm)
                     continue;
+                if (skip_stage1 and case.backend == .stage1)
+                    continue;
                 if (build_options.test_filter) |test_filter| {
                     if (std.mem.indexOf(u8, case.name, test_filter) == null) continue;
                 }