authorgravatar for amlandeep1912@gmail.comKoko Bhadra <amlandeep1912@gmail.com> 2026-03-03 10:15:26-05:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2026-03-05 20:22:19+01:00
log4fa465fc8f3b6140e635186b4f0e5acae924adcc
treef9ccc7a2e677653476ab704abeb4408f40e9e7fb
parent15f0af09d0ba8e8a6a7b44702913ca309afe2296

compiler_rt: optimize udivmod large-divisor case with trial quotient

Replace the O(n) shift-subtract loop with a constant-time trial quotient approach (Knuth Algorithm D, TAOCP Vol 2 Section 4.3.1). The old code iterates clz(b_hi)-clz(a_hi)+1 times (up to 64 iterations of 128-bit arithmetic). The new code uses a single divwide call to get a trial quotient, then verifies with two native-width widening multiplies. Benchmark (Apple M1, ReleaseFast): - Large divisor, large shift: 87ns -> 7.5ns (11.5x faster) - Small divisor / uniform: unchanged

1 files changed, 77 insertions(+), 18 deletions(-)

lib/compiler_rt/udivmod.zig+77-18
......@@ -182,7 +182,7 @@ fn divwide(comptime T: type, _u1: T, _u0: T, v: T, r: *T) T {
182182pub fn udivmod(comptime T: type, a_: T, b_: T, maybe_rem: ?*T) T {
183183 @setRuntimeSafety(compiler_rt.test_safety);
184184 const HalfT = HalveInt(T, false).HalfT;
185 const SignedT = std.meta.Int(.signed, @bitSizeOf(T));
185 const half_bits = @bitSizeOf(HalfT);
186186
187187 if (b_ > a_) {
188188 if (maybe_rem) |rem| {
......@@ -214,26 +214,85 @@ pub fn udivmod(comptime T: type, a_: T, b_: T, maybe_rem: ?*T) T {
214214 return @bitCast(q);
215215 }
216216
217 // 0 <= shift <= 63
218 const shift: Log2Int(T) = @clz(b[hi]) - @clz(a[hi]);
219 var af: T = @bitCast(a);
220 var bf = @as(T, @bitCast(b)) << shift;
221 q = @bitCast(@as(T, 0));
217 // Large-divisor case: b[hi] != 0, so the quotient fits in one HalfT word.
218 //
219 // Trial quotient via divwide (Knuth Vol 2, Section 4.3.1):
220 // Normalize the divisor so its high half has the MSB set, then use divwide
221 // on the top bits to get a trial quotient that is at most 1 too large.
222 // This replaces the O(shift) bit-by-bit loop with O(1) operations.
223 const s: Log2Int(HalfT) = @intCast(@clz(b[hi]));
224
225 if (s == 0) {
226 // b[hi] already has its MSB set, so b >= 2^(T_bits - 1). Since a >= b
227 // (we passed the b_ > a_ check), a >= 2^(T_bits - 1) too, meaning
228 // a[hi] also has its MSB set. Therefore a / b < 2, and the quotient
229 // is exactly 1.
230 q = @bitCast(@as(T, 0));
231 q[lo] = 1;
232 if (maybe_rem) |rem| {
233 rem.* = a_ - b_;
234 }
235 return @bitCast(q);
236 }
222237
223 for (0..shift + 1) |_| {
224 q[lo] <<= 1;
225 // Branchless version of:
226 // if (af >= bf) {
227 // af -= bf;
228 // q[lo] |= 1;
229 // }
230 const s = @as(SignedT, @bitCast(bf -% af -% 1)) >> (@bitSizeOf(T) - 1);
231 q[lo] |= @intCast(s & 1);
232 af -= bf & @as(T, @bitCast(s));
233 bf >>= 1;
238 // Normalize b: shift left by s so bn_hi has its MSB set.
239 const sr: Log2Int(HalfT) = @intCast(half_bits - @as(
240 std.math.IntFittingRange(0, half_bits),
241 @intCast(s),
242 ));
243 const bn_hi: HalfT = (b[hi] << s) | (b[lo] >> sr);
244
245 // Trial numerator: the top (half_bits + s) bits of (a << s), as [a2:a1].
246 // a2 < bn_hi is guaranteed since a2 < 2^s and bn_hi >= 2^(half_bits - 1).
247 const a2: HalfT = a[hi] >> sr;
248 const a1: HalfT = (a[hi] << s) | (a[lo] >> sr);
249
250 // Trial quotient via divwide: q_hat = floor([a2:a1] / bn_hi).
251 // By Knuth's theorem (normalized divisor), q <= q_hat <= q + 1.
252 var r_tmp: HalfT = undefined;
253 var q_hat: HalfT = divwide(HalfT, a2, a1, bn_hi, &r_tmp);
254
255 // Verify: q_hat * b must not exceed a.
256 // Compute the product using HalfT * HalfT -> T widening multiplications,
257 // which are native single-instruction ops when HalfT fits in a register
258 // (e.g. u64 * u64 -> u128 via mulq on x86_64, mul on aarch64).
259 // product = q_hat * [b[hi]:b[lo]] = [p_top : p_mid : p_lo] (3 half-words)
260 const prod_lo: T = @as(T, q_hat) * @as(T, b[lo]);
261 const prod_hi: T = @as(T, q_hat) * @as(T, b[hi]);
262
263 const prod_lo_parts: [2]HalfT = @bitCast(prod_lo);
264 const prod_hi_parts: [2]HalfT = @bitCast(prod_hi);
265
266 const mid_add = @addWithOverflow(prod_hi_parts[lo], prod_lo_parts[hi]);
267 var p_mid: HalfT = mid_add[0];
268 const p_top: HalfT = prod_hi_parts[hi] +% @as(HalfT, mid_add[1]);
269 var p_lo: HalfT = prod_lo_parts[lo];
270
271 // If product > a, decrement q_hat (at most once, guaranteed by Knuth).
272 if (p_top > 0 or p_mid > a[hi] or (p_mid == a[hi] and p_lo > a[lo])) {
273 q_hat -= 1;
274 // Subtract b from the product for correct remainder computation.
275 // After correction, (q_hat * b) fits in T bits, so borrows into
276 // p_top cancel it to zero -- we only need [p_mid:p_lo].
277 const sub_lo = @subWithOverflow(p_lo, b[lo]);
278 p_lo = sub_lo[0];
279 const sub_mid = @subWithOverflow(p_mid, b[hi]);
280 const sub_mid2 = @subWithOverflow(sub_mid[0], @as(HalfT, sub_lo[1]));
281 p_mid = sub_mid2[0];
234282 }
283
284 q = @bitCast(@as(T, 0));
285 q[lo] = q_hat;
286
235287 if (maybe_rem) |rem| {
236 rem.* = @bitCast(af);
288 // remainder = a - q_hat * b = [a[hi]:a[lo]] - [p_mid:p_lo]
289 // This subtraction is non-negative since q_hat <= true quotient.
290 const rem_lo = @subWithOverflow(a[lo], p_lo);
291 r[lo] = rem_lo[0];
292 const rem_hi = @subWithOverflow(a[hi], p_mid);
293 const rem_hi2 = @subWithOverflow(rem_hi[0], @as(HalfT, rem_lo[1]));
294 r[hi] = rem_hi2[0];
295 rem.* = @bitCast(r);
237296 }
238297 return @bitCast(q);
239298}