Commit 519a47af31b0eaf41fc3649474e16f460b454795 | zig

author	Andrew Kelley <andrew@ziglang.org> 2026-06-24 17:27:59-07:00
committer	Andrew Kelley <andrew@ziglang.org> 2026-06-29 23:50:20-07:00
log	519a47af31b0eaf41fc3649474e16f460b454795
tree	cfceb0dc19fd1a20c47c762ec5da8c52eea8abf8
parent	09f61b13b359eec02d12567b3bd2c967c5448e81

Maker: fix memory leak of deps hash tables

This is still basically a leak since it uses global arena but it can be
adjusted later to use an arena local to the while loop iteration as part
of a larger global audit.

1 files changed, 2 insertions(+), 4 deletions(-)

lib
- compiler
  - Maker.zig

lib/compiler/Maker.zig+2-4

 @@ -716,14 +716,12 @@ pub fn main(init: process.Init.Minimal) !void {
             .name = "@build",
             .root_path = try root_build_src_path.toString(arena),
         };
-        defer build_mod.deps.deinit(gpa);
         const deps_mod = try arena.create(CliModule);
         deps_mod.* = .{
             .name = "@dependencies",
             .root_path = undefined,
         };
-        defer deps_mod.deps.deinit(gpa);
         // This loop is re-evaluated when the build script exits with an indication that it
         // could not continue due to missing lazy dependencies.
 @@ -876,7 +874,7 @@ pub fn main(init: process.Init.Minimal) !void {
                         // Add a CliModule for each package's build.zig.
                         const hashes = job_queue.table.keys();
                         const fetches = job_queue.table.values();
-                        try deps_mod.deps.ensureUnusedCapacity(gpa, @intCast(hashes.len));
+                        try deps_mod.deps.ensureUnusedCapacity(arena, @intCast(hashes.len));
                         for (hashes, fetches) |*hash, f| {
                             if (f == &fetch) {
                                 // The first one is a dummy package for the current project.
 @@ -902,7 +900,7 @@ pub fn main(init: process.Init.Minimal) !void {
                             if (!f.have_manifest) continue;
                             const man = &f.manifest;
                             const dep_names = man.dependencies.keys();
-                            try mod.deps.ensureUnusedCapacity(gpa, @intCast(dep_names.len));
+                            try mod.deps.ensureUnusedCapacity(arena, @intCast(dep_names.len));
                             for (dep_names, man.dependencies.values()) |name, dep| {
                                 const dep_digest = Package.Fetch.depDigest(
                                     f.package_root,