authorgravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2023-05-13 02:24:41-04:00
committergravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2023-05-15 03:07:51-04:00
log57c38f6433c8024d1946bcf1b5b7d0892fc751a7
treef5e338f3f13c91420b112c9ff39f8128335c2806
parent2cbd442a9df16ab2d13d03041631f516269c9f64

x86_64: implement global payload pointers

3 files changed, 35 insertions(+), 8 deletions(-)

src/arch/x86_64/CodeGen.zig+5-2
......@@ -3467,14 +3467,17 @@ fn airOptionalPayloadPtrSet(self: *Self, inst: Air.Inst.Index) !void {
34673467 try self.copyToRegisterWithInstTracking(inst, dst_ty, src_mcv);
34683468 }
34693469
3470 const dst_mcv = if (src_mcv.isRegister() and self.reuseOperand(inst, ty_op.operand, 0, src_mcv))
3470 const dst_mcv: MCValue = if (src_mcv.isRegister() and
3471 self.reuseOperand(inst, ty_op.operand, 0, src_mcv))
34713472 src_mcv
3473 else if (self.liveness.isUnused(inst))
3474 .{ .register = try self.copyToTmpRegister(dst_ty, src_mcv) }
34723475 else
34733476 try self.copyToRegisterWithInstTracking(inst, dst_ty, src_mcv);
34743477
34753478 const pl_ty = dst_ty.childType();
34763479 const pl_abi_size = @intCast(i32, pl_ty.abiSize(self.target.*));
3477 try self.genSetMem(.{ .reg = dst_mcv.register }, pl_abi_size, Type.bool, .{ .immediate = 1 });
3480 try self.genSetMem(.{ .reg = dst_mcv.getReg().? }, pl_abi_size, Type.bool, .{ .immediate = 1 });
34783481 break :result if (self.liveness.isUnused(inst)) .unreach else dst_mcv;
34793482 };
34803483 return self.finishAir(inst, result, .{ ty_op.operand, .none, .none });
src/codegen.zig+30-4
......@@ -380,7 +380,7 @@ pub fn generateSymbol(
380380
381381 return Result.ok;
382382 },
383 .field_ptr, .elem_ptr => return lowerParentPtr(
383 .field_ptr, .elem_ptr, .opt_payload_ptr => return lowerParentPtr(
384384 bin_file,
385385 src_loc,
386386 typed_value,
......@@ -812,7 +812,6 @@ fn lowerParentPtr(
812812 reloc_info: RelocInfo,
813813) CodeGenError!Result {
814814 const target = bin_file.options.target;
815
816815 switch (parent_ptr.tag()) {
817816 .field_ptr => {
818817 const field_ptr = parent_ptr.castTag(.field_ptr).?.data;
......@@ -858,6 +857,31 @@ fn lowerParentPtr(
858857 reloc_info.offset(@intCast(u32, elem_ptr.index * elem_ptr.elem_ty.abiSize(target))),
859858 );
860859 },
860 .opt_payload_ptr => {
861 const opt_payload_ptr = parent_ptr.castTag(.opt_payload_ptr).?.data;
862 return lowerParentPtr(
863 bin_file,
864 src_loc,
865 typed_value,
866 opt_payload_ptr.container_ptr,
867 code,
868 debug_output,
869 reloc_info,
870 );
871 },
872 .eu_payload_ptr => {
873 const eu_payload_ptr = parent_ptr.castTag(.eu_payload_ptr).?.data;
874 const pl_ty = eu_payload_ptr.container_ty.errorUnionPayload();
875 return lowerParentPtr(
876 bin_file,
877 src_loc,
878 typed_value,
879 eu_payload_ptr.container_ptr,
880 code,
881 debug_output,
882 reloc_info.offset(@intCast(u32, errUnionPayloadOffset(pl_ty, target))),
883 );
884 },
861885 .variable, .decl_ref, .decl_ref_mut => |tag| return lowerDeclRef(
862886 bin_file,
863887 src_loc,
......@@ -1262,9 +1286,10 @@ pub fn genTypedValue(
12621286}
12631287
12641288pub fn errUnionPayloadOffset(payload_ty: Type, target: std.Target) u64 {
1289 if (!payload_ty.hasRuntimeBitsIgnoreComptime()) return 0;
12651290 const payload_align = payload_ty.abiAlignment(target);
12661291 const error_align = Type.anyerror.abiAlignment(target);
1267 if (payload_align >= error_align) {
1292 if (payload_align >= error_align or !payload_ty.hasRuntimeBitsIgnoreComptime()) {
12681293 return 0;
12691294 } else {
12701295 return mem.alignForwardGeneric(u64, Type.anyerror.abiSize(target), payload_align);
......@@ -1272,9 +1297,10 @@ pub fn errUnionPayloadOffset(payload_ty: Type, target: std.Target) u64 {
12721297}
12731298
12741299pub fn errUnionErrorOffset(payload_ty: Type, target: std.Target) u64 {
1300 if (!payload_ty.hasRuntimeBitsIgnoreComptime()) return 0;
12751301 const payload_align = payload_ty.abiAlignment(target);
12761302 const error_align = Type.anyerror.abiAlignment(target);
1277 if (payload_align >= error_align) {
1303 if (payload_align >= error_align and payload_ty.hasRuntimeBitsIgnoreComptime()) {
12781304 return mem.alignForwardGeneric(u64, payload_ty.abiSize(target), error_align);
12791305 } else {
12801306 return 0;
test/behavior/optional.zig-2
......@@ -74,7 +74,6 @@ test "optional with void type" {
7474test "address of unwrap optional" {
7575 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
7676 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
77 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
7877 if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
7978 if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;
8079
......@@ -365,7 +364,6 @@ test "optional pointer to zero bit optional payload" {
365364}
366365
367366test "optional pointer to zero bit error union payload" {
368 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
369367 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
370368 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
371369 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO