| author |  Krzysztof Wolicki <der.teufel.mail@gmail.com> 2024-01-26 14:22:15+01:00 |
| committer |  GitHub <noreply@github.com> 2024-01-26 15:22:15+02:00 |
| log | 61ba225709b88579984a1a679021d121d1aada64 |
| tree | 55734f93d5e8009c5beecec938ef0fe634ddd533 |
| parent | bea958df4d0c5fc38633f09b6490c16e24a03155 |
| signature |  Signed by PGP key B5690EEEBB952194 |
Sema: tuples have no names to be used for reporting errors in finishStructInit
2 files changed, 29 insertions(+), 6 deletions(-)
src- test
- cases
- compile_errors
src/Sema.zig+15-6
| ... | ... | @@ -19963,13 +19963,22 @@ fn finishStructInit( |
| 19963 | 19963 | |
| 19964 | 19964 | const field_init = struct_type.fieldInit(ip, i); |
| 19965 | 19965 | if (field_init == .none) { |
| 19966 | const field_name = struct_type.field_names.get(ip)[i]; | |
| 19967 | const template = "missing struct field: {}"; | |
| 19968 | const args = .{field_name.fmt(ip)}; | |
| 19969 | if (root_msg) |msg| { | |
| 19970 | try sema.errNote(block, init_src, msg, template, args); | |
| 19966 | if (!struct_type.isTuple(ip)) { | |
| 19967 | const field_name = struct_type.field_names.get(ip)[i]; | |
| 19968 | const template = "missing struct field: {}"; | |
| 19969 | const args = .{field_name.fmt(ip)}; | |
| 19970 | if (root_msg) |msg| { | |
| 19971 | try sema.errNote(block, init_src, msg, template, args); | |
| 19972 | } else { | |
| 19973 | root_msg = try sema.errMsg(block, init_src, template, args); | |
| 19974 | } | |
| 19971 | 19975 | } else { |
| 19972 | root_msg = try sema.errMsg(block, init_src, template, args); | |
| 19976 | const template = "missing tuple field with index {d}"; | |
| 19977 | if (root_msg) |msg| { | |
| 19978 | try sema.errNote(block, init_src, msg, template, .{i}); | |
| 19979 | } else { | |
| 19980 | root_msg = try sema.errMsg(block, init_src, template, .{i}); | |
| 19981 | } | |
| 19973 | 19982 | } |
| 19974 | 19983 | } else { |
| 19975 | 19984 | field_inits[i] = Air.internedToRef(field_init); |
test/cases/compile_errors/missing_field_in_struct_value_expression.zig+14
| ... | ... | @@ -13,9 +13,23 @@ export fn f() void { |
| 13 | 13 | _ = a; |
| 14 | 14 | } |
| 15 | 15 | |
| 16 | const B = struct { u32, u32 }; | |
| 17 | export fn g() void { | |
| 18 | const b = B{0}; | |
| 19 | _ = b; | |
| 20 | } | |
| 21 | export fn h() void { | |
| 22 | const c = B{}; | |
| 23 | _ = c; | |
| 24 | } | |
| 16 | 25 | // error |
| 17 | 26 | // backend=stage2 |
| 18 | 27 | // target=native |
| 19 | 28 | // |
| 20 | 29 | // :9:16: error: missing struct field: x |
| 21 | 30 | // :1:11: note: struct 'tmp.A' declared here |
| 31 | // :18:16: error: missing tuple field with index 1 | |
| 32 | // :16:11: note: struct declared here | |
| 33 | // :22:16: error: missing tuple field with index 0 | |
| 34 | // :22:16: note: missing tuple field with index 1 | |
| 35 | // :16:11: note: struct 'tmp.B' declared here |