authorgravatar for david@vortan.devDavid Rubin <david@vortan.dev> 2024-08-26 12:27:34-07:00
committergravatar for david@vortan.devDavid Rubin <david@vortan.dev> 2024-08-26 12:27:34-07:00
log61e8a6c0082778e9d7a120fb5b9c30ebf85d586b
tree68a56acd898e308845054123f0cf6816761d3fa1
parentf777b298327de95d2a54d814ca562c08fd7c7a87
signaturelock-open Commit is signed but in an unrecognized format.

remove some stale code

- Don't create an `inner_sema` in `unionFields` - Remove assertions of the sema owner, when we literally just set it

3 files changed, 3 insertions(+), 36 deletions(-)

src/InternPool.zig+2-2
......@@ -457,7 +457,7 @@ pub const Cau = struct {
457457 unwrapped.index);
458458 }
459459 };
460 pub fn unwrap(cau_index: Cau.Index, ip: *const InternPool) Unwrapped {
460 fn unwrap(cau_index: Cau.Index, ip: *const InternPool) Unwrapped {
461461 return .{
462462 .tid = @enumFromInt(@intFromEnum(cau_index) >> ip.tid_shift_31 & ip.getTidMask()),
463463 .index = @intFromEnum(cau_index) & ip.getIndexMask(u31),
......@@ -1464,7 +1464,7 @@ pub const NamespaceIndex = enum(u32) {
14641464 unwrapped.index);
14651465 }
14661466 };
1467 pub fn unwrap(namespace_index: NamespaceIndex, ip: *const InternPool) Unwrapped {
1467 fn unwrap(namespace_index: NamespaceIndex, ip: *const InternPool) Unwrapped {
14681468 const index = @intFromEnum(namespace_index) & ip.getIndexMask(u32);
14691469 return .{
14701470 .tid = @enumFromInt(@intFromEnum(namespace_index) >> ip.tid_shift_32 & ip.getTidMask()),
src/Sema.zig+1-30
......@@ -35458,9 +35458,6 @@ fn backingIntType(
3545835458 var analysis_arena = std.heap.ArenaAllocator.init(gpa);
3545935459 defer analysis_arena.deinit();
3546035460
35461 var comptime_err_ret_trace = std.ArrayList(LazySrcLoc).init(gpa);
35462 defer comptime_err_ret_trace.deinit();
35463
3546435461 var block: Block = .{
3546535462 .parent = null,
3546635463 .sema = sema,
......@@ -36114,9 +36111,6 @@ fn structFields(
3611436111 },
3611536112 };
3611636113
36117 var comptime_err_ret_trace = std.ArrayList(LazySrcLoc).init(gpa);
36118 defer comptime_err_ret_trace.deinit();
36119
3612036114 var block_scope: Block = .{
3612136115 .parent = null,
3612236116 .sema = sema,
......@@ -36300,7 +36294,6 @@ fn structFieldInits(
3630036294) CompileError!void {
3630136295 const pt = sema.pt;
3630236296 const zcu = pt.zcu;
36303 const gpa = zcu.gpa;
3630436297 const ip = &zcu.intern_pool;
3630536298
3630636299 assert(!struct_type.haveFieldInits(ip));
......@@ -36311,9 +36304,6 @@ fn structFieldInits(
3631136304 const zir_index = struct_type.zir_index.unwrap().?.resolve(ip) orelse return error.AnalysisFail;
3631236305 const fields_len, const small, var extra_index = structZirInfo(zir, zir_index);
3631336306
36314 var comptime_err_ret_trace = std.ArrayList(LazySrcLoc).init(gpa);
36315 defer comptime_err_ret_trace.deinit();
36316
3631736307 var block_scope: Block = .{
3631836308 .parent = null,
3631936309 .sema = sema,
......@@ -36475,28 +36465,9 @@ fn unionFields(
3647536465 const body = zir.bodySlice(extra_index, body_len);
3647636466 extra_index += body.len;
3647736467
36478 var comptime_err_ret_trace = std.ArrayList(LazySrcLoc).init(gpa);
36479 defer comptime_err_ret_trace.deinit();
36480
36481 const cau_index = union_type.cau;
36482
36483 var inner_sema: Sema = .{
36484 .pt = pt,
36485 .gpa = gpa,
36486 .arena = sema.arena,
36487 .code = zir,
36488 .owner = AnalUnit.wrap(.{ .cau = cau_index }),
36489 .func_index = .none,
36490 .func_is_naked = false,
36491 .fn_ret_ty = Type.void,
36492 .fn_ret_ty_ies = null,
36493 .comptime_err_ret_trace = &comptime_err_ret_trace,
36494 };
36495 defer inner_sema.deinit();
36496
3649736468 var block_scope: Block = .{
3649836469 .parent = null,
36499 .sema = &inner_sema,
36470 .sema = sema,
3650036471 .namespace = union_type.namespace,
3650136472 .instructions = .{},
3650236473 .inlining = null,
src/Type.zig-4
......@@ -3926,8 +3926,6 @@ fn resolveStructInner(
39263926 };
39273927 defer sema.deinit();
39283928
3929 assert(sema.owner.unwrap().cau == struct_obj.cau.unwrap().?);
3930
39313929 (switch (resolution) {
39323930 .fields => sema.resolveStructFieldTypes(ty.toIntern(), struct_obj),
39333931 .inits => sema.resolveStructFieldInits(ty),
......@@ -3982,8 +3980,6 @@ fn resolveUnionInner(
39823980 };
39833981 defer sema.deinit();
39843982
3985 assert(sema.owner.unwrap().cau == union_obj.cau);
3986
39873983 (switch (resolution) {
39883984 .fields => sema.resolveUnionFieldTypes(ty, union_obj),
39893985 .alignment => sema.resolveUnionAlignment(ty, union_obj),