authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2022-02-07 14:32:24-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2022-02-08 20:10:55-07:00
log61ed4fe07ad660f3cb4372937ccd5188ce404a44
treeb8baa621a18dfb06d86b9cd48774cc4c525a4d74
parent7c1061784b8b126633cfe84f46280f7bf72beffc

stage1: fix x86 i128 C ABI for extern structs

closes #10445

3 files changed, 76 insertions(+), 2 deletions(-)

src/stage1/analyze.cpp+11-2
......@@ -8684,14 +8684,23 @@ static Error resolve_llvm_c_abi_type(CodeGen *g, ZigType *ty) {
86848684 if (ty->data.structure.fields[i]->offset >= 8) {
86858685 eightbyte_index = 1;
86868686 }
8687 X64CABIClass field_class = type_c_abi_x86_64_class(g, ty->data.structure.fields[i]->type_entry);
8687 ZigType *field_ty = ty->data.structure.fields[i]->type_entry;
8688 X64CABIClass field_class = type_c_abi_x86_64_class(g, field_ty);
86888689
86898690 if (field_class == X64CABIClass_INTEGER) {
86908691 type_classes[eightbyte_index] = X64CABIClass_INTEGER;
86918692 } else if (type_classes[eightbyte_index] == X64CABIClass_Unknown) {
86928693 type_classes[eightbyte_index] = field_class;
86938694 }
8694 type_sizes[eightbyte_index] += ty->data.structure.fields[i]->type_entry->abi_size;
8695 if (field_ty->abi_size > 8) {
8696 assert(eightbyte_index == 0);
8697 type_sizes[0] = 8;
8698 type_sizes[1] = field_ty->abi_size - 8;
8699 type_classes[1] = type_classes[0];
8700 eightbyte_index = 1;
8701 } else {
8702 type_sizes[eightbyte_index] += field_ty->abi_size;
8703 }
86958704 }
86968705
86978706 LLVMTypeRef return_elem_types[] = {
test/stage1/c_abi/cfuncs.c+38
......@@ -11,14 +11,26 @@ static void assert_or_panic(bool ok) {
1111 }
1212}
1313
14struct i128 {
15 __int128 value;
16};
17
18struct u128 {
19 unsigned __int128 value;
20};
21
1422void zig_u8(uint8_t);
1523void zig_u16(uint16_t);
1624void zig_u32(uint32_t);
1725void zig_u64(uint64_t);
26void zig_u128(unsigned __int128);
27void zig_struct_u128(struct u128);
1828void zig_i8(int8_t);
1929void zig_i16(int16_t);
2030void zig_i32(int32_t);
2131void zig_i64(int64_t);
32void zig_i128(__int128);
33void zig_struct_i128(struct i128);
2234void zig_five_integers(int32_t, int32_t, int32_t, int32_t, int32_t);
2335
2436void zig_f32(float);
......@@ -130,11 +142,21 @@ void run_c_tests(void) {
130142 zig_u16(0xfffe);
131143 zig_u32(0xfffffffd);
132144 zig_u64(0xfffffffffffffffc);
145 zig_u128(0xfffffffffffffffc);
146 {
147 struct u128 s = {0xfffffffffffffffc};
148 zig_struct_u128(s);
149 }
133150
134151 zig_i8(-1);
135152 zig_i16(-2);
136153 zig_i32(-3);
137154 zig_i64(-4);
155 zig_i128(-5);
156 {
157 struct i128 s = {-6};
158 zig_struct_i128(s);
159 }
138160 zig_five_integers(12, 34, 56, 78, 90);
139161
140162 zig_f32(12.34f);
......@@ -221,6 +243,14 @@ void c_u64(uint64_t x) {
221243 assert_or_panic(x == 0xfffffffffffffffcULL);
222244}
223245
246void c_u128(unsigned __int128 x) {
247 assert_or_panic(x == 0xfffffffffffffffcULL);
248}
249
250void c_struct_u128(struct u128 x) {
251 assert_or_panic(x.value == 0xfffffffffffffffcULL);
252}
253
224254void c_i8(int8_t x) {
225255 assert_or_panic(x == -1);
226256}
......@@ -237,6 +267,14 @@ void c_i64(int64_t x) {
237267 assert_or_panic(x == -4);
238268}
239269
270void c_i128(__int128 x) {
271 assert_or_panic(x == -5);
272}
273
274void c_struct_i128(struct i128 x) {
275 assert_or_panic(x.value == -6);
276}
277
240278void c_f32(float x) {
241279 assert_or_panic(x == 12.34f);
242280}
test/stage1/c_abi/main.zig+27
......@@ -16,10 +16,14 @@ extern fn c_u8(u8) void;
1616extern fn c_u16(u16) void;
1717extern fn c_u32(u32) void;
1818extern fn c_u64(u64) void;
19extern fn c_u128(u128) void;
20extern fn c_struct_u128(U128) void;
1921extern fn c_i8(i8) void;
2022extern fn c_i16(i16) void;
2123extern fn c_i32(i32) void;
2224extern fn c_i64(i64) void;
25extern fn c_i128(i128) void;
26extern fn c_struct_i128(I128) void;
2327
2428// On windows x64, the first 4 are passed via registers, others on the stack.
2529extern fn c_five_integers(i32, i32, i32, i32, i32) void;
......@@ -37,11 +41,15 @@ test "C ABI integers" {
3741 c_u16(0xfffe);
3842 c_u32(0xfffffffd);
3943 c_u64(0xfffffffffffffffc);
44 c_u128(0xfffffffffffffffc);
45 c_struct_u128(.{ .value = 0xfffffffffffffffc });
4046
4147 c_i8(-1);
4248 c_i16(-2);
4349 c_i32(-3);
4450 c_i64(-4);
51 c_i128(-5);
52 c_struct_i128(.{ .value = -6 });
4553 c_five_integers(12, 34, 56, 78, 90);
4654}
4755
......@@ -57,6 +65,9 @@ export fn zig_u32(x: u32) void {
5765export fn zig_u64(x: u64) void {
5866 expect(x == 0xfffffffffffffffc) catch @panic("test failure");
5967}
68export fn zig_u128(x: u128) void {
69 expect(x == 0xfffffffffffffffc) catch @panic("test failure");
70}
6071export fn zig_i8(x: i8) void {
6172 expect(x == -1) catch @panic("test failure");
6273}
......@@ -69,6 +80,22 @@ export fn zig_i32(x: i32) void {
6980export fn zig_i64(x: i64) void {
7081 expect(x == -4) catch @panic("test failure");
7182}
83export fn zig_i128(x: i128) void {
84 expect(x == -5) catch @panic("test failure");
85}
86
87const I128 = extern struct {
88 value: i128,
89};
90const U128 = extern struct {
91 value: u128,
92};
93export fn zig_struct_i128(a: I128) void {
94 expect(a.value == -6) catch @panic("test failure");
95}
96export fn zig_struct_u128(a: U128) void {
97 expect(a.value == 0xfffffffffffffffc) catch @panic("test failure");
98}
7299
73100extern fn c_f32(f32) void;
74101extern fn c_f64(f64) void;