Commit 63b504219d119a13731811065d18a2b10b4214b3 | zig

author	Ryan Liptak <squeek502@hotmail.com> 2023-07-27 12:59:30-07:00
committer	Ryan Liptak <squeek502@hotmail.com> 2023-10-20 23:25:43-07:00
log	63b504219d119a13731811065d18a2b10b4214b3
tree	00eb29867b28f3369f7437aaf29de26009c1d772
parent	c139b9d4ad68d1cb5e2c489891493232a11db76c

Dir.makeOpenPathAccessMaskW: Use path.ComponentIterator

See 49053cb1b4af7ee2973cf606def398c7eef6578b for details

Also, fix leaking the intermediate directory handles.

1 files changed, 18 insertions(+), 20 deletions(-)

lib
- std
  - fs.zig

lib/std/fs.zig+18-20

 @@ -1490,33 +1490,31 @@ pub const Dir = struct {
     /// have been modified regardless.
     fn makeOpenPathAccessMaskW(self: Dir, sub_path: []const u8, access_mask: u32, no_follow: bool) OpenError!Dir {
         const w = os.windows;
-        var end_index: usize = sub_path.len;
+        var it = try path.componentIterator(sub_path);
+        // If there are no components in the path, then create a dummy component with the full path.
+        var component = it.last() orelse path.NativeUtf8ComponentIterator.Component{
+            .name = "",
+            .path = sub_path,
+        };
-        return while (true) {
+        while (true) {
-            const sub_path_w = try w.sliceToPrefixedFileW(sub_path[0..end_index]);
+            const sub_path_w = try w.sliceToPrefixedFileW(self.fd, component.path);
-            const result = self.makeOpenDirAccessMaskW(sub_path_w.span().ptr, access_mask, .{
+            const is_last = it.peekNext() == null;
+            var result = self.makeOpenDirAccessMaskW(sub_path_w.span().ptr, access_mask, .{
                 .no_follow = no_follow,
-                .create_disposition = if (end_index == sub_path.len) w.FILE_OPEN_IF else w.FILE_CREATE,
+                .create_disposition = if (is_last) w.FILE_OPEN_IF else w.FILE_CREATE,
             }) catch |err| switch (err) {
-                error.FileNotFound => {
+                error.FileNotFound => |e| {
-                    // march end_index backward until next path component
+                    component = it.previous() orelse return e;
-                    while (true) {
-                        if (end_index == 0) return err;
-                        end_index -= 1;
-                        if (path.isSep(sub_path[end_index])) break;
-                    }
                     continue;
                 },
-                else => return err,
+                else => |e| return e,
             };
-            if (end_index == sub_path.len) return result;
+            component = it.next() orelse return result;
-            // march end_index forward until next path component
+            // Don't leak the intermediate file handles
-            while (true) {
+            result.close();
-                end_index += 1;
+        }
-                if (end_index == sub_path.len or path.isSep(sub_path[end_index])) break;
-            }
-        };
     }
     /// This function performs `makePath`, followed by `openDir`.