Commit 67d27dbe631d1292be363f4121217d66e2d7fd0f | zig

author	Luuk de Gram <luuk@degram.dev> 2023-05-06 17:46:51+02:00
committer	Luuk de Gram <luuk@degram.dev> 2023-05-19 20:18:59+02:00
log	67d27dbe631d1292be363f4121217d66e2d7fd0f
tree	a75355b2c870c352a8f977a72d29376674d17553
parent	e20976b7f209a768cb55a37e6a58ed177d76013e
signature	Commit is signed but in an unrecognized format.

wasm: fix liveness bugs

Make sure to increase the reference count for `intcast` when the
operand doesn't require any casting of the respective WebAssembly type.

Function arguments have a reserved slot, and therefore cannot be
re-used arbitrarily

1 files changed, 10 insertions(+), 1 deletions(-)

src
- arch
  - wasm
    CodeGen.zig

src/arch/wasm/CodeGen.zig+10-1

 @@ -881,6 +881,9 @@ fn processDeath(func: *CodeGen, ref: Air.Inst.Ref) void {
     const value = func.currentBranch().values.getPtr(ref) orelse return;
     if (value.* != .local) return;
     log.debug("Decreasing reference for ref: %{?d}\n", .{Air.refToIndex(ref)});
+    if (value.local.value < func.arg_index) {
+        return; // function arguments can never be re-used
+    }
     value.local.references -= 1; // if this panics, a call to `reuseOperand` was forgotten by the developer
     if (value.local.references == 0) {
         value.free(func);
 @@ -4021,7 +4024,13 @@ fn airIntcast(func: *CodeGen, inst: Air.Inst.Index) InnerError!void {
         return func.fail("todo Wasm intcast for bitsize > 128", .{});
     }
-    const result = try (try func.intcast(operand, operand_ty, ty)).toLocal(func, ty);
+    const op_bits = toWasmBits(@intCast(u16, ty.bitSize(func.target))).?;
+    const wanted_bits = toWasmBits(@intCast(u16, ty.bitSize(func.target))).?;
+    const result = if (op_bits == wanted_bits)
+        func.reuseOperand(ty_op.operand, operand)
+    else
+        try (try func.intcast(operand, operand_ty, ty)).toLocal(func, ty);
     func.finishAir(inst, result, &.{});
 }