Commit 67dac2936cb1fc2ce1d3ea00a5c8e574921aded3 | zig

author	Veikka Tuominen <git@vexu.eu> 2021-02-22 10:04:05+02:00
committer	Veikka Tuominen <git@vexu.eu> 2021-02-22 10:04:05+02:00
log	67dac2936cb1fc2ce1d3ea00a5c8e574921aded3
tree	5b24fa50a184ef3ef4d6ae8f53c76eec4b1282ca
parent	621ad241d6dfbde60ee8a5b1d0dcd7d9cf29f8f3
signature	Commit is signed but in an unrecognized format.

parser: warn on missing for loop payload, recover from invalid global error set access

3 files changed, 54 insertions(+), 12 deletions(-)

lib
- std
  - zig
    ast.zig
    parse.zig
    parser_test.zig

lib/std/zig/ast.zig+6

 @@ -253,6 +253,11 @@ pub const Tree = struct {
                     token_tags[parse_error.token].symbol(),
                 });
             },
+            .expected_loop_payload => {
+                return stream.print("expected loop payload, found '{s}'", .{
+                    token_tags[parse_error.token].symbol(),
+                });
+            },
             .extra_align_qualifier => {
                 return stream.writeAll("extra align qualifier");
             },
 @@ -2332,6 +2337,7 @@ pub const Error = struct {
         expected_type_expr,
         expected_var_decl,
         expected_var_decl_or_fn,
+        expected_loop_payload,
         extra_align_qualifier,
         extra_allowzero_qualifier,
         extra_const_qualifier,

lib/std/zig/parse.zig+32-12

 @@ -1052,7 +1052,8 @@ const Parser = struct {
         _ = try p.expectToken(.l_paren);
         const array_expr = try p.expectExpr();
         _ = try p.expectToken(.r_paren);
-        _ = try p.parsePtrIndexPayload();
+        const found_payload = try p.parsePtrIndexPayload();
+        if (found_payload == 0) try p.warn(.expected_loop_payload);
         // TODO propose to change the syntax so that semicolons are always required
         // inside while statements, even if there is an `else`.
 @@ -2067,7 +2068,8 @@ const Parser = struct {
         _ = try p.expectToken(.l_paren);
         const array_expr = try p.expectExpr();
         _ = try p.expectToken(.r_paren);
-        _ = try p.parsePtrIndexPayload();
+        const found_payload = try p.parsePtrIndexPayload();
+        if (found_payload == 0) try p.warn(.expected_loop_payload);
         const then_expr = try p.expectExpr();
         const else_token = p.eatToken(.keyword_else) orelse {
 @@ -2672,6 +2674,16 @@ const Parser = struct {
                     },
                 }),
             },
+            .keyword_inline => {
+                p.tok_i += 1;
+                switch (p.token_tags[p.tok_i]) {
+                    .keyword_for => return p.parseForTypeExpr(),
+                    .keyword_while => return p.parseWhileTypeExpr(),
+                    else => return p.fail(.expected_inlinable),
+                }
+            },
+            .keyword_for => return p.parseForTypeExpr(),
+            .keyword_while => return p.parseWhileTypeExpr(),
             .period => switch (p.token_tags[p.tok_i + 1]) {
                 .identifier => return p.addNode(.{
                     .tag = .enum_literal,
 @@ -2879,14 +2891,21 @@ const Parser = struct {
                         },
                     });
                 },
-                else => return p.addNode(.{
+                else => {
-                    .tag = .error_value,
+                    const main_token = p.nextToken();
-                    .main_token = p.nextToken(),
+                    const period = p.eatToken(.period);
-                    .data = .{
+                    if (period == null) try p.warnExpected(.period);
-                        .lhs = try p.expectToken(.period),
+                    const identifier = p.eatToken(.identifier);
-                        .rhs = try p.expectToken(.identifier),
+                    if (identifier == null) try p.warnExpected(.identifier);
-                    },
+                    return p.addNode(.{
-                }),
+                        .tag = .error_value,
+                        .main_token = main_token,
+                        .data = .{
+                            .lhs = period orelse 0,
+                            .rhs = identifier orelse 0,
+                        },
+                    });
+                },
             },
             .l_paren => return p.addNode(.{
                 .tag = .grouped_expression,
 @@ -2913,9 +2932,10 @@ const Parser = struct {
     fn parseForTypeExpr(p: *Parser) !Node.Index {
         const for_token = p.eatToken(.keyword_for) orelse return null_node;
         _ = try p.expectToken(.l_paren);
-        const array_expr = try p.expectTypeExpr();
+        const array_expr = try p.expectExpr();
         _ = try p.expectToken(.r_paren);
-        _ = try p.parsePtrIndexPayload();
+        const found_payload = try p.parsePtrIndexPayload();
+        if (found_payload == 0) try p.warn(.expected_loop_payload);
         const then_expr = try p.expectExpr();
         const else_token = p.eatToken(.keyword_else) orelse {

lib/std/zig/parser_test.zig+16

...	@@ -4215,6 +4215,8 @@ test "recovery: invalid global error set access" {	...	@@ -4215,6 +4215,8 @@ test "recovery: invalid global error set access" {
4215	\\}	4215	\\}
4216	, &[_]Error{	4216	, &[_]Error{
4217	.expected_token,	4217	.expected_token,
		4218	.expected_token,
		4219	.invalid_and,
4218	});	4220	});
4219	}	4221	}
4220		4222
...	@@ -4273,6 +4275,20 @@ test "recovery: missing block after for/while loops" {	...	@@ -4273,6 +4275,20 @@ test "recovery: missing block after for/while loops" {
4273	});	4275	});
4274	}	4276	}
4275		4277
		4278	test "recovery: missing for payload" {
		4279	try testError(
		4280	\\comptime {
		4281	\\ const a = for(a) {};
		4282	\\ const a: for(a) {};
		4283	\\ for(a) {}
		4284	\\}
		4285	, &[_]Error{
		4286	.expected_loop_payload,
		4287	.expected_loop_payload,
		4288	.expected_loop_payload,
		4289	});
		4290	}
		4291
4276	const std = @import("std");	4292	const std = @import("std");
4277	const mem = std.mem;	4293	const mem = std.mem;
4278	const warn = std.debug.warn;	4294	const warn = std.debug.warn;