Commit 6eb76f930defb86d09469f73196b374c90f7f8a5 | zig

author	Pavel Verigo <paul.verigo@gmail.com> 2024-07-04 17:40:28+02:00
committer	Pavel Verigo <paul.verigo@gmail.com> 2024-07-18 00:57:18+02:00
log	6eb76f930defb86d09469f73196b374c90f7f8a5
tree	8f57a4e96c1df196f5851edf11574d8668594af0
parent	9356cb1475606a7afd2e722af60f87ce2b39f9f8

stage2-wasm: typeToValtype focus on .auto callconv

This is required for toLocal() correctly handling isByRef values, previous behavior was a hack.

1 files changed, 26 insertions(+), 26 deletions(-)

src
- arch
  - wasm
    CodeGen.zig

src/arch/wasm/CodeGen.zig+26-26

 @@ -990,44 +990,44 @@ fn addExtraAssumeCapacity(func: *CodeGen, extra: anytype) error{OutOfMemory}!u32
     return result;
 }
-/// Using a given `Type`, returns the corresponding type
+/// Using a given `Type`, returns the corresponding valtype for .auto callconv
 fn typeToValtype(ty: Type, pt: Zcu.PerThread) wasm.Valtype {
     const mod = pt.zcu;
     const target = mod.getTarget();
     const ip = &mod.intern_pool;
     return switch (ty.zigTypeTag(mod)) {
         .Float => switch (ty.floatBits(target)) {
-            16 => wasm.Valtype.i32, // stored/loaded as u16
+            16 => .i32, // stored/loaded as u16
-            32 => wasm.Valtype.f32,
+            32 => .f32,
-            64 => wasm.Valtype.f64,
+            64 => .f64,
-            80, 128 => wasm.Valtype.i64,
+            80, 128 => .i32,
             else => unreachable,
         },
-        .Int, .Enum => blk: {
+        .Int, .Enum => switch (ty.intInfo(pt.zcu).bits) {
-            const info = ty.intInfo(pt.zcu);
+            0...32 => .i32,
-            if (info.bits <= 32) break :blk wasm.Valtype.i32;
+            33...64 => .i64,
-            if (info.bits > 32 and info.bits <= 128) break :blk wasm.Valtype.i64;
+            else => .i32,
-            break :blk wasm.Valtype.i32; // represented as pointer to stack
         },
-        .Struct => {
+        .Struct => blk: {
             if (pt.zcu.typeToPackedStruct(ty)) |packed_struct| {
-                return typeToValtype(Type.fromInterned(packed_struct.backingIntTypeUnordered(ip)), pt);
+                const backing_int_ty = Type.fromInterned(packed_struct.backingIntTypeUnordered(ip));
+                break :blk typeToValtype(backing_int_ty, pt);
             } else {
-                return wasm.Valtype.i32;
+                break :blk .i32;
             }
         },
         .Vector => switch (determineSimdStoreStrategy(ty, pt)) {
-            .direct => wasm.Valtype.v128,
+            .direct => .v128,
-            .unrolled => wasm.Valtype.i32,
+            .unrolled => .i32,
         },
         .Union => switch (ty.containerLayout(pt.zcu)) {
-            .@"packed" => {
+            .@"packed" => blk: {
                 const int_ty = pt.intType(.unsigned, @as(u16, @intCast(ty.bitSize(pt)))) catch @panic("out of memory");
-                return typeToValtype(int_ty, pt);
+                break :blk typeToValtype(int_ty, pt);
             },
-            else => wasm.Valtype.i32,
+            else => .i32,
         },
-        else => wasm.Valtype.i32, // all represented as reference/immediate
+        else => .i32, // all represented as reference/immediate
     };
 }
 @@ -1180,20 +1180,20 @@ fn genFunctype(
         switch (cc) {
             .C => {
                 const param_classes = abi.classifyType(param_type, pt);
-                for (param_classes) |class| {
+                if (param_classes[1] == .none) {
-                    if (class == .none) continue;
+                    if (param_classes[0] == .direct) {
-                    if (class == .direct) {
                         const scalar_type = abi.scalarType(param_type, pt);
                         try temp_params.append(typeToValtype(scalar_type, pt));
                     } else {
                         try temp_params.append(typeToValtype(param_type, pt));
                     }
+                } else {
+                    // i128/f128
+                    try temp_params.append(.i64);
+                    try temp_params.append(.i64);
                 }
             },
-            else => if (isByRef(param_type, pt))
+            else => try temp_params.append(typeToValtype(param_type, pt)),
-                try temp_params.append(.i32)
-            else
-                try temp_params.append(typeToValtype(param_type, pt)),
         }
     }