Commit 759c2211c2eba44cccf0608267bf1a05934ad8a1 | zig

author	Andrew Kelley <andrew@ziglang.org> 2024-05-27 14:01:08-07:00
committer	Andrew Kelley <andrew@ziglang.org> 2024-05-27 19:15:40-04:00
log	759c2211c2eba44cccf0608267bf1a05934ad8a1
tree	5dfeba51be37bbb97dca22143bb68d601c8adee6
parent	c0da92f71476651ac654249d54512e514b55df55

test cases: try running foreign binaries

You don't know if it's possible to run a binary until you try. The build
system already integrates with executors and has the
`skip_foreign_checks` for exactly this use case.

1 files changed, 1 insertions(+), 8 deletions(-)

test
- src
  - Cases.zig

test/src/Cases.zig+1-8

 @@ -545,9 +545,6 @@ pub fn lowerToTranslateCSteps(
     target: std.Build.ResolvedTarget,
     translate_c_options: TranslateCOptions,
 ) void {
-    const host = std.zig.system.resolveTargetQuery(.{}) catch |err|
-        std.debug.panic("unable to detect native host: {s}\n", .{@errorName(err)});
     const tests = @import("../tests.zig");
     const test_translate_c_step = b.step("test-translate-c", "Run the C translation tests");
     if (!translate_c_options.skip_translate_c) {
 @@ -573,11 +570,6 @@ pub fn lowerToTranslateCSteps(
                 continue; // Pass test.
             }
-            if (getExternalExecutor(host, &case.target.result, .{ .link_libc = true }) != .native) {
-                // We wouldn't be able to run the compiled C code.
-                continue; // Pass test.
-            }
             const write_src = b.addWriteFiles();
             const file_source = write_src.add("tmp.c", case.input);
 @@ -596,6 +588,7 @@ pub fn lowerToTranslateCSteps(
             const run = b.addRunArtifact(run_exe);
             run.step.name = b.fmt("{s} run", .{annotated_case_name});
             run.expectStdOutEqual(output);
+            run.skip_foreign_checks = true;
             test_run_translated_c_step.dependOn(&run.step);
         },