Commit 78e07b8fc83469ba63de8654091145b93fe5a248 | zig

author	Ryan Liptak <squeek502@hotmail.com> 2025-09-30 22:08:43-07:00
committer	Ryan Liptak <squeek502@hotmail.com> 2025-10-03 17:44:36-07:00
log	78e07b8fc83469ba63de8654091145b93fe5a248
tree	5256f6a169f86885c865a5040b127f45a11557a8
parent	07c3f9ef8e0a5a557dce70322334b0d1b49fe154

std.coff: Fix SectionHeader.setAlignment (off by 1)

Previously, `setAlignment` would set the value to 1 fewer than it should, so if you were intending to set alignment to 8 bytes, it would actually set it to 4 bytes, etc.

1 files changed, 12 insertions(+), 4 deletions(-)

lib
- std
  - coff.zig

lib/std/coff.zig+12-4

 @@ -528,13 +528,11 @@ pub const SectionHeader = extern struct {
     /// Applicable only to section headers in COFF objects.
     pub fn getAlignment(self: SectionHeader) ?u16 {
-        if (self.flags.ALIGN == 0) return null;
+        return self.flags.ALIGN.toByteUnits();
-        return std.math.powi(u16, 2, self.flags.ALIGN - 1) catch unreachable;
     }
     pub fn setAlignment(self: *SectionHeader, new_alignment: u16) void {
-        assert(new_alignment > 0 and new_alignment <= 8192);
+        self.flags.ALIGN = .fromByteUnits(new_alignment);
-        self.flags.ALIGN = @intCast(std.math.log2(new_alignment));
     }
     pub fn isCode(self: SectionHeader) bool {
 @@ -651,6 +649,16 @@ pub const SectionHeader = extern struct {
             @"4096BYTES" = 13,
             @"8192BYTES" = 14,
             _,
+            pub fn toByteUnits(a: Align) ?u16 {
+                if (a == .NONE) return null;
+                return @as(u16, 1) << (@intFromEnum(a) - 1);
+            }
+            pub fn fromByteUnits(n: u16) Align {
+                std.debug.assert(std.math.isPowerOfTwo(n));
+                return @enumFromInt(@ctz(n) + 1);
+            }
         };
     };
 };