authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2022-03-16 20:35:41-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2022-03-16 20:35:41-07:00
log80642b5984e5e7a59d380ced4c19e71c5e4cee32
treed00ab6e1457220039868b041bb1ae891d594bd9d
parentc8ed813097ebb679e858a7764673f6236e638ea4

remove unnecessary TODO comment

`testing.expect` is better than `testing.expectEqual` for behavior tests. Better for behavior tests to stick to only testing the limited behavior they are meant to test and avoid functions such as `expectEqual` that drag in too much of the standard library (in this case to print helpful diffs about why a value is not equal to another).

1 files changed, 0 insertions(+), 16 deletions(-)

test/behavior/muladd.zig-16
...@@ -85,10 +85,6 @@ fn vector16() !void {...@@ -85,10 +85,6 @@ fn vector16() !void {
85 var c = @Vector(4, f16){ 6.25, 6.25, 6.25, 6.25 };85 var c = @Vector(4, f16){ 6.25, 6.25, 6.25, 6.25 };
86 var x = @mulAdd(@Vector(4, f16), a, b, c);86 var x = @mulAdd(@Vector(4, f16), a, b, c);
8787
88 // TODO use `expectEqual` instead once stage2 supports it
89 // var expected = @Vector(4, f16){ 20, 20, 20, 20 };
90 // try expectEqual(expected, x);
91
92 try expect(x[0] == 20);88 try expect(x[0] == 20);
93 try expect(x[1] == 20);89 try expect(x[1] == 20);
94 try expect(x[2] == 20);90 try expect(x[2] == 20);
...@@ -113,10 +109,6 @@ fn vector32() !void {...@@ -113,10 +109,6 @@ fn vector32() !void {
113 var c = @Vector(4, f32){ 6.25, 6.25, 6.25, 6.25 };109 var c = @Vector(4, f32){ 6.25, 6.25, 6.25, 6.25 };
114 var x = @mulAdd(@Vector(4, f32), a, b, c);110 var x = @mulAdd(@Vector(4, f32), a, b, c);
115111
116 // TODO use `expectEqual` instead once stage2 supports it
117 // var expected = @Vector(4, f32){ 20, 20, 20, 20 };
118 // try expectEqual(expected, x);
119
120 try expect(x[0] == 20);112 try expect(x[0] == 20);
121 try expect(x[1] == 20);113 try expect(x[1] == 20);
122 try expect(x[2] == 20);114 try expect(x[2] == 20);
...@@ -141,10 +133,6 @@ fn vector64() !void {...@@ -141,10 +133,6 @@ fn vector64() !void {
141 var c = @Vector(4, f64){ 6.25, 6.25, 6.25, 6.25 };133 var c = @Vector(4, f64){ 6.25, 6.25, 6.25, 6.25 };
142 var x = @mulAdd(@Vector(4, f64), a, b, c);134 var x = @mulAdd(@Vector(4, f64), a, b, c);
143135
144 // TODO use `expectEqual` instead once stage2 supports it
145 // var expected = @Vector(4, f64){ 20, 20, 20, 20 };
146 // try expectEqual(expected, x);
147
148 try expect(x[0] == 20);136 try expect(x[0] == 20);
149 try expect(x[1] == 20);137 try expect(x[1] == 20);
150 try expect(x[2] == 20);138 try expect(x[2] == 20);
...@@ -190,10 +178,6 @@ fn vector128() !void {...@@ -190,10 +178,6 @@ fn vector128() !void {
190 var c = @Vector(4, f128){ 6.25, 6.25, 6.25, 6.25 };178 var c = @Vector(4, f128){ 6.25, 6.25, 6.25, 6.25 };
191 var x = @mulAdd(@Vector(4, f128), a, b, c);179 var x = @mulAdd(@Vector(4, f128), a, b, c);
192180
193 // TODO use `expectEqual` instead once stage2 supports it
194 // var expected = @Vector(4, f128){ 20, 20, 20, 20 };
195 // try expectEqual(expected, x);
196
197 try expect(x[0] == 20);181 try expect(x[0] == 20);
198 try expect(x[1] == 20);182 try expect(x[1] == 20);
199 try expect(x[2] == 20);183 try expect(x[2] == 20);