Commit 81be5b22a34424972c6b75201c510f5159f5d4f3 | zig

author	Techatrix <techatrix@mailbox.org> 2026-08-29 00:45:49+02:00
committer	Techatrix <techatrix@mailbox.org> 2026-08-29 00:45:49+02:00
log	81be5b22a34424972c6b75201c510f5159f5d4f3
tree	2becd70abd9550d2ba4c73c0f123a74fca48b80d
parent	5926dd027df2f35d4ff3610c16cfcad8e0b3a4b5
signature	Signed by SSH key SHA256:HYC3SjXQcAt6uwv9pu/6OoVQ2rUH8rb5zKiUHSe9uxk

Maker: fix leaks on process exit

Can be observed with `--debug-maker-leaks`.

2 files changed, 28 insertions(+), 19 deletions(-)

lib
- compiler
  - Maker.zig
  - Maker
    Step.zig

lib/compiler/Maker.zig+19-19

 @@ -63,9 +63,9 @@ protocol_server_mutex: Io.Mutex,
 web_server: ?*AvoidableWebServer,
 /// Allocated into `gpa`.
 memory_blocked_steps: std.ArrayList(Configuration.Step.Index),
-/// Allocated into `gpa`.
+/// Allocated into `gpa` during `prepare`.
 initial_steps: std.array_hash_map.Auto(Configuration.Step.Index, void),
-/// Allocated into `gpa`.
+/// Allocated into `gpa` during `prepare`.
 step_stack: std.array_hash_map.Auto(Configuration.Step.Index, void),
 pkg_config: PkgConfig,
 @@ -762,10 +762,8 @@ pub fn main(init: process.Init.Minimal) !void {
                     .include = install_include_path,
                 },
-                // Extra step at the end which is the autogenerated placeholder
+                .steps = &.{},
-                // step which indicates that we need to reconfigure.
+                .generated_files = &.{},
-                .steps = try arena.alloc(Step, scanned_config.configuration.steps.len + 1),
-                .generated_files = try arena.alloc(Path, scanned_config.configuration.generated_files_len),
                 .run_args = run_args,
                 .available_rss = max_rss,
 @@ -792,11 +790,7 @@ pub fn main(init: process.Init.Minimal) !void {
                 else
                     .failures,
             };
-            defer {
+            defer maker.deinit();
-                maker.memory_blocked_steps.deinit(gpa);
-                maker.initial_steps.deinit(gpa);
-                maker.step_stack.deinit(gpa);
-            }
             if (maker.available_rss == 0) {
                 maker.available_rss = process.totalSystemMemory() catch std.math.maxInt(u64);
 @@ -863,6 +857,9 @@ pub fn main(init: process.Init.Minimal) !void {
                                         &watch.?,
                                         if (in_debounce) .{ .ms = debounce_interval_ms } else .none,
                                     });
+                                } else if (watch) |*w| {
+                                    w.deinit();
+                                    watch = null;
                                 }
                                 continue :loop try select.await();
 @@ -915,7 +912,7 @@ pub fn main(init: process.Init.Minimal) !void {
                 if (!Watch.have_impl) fatal("--watch not yet implemented for {t}", .{native_os});
                 break :w try .init(&maker);
             };
-            defer w.deinit();
+            defer if (watch_flag) w.deinit();
             if (web_server) |ws| try ws.updateConfiguration(&maker);
 @@ -2229,6 +2226,11 @@ fn prepare(
     const step_stack = &maker.step_stack;
     const c = &maker.scanned_config.configuration;
+    // Extra step at the end which is the autogenerated placeholder
+    // step which indicates that we need to reconfigure.
+    maker.steps = try arena.alloc(Step, c.steps.len + 1);
+    maker.generated_files = try arena.alloc(Path, c.generated_files_len);
     // The last element is a reserved special pseudostep which contains the
     // watch inputs for the configurer executable.
     for (maker.steps[0 .. maker.steps.len - 1], 0..) |*step, step_index_usize| {
 @@ -2549,7 +2551,7 @@ fn makeSteps(
     };
     if (code == 0) {
         removePoisonedConfiguration(io, maker.scanned_config);
-        if (debugMakerLeaks()) return deinit(maker);
+        if (debugMakerLeaks()) return;
     }
     cleanup_task.await(io); // There is a defer above but an exit below.
     _ = io.lockStderr(&.{}, graph.stderr_mode) catch {};
 @@ -2558,12 +2560,10 @@ fn makeSteps(
 fn deinit(maker: *Maker) void {
     const gpa = maker.gpa;
-    for (maker.steps) |*step| {
+    for (maker.steps) |*step| step.deinit(gpa);
-        step.clearResultStderr(gpa);
+    maker.memory_blocked_steps.deinit(gpa);
-        step.clearFailedCommand(gpa);
+    maker.initial_steps.deinit(gpa);
-        step.clearErrorBundle(gpa);
+    maker.step_stack.deinit(gpa);
-        step.inputs.deinit(gpa);
-    }
 }
 fn stepReady(

lib/compiler/Maker/Step.zig+9

...	@@ -309,6 +309,15 @@ pub fn make(	...	@@ -309,6 +309,15 @@ pub fn make(
309	}	309	}
310	}	310	}
311		311
		312	pub fn deinit(step: *Step, gpa: Allocator) void {
		313	step.clearResultStderr(gpa);
		314	step.clearFailedCommand(gpa);
		315	step.clearErrorBundle(gpa);
		316	step.inputs.deinit(gpa);
		317	if (step.getZigProcess()) \|zp\| gpa.destroy(zp);
		318	step.* = undefined;
		319	}
		320
312	/// Prepares the step for being re-evaluated.	321	/// Prepares the step for being re-evaluated.
313	pub fn reset(step: Step, maker: Maker) void {	322	pub fn reset(step: Step, maker: Maker) void {
314	assert(step.state == .precheck_done);	323	assert(step.state == .precheck_done);