Commit 8464efa5dd792de25ee8faa413c89f1daf8b5efb | zig

author	Andrew Kelley <andrew@ziglang.org> 2025-02-18 23:30:46-08:00
committer	Andrew Kelley <andrew@ziglang.org> 2025-07-01 16:35:26-07:00
log	8464efa5dd792de25ee8faa413c89f1daf8b5efb
tree	4f442e36625e6798de96556174a6138dd7f4bf2a
parent	a500651370b3ca60f0fe8fba67d0124f136f0ec0

std.posix.sendfile: don't write trailers on linux

After sending the file, better to return total bytes written. The caller
will decide if they want to do another syscall with the trailers. Maybe
the caller would rather buffer them.

1 files changed, 1 insertions(+), 12 deletions(-)

lib
- std
  - posix.zig

lib/std/posix.zig+1-12

 @@ -6092,17 +6092,13 @@ pub const SendError = error{
 pub const SendMsgError = SendError || error{
     /// The passed address didn't have the correct address family in its sa_family field.
     AddressFamilyNotSupported,
     /// Returned when socket is AF.UNIX and the given path has a symlink loop.
     SymLinkLoop,
     /// Returned when socket is AF.UNIX and the given path length exceeds `max_path_bytes` bytes.
     NameTooLong,
     /// Returned when socket is AF.UNIX and the given path does not point to an existing file.
     FileNotFound,
     NotDir,
     /// The socket is not connected (connection-oriented sockets only).
     SocketNotConnected,
     AddressNotAvailable,
 @@ -6400,14 +6396,7 @@ pub fn sendfile(
                     .SUCCESS => {
                         const amt: usize = @bitCast(rc);
                         total_written += amt;
-                        if (in_len == 0 and amt == 0) {
+                        return total_written;
-                            // We have detected EOF from `in_fd`.
-                            break;
-                        } else if (amt < in_len) {
-                            return total_written;
-                        } else {
-                            break;
-                        }
                     },
                     .BADF => unreachable, // Always a race condition.