Commit 8692c6fc0da831421855c27008dc046dcf59fca7 | zig

author	Andrew Kelley <andrew@ziglang.org> 2019-07-08 02:10:26-04:00
committer	Andrew Kelley <andrew@ziglang.org> 2019-07-08 02:10:26-04:00
log	8692c6fc0da831421855c27008dc046dcf59fca7
tree	d042d93769ffce699cdf00a12b2f37d79e16c05d
parent	f04782785f66879db1f31dd6620cd31161c4da08
signature	Commit is signed but in an unrecognized format.

zero initialize target

Fixes glibc_version being set to garbage. I've made this mistake
before so this is an attempt to prevent future bugs. Zig doesn't
have zero-initialization, so are we being a hypocrite by using this
C feature? No, because C doesn't have the feature that forces you to
initialize all fields. That would have prevented this bug every single
time.

1 files changed, 7 insertions(+), 4 deletions(-)

src
- target.cpp

src/target.cpp+7-4

...	...	@@ -492,6 +492,9 @@ Error target_parse_glibc_version(ZigGLibCVersion glibc_ver, const char text) {
492	492	}
493	493
494	494	void get_native_target(ZigTarget *target) {
	495	// first zero initialize
	496	*target = {};
	497
495	498	ZigLLVM_OSType os_type;
496	499	ZigLLVM_ObjectFormatType oformat; // ignored; based on arch/os
497	500	ZigLLVMGetNativeTarget(
...	...	@@ -506,7 +509,6 @@ void get_native_target(ZigTarget *target) {
506	509	if (target->abi == ZigLLVM_UnknownEnvironment) {
507	510	target->abi = target_default_abi(target->arch, target->os);
508	511	}
509		target->glibc_version = nullptr;
510	512	if (target_is_glibc(target)) {
511	513	target->glibc_version = allocate<ZigGLibCVersion>(1);
512	514	*target->glibc_version = {2, 17, 0};
...	...	@@ -703,6 +705,10 @@ Error target_parse_abi(ZigLLVM_EnvironmentType out_abi, const char abi_ptr, si
703	705
704	706	Error target_parse_triple(ZigTarget target, const char triple) {
705	707	Error err;
	708
	709	// first initialize all to zero
	710	*target = {};
	711
706	712	SplitIterator it = memSplit(str(triple), str("-"));
707	713
708	714	Optional<Slice<uint8_t>> opt_archsub = SplitIterator_next(&it);
...	...	@@ -732,9 +738,6 @@ Error target_parse_triple(ZigTarget target, const char triple) {
732	738	} else {
733	739	target->abi = target_default_abi(target->arch, target->os);
734	740	}
735
736		target->vendor = ZigLLVM_UnknownVendor;
737		target->is_native = false;
738	741	return ErrorNone;
739	742	}
740	743