authorgravatar for contact@fengb.meBenjamin Feng <contact@fengb.me> 2019-12-04 21:41:01-06:00
committergravatar for contact@fengb.meBenjamin Feng <contact@fengb.me> 2019-12-04 21:41:01-06:00
log86ae75363e3fbf6b3835b87c1cfb79fe4bf97790
treee38ca9602657397997f74696d25a252e1a58bf59
parent5784985bb8a4c6aa686ad0b9fb98532c44c74b85

Strip out an unnecessary memset


1 files changed, 18 insertions(+), 15 deletions(-)

lib/std/heap.zig+18-15
......@@ -254,31 +254,30 @@ extern fn @"llvm.wasm.memory.grow.i32"(u32, u32) i32;
254254
255255const WasmPageAllocator = struct {
256256 // TODO: figure out why __heap_base cannot be found
257 var heap_base_wannabe: [256]u8 align(16) = undefined;
257 var heap_base_wannabe align(16) = [_]u8{0} ** 256;
258258
259259 const FreeBlock = struct {
260 const Io = std.packed_int_array.PackedIntIo(u1, .Little);
261
262260 bytes: []align(16) u8,
263261
264 fn initData(self: *FreeBlock, bytes: []align(16) u8) void {
265 // 0 == used, 1 == free
266 std.mem.set(u8, bytes, 0);
267 self.bytes = bytes;
268 }
262 const Io = std.packed_int_array.PackedIntIo(u1, .Little);
263
264 const used = 0;
265 const free = 1;
269266
270267 fn totalPages(self: FreeBlock) usize {
271268 return self.bytes.len * 8;
272269 }
273270
274271 fn getBit(self: *FreeBlock, idx: usize) u1 {
275 return Io.get(self.bytes, idx, 0);
272 const bit_offset = 0;
273 return Io.get(self.bytes, idx, bit_offset);
276274 }
277275
278276 fn setBits(self: *FreeBlock, start_idx: usize, len: usize, val: u1) void {
277 const bit_offset = 0;
279278 var i: usize = 0;
280279 while (i < len) : (i += 1) {
281 Io.set(self.bytes, start_idx + i, 0, val);
280 Io.set(self.bytes, start_idx + i, bit_offset, val);
282281 }
283282 }
284283
......@@ -306,7 +305,7 @@ const WasmPageAllocator = struct {
306305 while (j + count < self.totalPages() and self.getBit(j + count) == 1) {
307306 count += 1;
308307 if (count >= num_pages) {
309 self.setBits(j, num_pages, 0);
308 self.setBits(j, num_pages, used);
310309 return j;
311310 }
312311 }
......@@ -317,7 +316,7 @@ const WasmPageAllocator = struct {
317316 }
318317
319318 fn recycle(self: *FreeBlock, start_idx: usize, len: usize) void {
320 self.setBits(start_idx, len, 1);
319 self.setBits(start_idx, len, free);
321320 }
322321 };
323322
......@@ -375,8 +374,8 @@ const WasmPageAllocator = struct {
375374
376375 if (free_end > free_start) {
377376 if (conventional.totalPages() == 0) {
378 //conventional.initData(__heap_base[0..@intCast(usize, @"llvm.wasm.memory.size.i32"(0) * std.mem.page_size)]);
379 conventional.initData(heap_base_wannabe[0..]);
377 //conventional.bytes = __heap_base[0..@intCast(usize, @"llvm.wasm.memory.size.i32"(0) * std.mem.page_size)];
378 conventional.bytes = heap_base_wannabe[0..];
380379 }
381380
382381 if (free_start < extendedOffset()) {
......@@ -384,8 +383,12 @@ const WasmPageAllocator = struct {
384383 } else {
385384 if (extended.totalPages() == 0) {
386385 // Steal the last page from the memory currently being recycled
386 // TODO: would it be better if we use the first page instead?
387387 free_end -= 1;
388 extended.initData(@intToPtr([*]align(16) u8, free_end * std.mem.page_size)[0..std.mem.page_size]);
388
389 extended.bytes = @intToPtr([*]align(16) u8, free_end * std.mem.page_size)[0..std.mem.page_size];
390 // Since this is the first page being freed and we consume it, assume *nothing* is free.
391 std.mem.set(u8, extended.bytes, FreeBlock.used);
389392 }
390393 extended.recycle(free_start - extendedOffset(), free_end - free_start);
391394 }