authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2021-06-08 23:23:31+02:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2021-06-10 07:15:32+02:00
log88aec4a1ee49088685b16d744f35c902c4900a09
tree61bb6a72f801ff198b5dc5b7d3e3ec2d986660c1
parentb82d6422ac5c0a68b812319f689b66b52b0eaf59

zld: work out size and alignment of commons

1 files changed, 3 insertions(+), 4 deletions(-)

src/link/MachO/Object.zig+3-4
...@@ -383,11 +383,10 @@ pub fn parseSymbols(self: *Object) !void {...@@ -383,11 +383,10 @@ pub fn parseSymbols(self: *Object) !void {
383 }383 }
384384
385 if (sym.n_value != 0) {385 if (sym.n_value != 0) {
386 log.err("common symbol {s} in {s}", .{ sym_name, self.name.? });386 const comm_size = sym.n_value;
387 const comm_align = (sym.n_desc >> 8) & 0x0f;
388 log.err("Common symbol {s} in {s}: size 0x{x}, align 0x{x}", .{ sym_name, self.name.?, comm_size, comm_align });
387 return error.UnhandledSymbolType;389 return error.UnhandledSymbolType;
388 // const comm_size = sym.n_value;
389 // const comm_align = (sym.n_desc >> 8) & 0x0f;
390 // log.warn("Common symbol: size 0x{x}, align 0x{x}", .{ comm_size, comm_align });
391 }390 }
392391
393 const undef = try self.allocator.create(Symbol.Unresolved);392 const undef = try self.allocator.create(Symbol.Unresolved);