authorgravatar for git@vexu.euVeikka Tuominen <git@vexu.eu> 2022-02-22 15:04:12+02:00
committergravatar for git@vexu.euVeikka Tuominen <git@vexu.eu> 2022-02-23 10:40:40+02:00
log92beb2b490d7d86825d2e0eae3287c06477c9e81
treedb759eb5a68383b3ffd92a5e08acbe54d689416b
parent923b07bac797d66fe6d393cf823402c742250f48

stage2: misc fixes in Sema

5 files changed, 35 insertions(+), 21 deletions(-)

lib/std/math.zig+4-3
......@@ -947,7 +947,7 @@ fn testRem() !void {
947947/// Result is an unsigned integer.
948948pub fn absCast(x: anytype) switch (@typeInfo(@TypeOf(x))) {
949949 .ComptimeInt => comptime_int,
950 .Int => |intInfo| std.meta.Int(.unsigned, intInfo.bits),
950 .Int => |int_info| std.meta.Int(.unsigned, int_info.bits),
951951 else => @compileError("absCast only accepts integers"),
952952} {
953953 switch (@typeInfo(@TypeOf(x))) {
......@@ -958,8 +958,9 @@ pub fn absCast(x: anytype) switch (@typeInfo(@TypeOf(x))) {
958958 return x;
959959 }
960960 },
961 .Int => |intInfo| {
962 const Uint = std.meta.Int(.unsigned, intInfo.bits);
961 .Int => |int_info| {
962 if (int_info.signedness == .unsigned) return x;
963 const Uint = std.meta.Int(.unsigned, int_info.bits);
963964 if (x < 0) {
964965 return ~@bitCast(Uint, x +% -1);
965966 } else {
src/Sema.zig+14-7
......@@ -3351,9 +3351,10 @@ fn zirStoreNode(sema: *Sema, block: *Block, inst: Zir.Inst.Index) CompileError!v
33513351 // Check for the possibility of this pattern:
33523352 // %a = ret_ptr
33533353 // %b = store(%a, %c)
3354 // Where %c is an error union. In such case we need to add to the current function's
3355 // inferred error set, if any.
3356 if (sema.typeOf(operand).zigTypeTag() == .ErrorUnion and
3354 // Where %c is an error union or error set. In such case we need to add
3355 // to the current function's inferred error set, if any.
3356 if ((sema.typeOf(operand).zigTypeTag() == .ErrorUnion or
3357 sema.typeOf(operand).zigTypeTag() == .ErrorSet) and
33573358 sema.fn_ret_ty.zigTypeTag() == .ErrorUnion)
33583359 {
33593360 if (Zir.refToIndex(extra.lhs)) |ptr_index| {
......@@ -7665,6 +7666,8 @@ fn zirHasDecl(sema: *Sema, block: *Block, inst: Zir.Inst.Index) CompileError!Air
76657666 const container_type = try sema.resolveType(block, lhs_src, extra.lhs);
76667667 const decl_name = try sema.resolveConstString(block, rhs_src, extra.rhs);
76677668
7669 // tuples are structs but they don't have a namespace
7670 if (container_type.isTuple()) return Air.Inst.Ref.bool_false;
76687671 const namespace = container_type.getNamespace() orelse return sema.fail(
76697672 block,
76707673 lhs_src,
......@@ -12186,7 +12189,7 @@ fn checkPtrOperand(
1218612189 ty: Type,
1218712190) CompileError!void {
1218812191 switch (ty.zigTypeTag()) {
12189 .Pointer => {},
12192 .Pointer => return,
1219012193 .Fn => {
1219112194 const msg = msg: {
1219212195 const msg = try sema.errMsg(
......@@ -12203,8 +12206,10 @@ fn checkPtrOperand(
1220312206 };
1220412207 return sema.failWithOwnedErrorMsg(msg);
1220512208 },
12206 else => return sema.fail(block, ty_src, "expected pointer, found '{}'", .{ty}),
12209 .Optional => if (ty.isPtrLikeOptional()) return,
12210 else => {},
1220712211 }
12212 return sema.fail(block, ty_src, "expected pointer type, found '{}'", .{ty});
1220812213}
1220912214
1221012215fn checkPtrType(
......@@ -12214,7 +12219,7 @@ fn checkPtrType(
1221412219 ty: Type,
1221512220) CompileError!void {
1221612221 switch (ty.zigTypeTag()) {
12217 .Pointer => {},
12222 .Pointer => return,
1221812223 .Fn => {
1221912224 const msg = msg: {
1222012225 const msg = try sema.errMsg(
......@@ -12231,8 +12236,10 @@ fn checkPtrType(
1223112236 };
1223212237 return sema.failWithOwnedErrorMsg(msg);
1223312238 },
12234 else => return sema.fail(block, ty_src, "expected pointer type, found '{}'", .{ty}),
12239 .Optional => if (ty.isPtrLikeOptional()) return,
12240 else => {},
1223512241 }
12242 return sema.fail(block, ty_src, "expected pointer type, found '{}'", .{ty});
1223612243}
1223712244
1223812245fn checkVectorElemType(
src/type.zig+4-2
......@@ -593,10 +593,12 @@ pub const Type = extern union {
593593
594594 for (a_info.param_types) |a_param_ty, i| {
595595 const b_param_ty = b_info.param_types[i];
596 if (!eql(a_param_ty, b_param_ty))
596 if (a_info.comptime_params[i] != b_info.comptime_params[i])
597597 return false;
598598
599 if (a_info.comptime_params[i] != b_info.comptime_params[i])
599 if (a_param_ty.tag() == .generic_poison) continue;
600 if (b_param_ty.tag() == .generic_poison) continue;
601 if (!eql(a_param_ty, b_param_ty))
600602 return false;
601603 }
602604
test/behavior.zig+9-9
......@@ -120,6 +120,15 @@ test {
120120 _ = @import("behavior/sizeof_and_typeof.zig");
121121 _ = @import("behavior/switch.zig");
122122 _ = @import("behavior/widening.zig");
123 _ = @import("behavior/bugs/421.zig");
124 _ = @import("behavior/bugs/726.zig");
125 _ = @import("behavior/bugs/1421.zig");
126 _ = @import("behavior/bugs/2114.zig");
127 _ = @import("behavior/bugs/3742.zig");
128 _ = @import("behavior/struct_contains_null_ptr_itself.zig");
129 _ = @import("behavior/switch_prong_err_enum.zig");
130 _ = @import("behavior/switch_prong_implicit_cast.zig");
131 _ = @import("behavior/union_with_members.zig");
123132
124133 if (builtin.zig_backend == .stage1) {
125134 // Tests that only pass for the stage1 backend.
......@@ -128,20 +137,15 @@ test {
128137 _ = @import("behavior/async_fn.zig");
129138 }
130139 _ = @import("behavior/await_struct.zig");
131 _ = @import("behavior/bugs/421.zig");
132140 _ = @import("behavior/bugs/529.zig");
133141 _ = @import("behavior/bugs/718.zig");
134 _ = @import("behavior/bugs/726.zig");
135142 _ = @import("behavior/bugs/828.zig");
136143 _ = @import("behavior/bugs/920.zig");
137144 _ = @import("behavior/bugs/1120.zig");
138 _ = @import("behavior/bugs/1421.zig");
139145 _ = @import("behavior/bugs/1442.zig");
140146 _ = @import("behavior/bugs/1607.zig");
141147 _ = @import("behavior/bugs/1851.zig");
142 _ = @import("behavior/bugs/2114.zig");
143148 _ = @import("behavior/bugs/3384.zig");
144 _ = @import("behavior/bugs/3742.zig");
145149 _ = @import("behavior/bugs/3779.zig");
146150 _ = @import("behavior/bugs/4328.zig");
147151 _ = @import("behavior/bugs/5398.zig");
......@@ -161,12 +165,8 @@ test {
161165 _ = @import("behavior/muladd.zig");
162166 _ = @import("behavior/select.zig");
163167 _ = @import("behavior/shuffle.zig");
164 _ = @import("behavior/struct_contains_null_ptr_itself.zig");
165168 _ = @import("behavior/struct_contains_slice_of_itself.zig");
166 _ = @import("behavior/switch_prong_err_enum.zig");
167 _ = @import("behavior/switch_prong_implicit_cast.zig");
168169 _ = @import("behavior/typename.zig");
169 _ = @import("behavior/union_with_members.zig");
170170 _ = @import("behavior/vector.zig");
171171 if (builtin.target.cpu.arch == .wasm32) {
172172 _ = @import("behavior/wasm.zig");
test/behavior/type_info.zig+4
......@@ -323,6 +323,10 @@ fn testOpaque() !void {
323323}
324324
325325test "type info: function type info" {
326 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
327 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
328 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest;
329
326330 // wasm doesn't support align attributes on functions
327331 if (builtin.target.cpu.arch == .wasm32 or builtin.target.cpu.arch == .wasm64) return error.SkipZigTest;
328332 try testFunction();