authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2018-05-17 00:15:52-04:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2018-05-17 00:16:32-04:00
log9ea0e4ca6803cd10cfbffbdf80033a90f0e544d5
treef3e6721feabebe987fc667a4e998a0e0405b899e
parent967bad43a053bf7d9d54dd352fcd8416c767785e

zig fmt: same line comments after tokens in expression

2 files changed, 67 insertions(+), 17 deletions(-)

std/zig/parser_test.zig+43
......@@ -1,3 +1,46 @@
1test "zig fmt: same line comments in expression" {
2 try testCanonical(
3 \\test "aoeu" {
4 \\ const x = ( // a
5 \\ 0 // b
6 \\ ); // c
7 \\}
8 \\
9 );
10}
11
12//test "zig fmt: line comment between if block and else keyword" {
13// try testTransform(
14// test "aoeu" {
15// // cexp(finite|nan +- i inf|nan) = nan + i nan
16// if ((hx & 0x7fffffff) != 0x7f800000) {
17// return Complex(f32).new(y - y, y - y);
18// }
19// // cexp(-inf +- i inf|nan) = 0 + i0
20// else if (hx & 0x80000000 != 0) {
21// return Complex(f32).new(0, 0);
22// }
23// // cexp(+inf +- i inf|nan) = inf + i nan
24// else {
25// return Complex(f32).new(x, y - y);
26// }
27// }
28// ,
29// test "aoeu" {
30// // cexp(finite|nan +- i inf|nan) = nan + i nan
31// if ((hx & 0x7fffffff) != 0x7f800000) {
32// return Complex(f32).new(y - y, y - y);
33// } // cexp(-inf +- i inf|nan) = 0 + i0
34// else if (hx & 0x80000000 != 0) {
35// return Complex(f32).new(0, 0);
36// } // cexp(+inf +- i inf|nan) = inf + i nan
37// else {
38// return Complex(f32).new(x, y - y);
39// }
40// }
41// );
42//}
43
144test "zig fmt: add comma on last switch prong" {
245 try testTransform(
346 \\test "aoeu" {
std/zig/render.zig+24-17
......@@ -81,7 +81,7 @@ fn renderTopLevelDecl(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, i
8181 }
8282 try stream.print("{}: ", tree.tokenSlice(field.name_token));
8383 try renderExpression(allocator, stream, tree, indent, field.type_expr);
84 try renderToken(tree, stream, field.lastToken() + 1, indent, true);
84 try renderToken(tree, stream, field.lastToken() + 1, indent, true, true);
8585 },
8686 ast.Node.Id.UnionTag => {
8787 const tag = @fieldParentPtr(ast.Node.UnionTag, "base", decl);
......@@ -513,9 +513,9 @@ fn renderExpression(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, ind
513513 ast.Node.Id.GroupedExpression => {
514514 const grouped_expr = @fieldParentPtr(ast.Node.GroupedExpression, "base", base);
515515
516 try stream.write("(");
516 try renderToken(tree, stream, grouped_expr.lparen, indent, false, false);
517517 try renderExpression(allocator, stream, tree, indent, grouped_expr.expr);
518 try stream.write(")");
518 try renderToken(tree, stream, grouped_expr.rparen, indent, false, false);
519519 },
520520
521521 ast.Node.Id.FieldInitializer => {
......@@ -527,7 +527,7 @@ fn renderExpression(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, ind
527527
528528 ast.Node.Id.IntegerLiteral => {
529529 const integer_literal = @fieldParentPtr(ast.Node.IntegerLiteral, "base", base);
530 try stream.print("{}", tree.tokenSlice(integer_literal.token));
530 try renderToken(tree, stream, integer_literal.token, indent, false, false);
531531 },
532532 ast.Node.Id.FloatLiteral => {
533533 const float_literal = @fieldParentPtr(ast.Node.FloatLiteral, "base", base);
......@@ -535,7 +535,7 @@ fn renderExpression(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, ind
535535 },
536536 ast.Node.Id.StringLiteral => {
537537 const string_literal = @fieldParentPtr(ast.Node.StringLiteral, "base", base);
538 try stream.print("{}", tree.tokenSlice(string_literal.token));
538 try renderToken(tree, stream, string_literal.token, indent, false, false);
539539 },
540540 ast.Node.Id.CharLiteral => {
541541 const char_literal = @fieldParentPtr(ast.Node.CharLiteral, "base", base);
......@@ -840,9 +840,9 @@ fn renderExpression(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, ind
840840 },
841841 Token.Id.LineComment => {
842842 try stream.write(", ");
843 try renderToken(tree, stream, index, indent, true);
843 try renderToken(tree, stream, index, indent, true, true);
844844 },
845 else => try renderToken(tree, stream, index, indent, true),
845 else => try renderToken(tree, stream, index, indent, true, true),
846846 }
847847 }
848848 },
......@@ -971,7 +971,7 @@ fn renderExpression(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, ind
971971 try stream.print("{} (", tree.tokenSlice(if_node.if_token));
972972
973973 try renderExpression(allocator, stream, tree, indent, if_node.condition);
974 try renderToken(tree, stream, if_node.condition.lastToken() + 1, indent, false);
974 try renderToken(tree, stream, if_node.condition.lastToken() + 1, indent, false, true);
975975
976976 if (if_node.payload) |payload| {
977977 try renderExpression(allocator, stream, tree, indent, payload);
......@@ -1126,11 +1126,11 @@ fn renderExpression(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, ind
11261126
11271127fn renderVarDecl(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, indent: usize, var_decl: &ast.Node.VarDecl) (@typeOf(stream).Child.Error || Error)!void {
11281128 if (var_decl.visib_token) |visib_token| {
1129 try stream.print("{} ", tree.tokenSlice(visib_token));
1129 try renderToken(tree, stream, visib_token, indent, false, true);
11301130 }
11311131
11321132 if (var_decl.extern_export_token) |extern_export_token| {
1133 try stream.print("{} ", tree.tokenSlice(extern_export_token));
1133 try renderToken(tree, stream, extern_export_token, indent, false, true);
11341134
11351135 if (var_decl.lib_name) |lib_name| {
11361136 try renderExpression(allocator, stream, tree, indent, lib_name);
......@@ -1139,10 +1139,11 @@ fn renderVarDecl(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, indent
11391139 }
11401140
11411141 if (var_decl.comptime_token) |comptime_token| {
1142 try stream.print("{} ", tree.tokenSlice(comptime_token));
1142 try renderToken(tree, stream, comptime_token, indent, false, true);
11431143 }
11441144
1145 try stream.print("{} {}", tree.tokenSlice(var_decl.mut_token), tree.tokenSlice(var_decl.name_token));
1145 try renderToken(tree, stream, var_decl.mut_token, indent, false, true);
1146 try renderToken(tree, stream, var_decl.name_token, indent, false, false);
11461147
11471148 if (var_decl.type_node) |type_node| {
11481149 try stream.write(": ");
......@@ -1161,14 +1162,14 @@ fn renderVarDecl(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, indent
11611162 try renderExpression(allocator, stream, tree, indent, init_node);
11621163 }
11631164
1164 try renderToken(tree, stream, var_decl.semicolon_token, indent, true);
1165 try renderToken(tree, stream, var_decl.semicolon_token, indent, true, false);
11651166}
11661167
11671168fn maybeRenderSemicolon(stream: var, tree: &ast.Tree, indent: usize, base: &ast.Node) (@typeOf(stream).Child.Error || Error)!void {
11681169 if (base.requireSemiColon()) {
11691170 const semicolon_index = base.lastToken() + 1;
11701171 assert(tree.tokens.at(semicolon_index).id == Token.Id.Semicolon);
1171 try renderToken(tree, stream, semicolon_index, indent, true);
1172 try renderToken(tree, stream, semicolon_index, indent, true, true);
11721173 }
11731174}
11741175
......@@ -1203,7 +1204,7 @@ fn renderStatement(allocator: &mem.Allocator, stream: var, tree: &ast.Tree, inde
12031204 }
12041205}
12051206
1206fn renderToken(tree: &ast.Tree, stream: var, token_index: ast.TokenIndex, indent: usize, line_break: bool) (@typeOf(stream).Child.Error || Error)!void {
1207fn renderToken(tree: &ast.Tree, stream: var, token_index: ast.TokenIndex, indent: usize, line_break: bool, space: bool) (@typeOf(stream).Child.Error || Error)!void {
12071208 const token = tree.tokens.at(token_index);
12081209 try stream.write(tree.tokenSlicePtr(token));
12091210
......@@ -1214,13 +1215,19 @@ fn renderToken(tree: &ast.Tree, stream: var, token_index: ast.TokenIndex, indent
12141215 try stream.print(" {}", tree.tokenSlicePtr(next_token));
12151216 if (!line_break) {
12161217 try stream.write("\n");
1217 try stream.writeByteNTimes(' ', indent + indent_delta);
1218
1219 const after_comment_token = tree.tokens.at(token_index + 2);
1220 const next_line_indent = switch (after_comment_token.id) {
1221 Token.Id.RParen, Token.Id.RBrace, Token.Id.RBracket => indent,
1222 else => indent + indent_delta,
1223 };
1224 try stream.writeByteNTimes(' ', next_line_indent);
12181225 return;
12191226 }
12201227 }
12211228 }
12221229
1223 if (!line_break) {
1230 if (!line_break and space) {
12241231 try stream.writeByte(' ');
12251232 }
12261233}