Fix typo in Pcg.zig's fill function
When filling the last (len % 4) bytes of a buffer, the random number n was only being shifted right by 4 bits for each byte instead of 8. A random u16, for example, would always have its middle two nybbles be equal when generated this way. For comparison, Isaac64.zig, Sfc64.zig, and Xoroshiro128.zig all correctly shift right by 8 bits for each of the last bytes in their nearly identical fill functions.
1 files changed, 1 insertions(+), 1 deletions(-)
lib/std/rand/Pcg.zig+1-1
| ... | ... | @@ -75,7 +75,7 @@ fn fill(r: *Random, buf: []u8) void { |
| 75 | 75 | var n = self.next(); |
| 76 | 76 | while (i < buf.len) : (i += 1) { |
| 77 | 77 | buf[i] = @truncate(u8, n); |
| 78 | | n >>= 4; |
| 78 | n >>= 8; |
| 79 | 79 | } |
| 80 | 80 | } |
| 81 | 81 | } |
Matthew Borkowski <matthew.h.borkowski@gmail.com> 2021-03-28 09:49:10-04:00
Isaac Freund <mail@isaacfreund.com> 2021-03-29 09:22:06+02:00
lib