authorgravatar for contact@fengb.meBenjamin Feng <contact@fengb.me> 2019-12-04 18:12:25-06:00
committergravatar for contact@fengb.meBenjamin Feng <contact@fengb.me> 2019-12-04 18:12:25-06:00
loga910a6c871d1840c900287d68f0d5c9f8888247d
tree83b32eeabf4a5a357f25fc3bec3ddcfba0b752e7
parenta6f838aab2678be491a774316c02a339487fe34d

Rejuggle how offsets are calculated


1 files changed, 37 insertions(+), 22 deletions(-)

lib/std/heap.zig+37-22
......@@ -257,7 +257,6 @@ const WasmPageAllocator = struct {
257257 var heap_base_wannabe: [256]u8 align(16) = undefined;
258258
259259 const FreeBlock = struct {
260 offset: usize = 0,
261260 packed_data: std.PackedIntSlice(u1) = std.PackedIntSlice(u1).init(&[_]u8{}, 0),
262261 block_data: []u128 = &[_]u128{},
263262
......@@ -275,11 +274,20 @@ const WasmPageAllocator = struct {
275274 fn setBits(self: *FreeBlock, start_idx: usize, len: usize, val: u1) void {
276275 var i: usize = 0;
277276 while (i < len) : (i += 1) {
278 self.packed_data.set(i + start_idx + self.offset, val);
277 self.packed_data.set(i + start_idx, val);
279278 }
280279 }
281280
282 fn useRecycled(self: *FreeBlock, num_pages: usize) ?[*]u8 {
281 // Use '0xFFFFFFFF' as a _missing_ sentinel
282 // This saves ~50 bytes compared to returning a nullable
283
284 // We can guarantee that conventional memory never gets this big,
285 // and wasm32 would not be able to address this block (32 GB > usize).
286
287 // Revisit if this is settled: https://github.com/ziglang/zig/issues/3806
288 const not_found = std.math.maxInt(usize);
289
290 fn useRecycled(self: *FreeBlock, num_pages: usize) usize {
283291 @setCold(true);
284292 for (self.block_data) |segment, i| {
285293 const spills_into_next = @bitCast(i128, segment) < 0;
......@@ -294,13 +302,13 @@ const WasmPageAllocator = struct {
294302 count += 1;
295303 if (count >= num_pages) {
296304 self.setBits(j, num_pages, 0);
297 return @intToPtr([*]u8, (j + self.offset) * std.mem.page_size);
305 return j;
298306 }
299307 }
300308 j += count;
301309 }
302310 }
303 return null;
311 return not_found;
304312 }
305313
306314 fn recycle(self: *FreeBlock, start_idx: usize, len: usize) void {
......@@ -311,22 +319,31 @@ const WasmPageAllocator = struct {
311319 var conventional = FreeBlock{};
312320 var extended = FreeBlock{};
313321
322 fn extendedOffset() usize {
323 return conventional.totalPages();
324 }
325
314326 fn nPages(memsize: usize) usize {
315327 return std.mem.alignForward(memsize, std.mem.page_size) / std.mem.page_size;
316328 }
317329
318 fn alloc(allocator: *Allocator, n: usize, alignment: u29) error{OutOfMemory}![]u8 {
319 const n_pages = nPages(n);
320 const page = conventional.useRecycled(n_pages) orelse extended.useRecycled(n_pages) orelse blk: {
321 const prev_page_count = @"llvm.wasm.memory.grow.i32"(0, @intCast(u32, n_pages));
322 if (prev_page_count < 0) {
323 return error.OutOfMemory;
324 }
330 fn alloc(allocator: *Allocator, page_count: usize, alignment: u29) error{OutOfMemory}!usize {
331 var idx = conventional.useRecycled(page_count);
332 if (idx != FreeBlock.not_found) {
333 return idx;
334 }
325335
326 break :blk @intToPtr([*]u8, @intCast(usize, prev_page_count) * std.mem.page_size);
327 };
336 idx = extended.useRecycled(page_count);
337 if (idx != FreeBlock.not_found) {
338 return idx + extendedOffset();
339 }
328340
329 return page[0..n];
341 const prev_page_count = @"llvm.wasm.memory.grow.i32"(0, @intCast(u32, page_count));
342 if (prev_page_count <= 0) {
343 return error.OutOfMemory;
344 }
345
346 return @intCast(usize, prev_page_count);
330347 }
331348
332349 pub fn realloc(allocator: *Allocator, old_mem: []u8, old_align: u29, new_size: usize, new_align: u29) Allocator.Error![]u8 {
......@@ -339,10 +356,11 @@ const WasmPageAllocator = struct {
339356 } else if (new_size < old_mem.len) {
340357 return shrink(allocator, old_mem, old_align, new_size, new_align);
341358 } else {
342 const new_mem = try alloc(allocator, new_size, new_align);
359 const page_idx = try alloc(allocator, nPages(new_size), new_align);
360 const new_mem = @intToPtr([*]u8, page_idx * std.mem.page_size)[0..new_size];
343361 std.mem.copy(u8, new_mem, old_mem);
344362 _ = shrink(allocator, old_mem, old_align, 0, 0);
345 return new_mem[0..new_size];
363 return new_mem;
346364 }
347365 }
348366
......@@ -352,22 +370,19 @@ const WasmPageAllocator = struct {
352370
353371 if (free_end > free_start) {
354372 if (conventional.totalPages() == 0) {
355 conventional.offset = 0;
356373 //conventional.initData(__heap_base[0..@intCast(usize, @"llvm.wasm.memory.size.i32"(0) * std.mem.page_size)]);
357374 conventional.initData(heap_base_wannabe[0..]);
358375 }
359376
360 if (free_start < conventional.totalPages()) {
377 if (free_start < extendedOffset()) {
361378 conventional.recycle(free_start, free_end - free_start);
362379 } else {
363380 if (extended.totalPages() == 0) {
364 extended.offset = conventional.offset + conventional.totalPages();
365
366381 // Steal the last page from the memory currently being recycled
367382 free_end -= 1;
368383 extended.initData(@intToPtr([*]align(16) u8, free_end * std.mem.page_size)[0..std.mem.page_size]);
369384 }
370 extended.recycle(free_start, free_end - free_start);
385 extended.recycle(free_start - extendedOffset(), free_end - free_start);
371386 }
372387 }
373388