Commit b1f3f59d660bbe163502daa6f0acd560782f49d8 | zig

author	LemonBoy <thatlemon@gmail.com> 2019-10-13 12:13:41+02:00
committer	LemonBoy <thatlemon@gmail.com> 2019-10-13 12:13:41+02:00
log	b1f3f59d660bbe163502daa6f0acd560782f49d8
tree	67148819b3445ecfc9dbaf3d87229bfcea8abe39
parent	ba711f1115b76d85b13fc64636c4a4af8405cc1e

Fix fp-based backtracing on RISC-V

The fp points to the top of the frame instead of pointing to the old fp,
compensate this difference with an offset.

1 files changed, 15 insertions(+), 6 deletions(-)

lib
- std
  - debug.zig

lib/std/debug.zig+15-6

 @@ -280,14 +280,23 @@ pub const StackIterator = struct {
         };
     }
+    // On some architectures such as x86 the frame pointer is the address where
+    // the previous fp is stored, while on some other architectures such as
+    // RISC-V it points to the "top" of the frame, just above where the previous
+    // fp and the return address are stored.
+    const fp_adjust_factor = if (builtin.arch == .riscv32 or builtin.arch == .riscv64)
+        2 * @sizeOf(usize)
+    else
+        0;
     fn next(self: *StackIterator) ?usize {
-        if (self.fp == 0) return null;
+        if (self.fp < fp_adjust_factor) return null;
-        self.fp = @intToPtr(*const usize, self.fp).*;
+        self.fp = @intToPtr(*const usize, self.fp - fp_adjust_factor).*;
-        if (self.fp == 0) return null;
+        if (self.fp < fp_adjust_factor) return null;
         if (self.first_addr) |addr| {
-            while (self.fp != 0) : (self.fp = @intToPtr(*const usize, self.fp).*) {
+            while (self.fp >= fp_adjust_factor) : (self.fp = @intToPtr(*const usize, self.fp - fp_adjust_factor).*) {
-                const return_address = @intToPtr(*const usize, self.fp + @sizeOf(usize)).*;
+                const return_address = @intToPtr(*const usize, self.fp - fp_adjust_factor + @sizeOf(usize)).*;
                 if (addr == return_address) {
                     self.first_addr = null;
                     return return_address;
 @@ -295,7 +304,7 @@ pub const StackIterator = struct {
             }
         }
-        const return_address = @intToPtr(*const usize, self.fp + @sizeOf(usize)).*;
+        const return_address = @intToPtr(*const usize, self.fp - fp_adjust_factor + @sizeOf(usize)).*;
         return return_address;
     }
 };