authorgravatar for stephen@hexops.comStephen Gutekanst <stephen@hexops.com> 2022-02-21 14:18:15-07:00
committergravatar for stephen@hexops.comStephen Gutekanst <stephen@hexops.com> 2022-02-21 14:20:38-07:00
logb341967da0fc0fe5dfc8fa914006fd6a7624297f
tree622c3b71c2950b05d8d1799c1a51cfa856c4732f
parentefd473bbfc1417c5cc376f1b8ec44036752570bf

zig build: use a custom iterator for merging args and response file

Signed-off-by: Stephen Gutekanst <stephen@hexops.com>

1 files changed, 54 insertions(+), 54 deletions(-)

src/main.zig+54-54
......@@ -765,30 +765,30 @@ fn buildOutputType(
765765 }
766766
767767 soname = .yes_default_value;
768 var process_args_iter = try process.argsWithAllocator(arena);
769 _ = process_args_iter.skip(); // "zig"
770 _ = process_args_iter.skip(); // e.g. "build-lib"
771 var resp_file_args_iter: ?ArgIteratorResponseFile = null;
772
773 const getNextArg = (struct {
774 pub fn getNextArg(_process_args_iter: *process.ArgIterator, maybe_resp_file_args_iter: *?ArgIteratorResponseFile) ?[:0]const u8 {
775 if (_process_args_iter.next()) |proc_arg| return proc_arg;
776 if (maybe_resp_file_args_iter.*) |*iter| return iter.next();
777 return null;
778 }
779 }).getNextArg;
780768
781 args_loop: while (getNextArg(&process_args_iter, &resp_file_args_iter)) |arg| {
782 var args_index = process_args_iter.inner.index;
783 if (resp_file_args_iter) |iter| {
784 args_index = iter.index;
769 const Iterator = struct {
770 resp_file: ?ArgIteratorResponseFile = null,
771 args: []const []const u8,
772 i: usize = 0,
773 fn next(it: *@This()) ?[]const u8 {
774 if (it.i >= it.args.len) {
775 if (it.resp_file) |*resp| return if (resp.next()) |sentinel| std.mem.span(sentinel) else null;
776 return null;
777 }
778 defer it.i += 1;
779 return it.args[it.i];
785780 }
781 };
782 var args_iter = Iterator{
783 .args = all_args[2..],
784 };
786785
786 args_loop: while (args_iter.next()) |arg| {
787787 if (mem.startsWith(u8, arg, "@")) {
788788 // This is a "compiler response file". We must parse the file and treat its
789789 // contents as command line parameters.
790790 const resp_file_path = arg[1..];
791 resp_file_args_iter = initArgIteratorResponseFile(arena, resp_file_path) catch |err| {
791 args_iter.resp_file = initArgIteratorResponseFile(arena, resp_file_path) catch |err| {
792792 fatal("unable to read response file '{s}': {s}", .{ resp_file_path, @errorName(err) });
793793 };
794794 } else if (mem.startsWith(u8, arg, "-")) {
......@@ -799,14 +799,14 @@ fn buildOutputType(
799799 if (arg_mode == .run) {
800800 // The index refers to all_args so skip `zig` `run`
801801 // and `--`
802 runtime_args_start = args_index + 3;
802 runtime_args_start = args_iter.i + 3;
803803 break :args_loop;
804804 } else {
805805 fatal("unexpected end-of-parameter mark: --", .{});
806806 }
807807 } else if (mem.eql(u8, arg, "--pkg-begin")) {
808 const pkg_name = getNextArg(&process_args_iter, &resp_file_args_iter);
809 const pkg_path = getNextArg(&process_args_iter, &resp_file_args_iter);
808 const pkg_name = args_iter.next();
809 const pkg_path = args_iter.next();
810810 if (pkg_name == null or pkg_path == null) fatal("Expected 2 arguments after {s}", .{arg});
811811
812812 const new_cur_pkg = Package.create(
......@@ -822,28 +822,28 @@ fn buildOutputType(
822822 cur_pkg = cur_pkg.parent orelse
823823 fatal("encountered --pkg-end with no matching --pkg-begin", .{});
824824 } else if (mem.eql(u8, arg, "--main-pkg-path")) {
825 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
825 const next_arg = args_iter.next() orelse {
826826 fatal("expected parameter after {s}", .{arg});
827827 };
828828 main_pkg_path = next_arg;
829829 } else if (mem.eql(u8, arg, "-cflags")) {
830830 extra_cflags.shrinkRetainingCapacity(0);
831831 while (true) {
832 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
832 const next_arg = args_iter.next() orelse {
833833 fatal("expected -- after -cflags", .{});
834834 };
835835 if (mem.eql(u8, next_arg, "--")) break;
836836 try extra_cflags.append(next_arg);
837837 }
838838 } else if (mem.eql(u8, arg, "--color")) {
839 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
839 const next_arg = args_iter.next() orelse {
840840 fatal("expected [auto|on|off] after --color", .{});
841841 };
842842 color = std.meta.stringToEnum(Color, next_arg) orelse {
843843 fatal("expected [auto|on|off] after --color, found '{s}'", .{next_arg});
844844 };
845845 } else if (mem.eql(u8, arg, "--subsystem")) {
846 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
846 const next_arg = args_iter.next() orelse {
847847 fatal("expected parameter after {s}", .{arg});
848848 };
849849 if (mem.eql(u8, next_arg, "console")) {
......@@ -877,78 +877,78 @@ fn buildOutputType(
877877 });
878878 }
879879 } else if (mem.eql(u8, arg, "-O")) {
880 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
880 const next_arg = args_iter.next() orelse {
881881 fatal("expected parameter after {s}", .{arg});
882882 };
883883 optimize_mode_string = next_arg;
884884 } else if (mem.eql(u8, arg, "--entry")) {
885 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
885 const next_arg = args_iter.next() orelse {
886886 fatal("expected parameter after {s}", .{arg});
887887 };
888888 entry = next_arg;
889889 } else if (mem.eql(u8, arg, "--stack")) {
890 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
890 const next_arg = args_iter.next() orelse {
891891 fatal("expected parameter after {s}", .{arg});
892892 };
893893 stack_size_override = std.fmt.parseUnsigned(u64, next_arg, 0) catch |err| {
894894 fatal("unable to parse '{s}': {s}", .{ arg, @errorName(err) });
895895 };
896896 } else if (mem.eql(u8, arg, "--image-base")) {
897 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
897 const next_arg = args_iter.next() orelse {
898898 fatal("expected parameter after {s}", .{arg});
899899 };
900900 image_base_override = std.fmt.parseUnsigned(u64, next_arg, 0) catch |err| {
901901 fatal("unable to parse '{s}': {s}", .{ arg, @errorName(err) });
902902 };
903903 } else if (mem.eql(u8, arg, "--name")) {
904 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
904 const next_arg = args_iter.next() orelse {
905905 fatal("expected parameter after {s}", .{arg});
906906 };
907907 provided_name = next_arg;
908908 } else if (mem.eql(u8, arg, "-rpath")) {
909 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
909 const next_arg = args_iter.next() orelse {
910910 fatal("expected parameter after {s}", .{arg});
911911 };
912912 try rpath_list.append(next_arg);
913913 } else if (mem.eql(u8, arg, "--library-directory") or mem.eql(u8, arg, "-L")) {
914 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
914 const next_arg = args_iter.next() orelse {
915915 fatal("expected parameter after {s}", .{arg});
916916 };
917917 try lib_dirs.append(next_arg);
918918 } else if (mem.eql(u8, arg, "-F")) {
919 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
919 const next_arg = args_iter.next() orelse {
920920 fatal("expected parameter after {s}", .{arg});
921921 };
922922 try framework_dirs.append(next_arg);
923923 } else if (mem.eql(u8, arg, "-framework")) {
924 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
924 const next_arg = args_iter.next() orelse {
925925 fatal("expected parameter after {s}", .{arg});
926926 };
927927 try frameworks.append(next_arg);
928928 } else if (mem.eql(u8, arg, "-install_name")) {
929 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
929 const next_arg = args_iter.next() orelse {
930930 fatal("expected parameter after {s}", .{arg});
931931 };
932932 install_name = next_arg;
933933 } else if (mem.eql(u8, arg, "-T") or mem.eql(u8, arg, "--script")) {
934 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
934 const next_arg = args_iter.next() orelse {
935935 fatal("expected parameter after {s}", .{arg});
936936 };
937937 linker_script = next_arg;
938938 } else if (mem.eql(u8, arg, "--version-script")) {
939 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
939 const next_arg = args_iter.next() orelse {
940940 fatal("expected parameter after {s}", .{arg});
941941 };
942942 version_script = next_arg;
943943 } else if (mem.eql(u8, arg, "--library") or mem.eql(u8, arg, "-l")) {
944 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
944 const next_arg = args_iter.next() orelse {
945945 fatal("expected parameter after {s}", .{arg});
946946 };
947947 // We don't know whether this library is part of libc or libc++ until
948948 // we resolve the target, so we simply append to the list for now.
949949 try system_libs.put(next_arg, .{ .needed = false });
950950 } else if (mem.eql(u8, arg, "--needed-library") or mem.eql(u8, arg, "-needed-l")) {
951 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
951 const next_arg = args_iter.next() orelse {
952952 fatal("expected parameter after {s}", .{arg});
953953 };
954954 try system_libs.put(next_arg, .{ .needed = true });
......@@ -960,13 +960,13 @@ fn buildOutputType(
960960 mem.eql(u8, arg, "-iframework") or
961961 mem.eql(u8, arg, "-iframeworkwithsysroot"))
962962 {
963 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
963 const next_arg = args_iter.next() orelse {
964964 fatal("expected parameter after {s}", .{arg});
965965 };
966966 try clang_argv.append(arg);
967967 try clang_argv.append(next_arg);
968968 } else if (mem.eql(u8, arg, "--version")) {
969 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
969 const next_arg = args_iter.next() orelse {
970970 fatal("expected parameter after {s}", .{arg});
971971 };
972972 version = std.builtin.Version.parse(next_arg) catch |err| {
......@@ -974,17 +974,17 @@ fn buildOutputType(
974974 };
975975 have_version = true;
976976 } else if (mem.eql(u8, arg, "-target")) {
977 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
977 const next_arg = args_iter.next() orelse {
978978 fatal("expected parameter after {s}", .{arg});
979979 };
980980 target_arch_os_abi = next_arg;
981981 } else if (mem.eql(u8, arg, "-mcpu")) {
982 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
982 const next_arg = args_iter.next() orelse {
983983 fatal("expected parameter after {s}", .{arg});
984984 };
985985 target_mcpu = next_arg;
986986 } else if (mem.eql(u8, arg, "-mcmodel")) {
987 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
987 const next_arg = args_iter.next() orelse {
988988 fatal("expected parameter after {s}", .{arg});
989989 };
990990 machine_code_model = parseCodeModel(next_arg);
......@@ -997,54 +997,54 @@ fn buildOutputType(
997997 } else if (mem.startsWith(u8, arg, "-O")) {
998998 optimize_mode_string = arg["-O".len..];
999999 } else if (mem.eql(u8, arg, "--dynamic-linker")) {
1000 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1000 const next_arg = args_iter.next() orelse {
10011001 fatal("expected parameter after {s}", .{arg});
10021002 };
10031003 target_dynamic_linker = next_arg;
10041004 } else if (mem.eql(u8, arg, "--sysroot")) {
1005 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1005 const next_arg = args_iter.next() orelse {
10061006 fatal("expected parameter after {s}", .{arg});
10071007 };
10081008 sysroot = next_arg;
10091009 try clang_argv.append("-isysroot");
10101010 try clang_argv.append(next_arg);
10111011 } else if (mem.eql(u8, arg, "--libc")) {
1012 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1012 const next_arg = args_iter.next() orelse {
10131013 fatal("expected parameter after {s}", .{arg});
10141014 };
10151015 libc_paths_file = next_arg;
10161016 } else if (mem.eql(u8, arg, "--test-filter")) {
1017 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1017 const next_arg = args_iter.next() orelse {
10181018 fatal("expected parameter after {s}", .{arg});
10191019 };
10201020 test_filter = next_arg;
10211021 } else if (mem.eql(u8, arg, "--test-name-prefix")) {
1022 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1022 const next_arg = args_iter.next() orelse {
10231023 fatal("expected parameter after {s}", .{arg});
10241024 };
10251025 test_name_prefix = next_arg;
10261026 } else if (mem.eql(u8, arg, "--test-cmd")) {
1027 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1027 const next_arg = args_iter.next() orelse {
10281028 fatal("expected parameter after {s}", .{arg});
10291029 };
10301030 try test_exec_args.append(next_arg);
10311031 } else if (mem.eql(u8, arg, "--cache-dir")) {
1032 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1032 const next_arg = args_iter.next() orelse {
10331033 fatal("expected parameter after {s}", .{arg});
10341034 };
10351035 override_local_cache_dir = next_arg;
10361036 } else if (mem.eql(u8, arg, "--global-cache-dir")) {
1037 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1037 const next_arg = args_iter.next() orelse {
10381038 fatal("expected parameter after {s}", .{arg});
10391039 };
10401040 override_global_cache_dir = next_arg;
10411041 } else if (mem.eql(u8, arg, "--zig-lib-dir")) {
1042 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1042 const next_arg = args_iter.next() orelse {
10431043 fatal("expected parameter after {s}", .{arg});
10441044 };
10451045 override_lib_dir = next_arg;
10461046 } else if (mem.eql(u8, arg, "--debug-log")) {
1047 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1047 const next_arg = args_iter.next() orelse {
10481048 fatal("expected parameter after {s}", .{arg});
10491049 };
10501050 if (!build_options.enable_logging) {
......@@ -1223,7 +1223,7 @@ fn buildOutputType(
12231223 } else if (mem.eql(u8, arg, "-fno-allow-shlib-undefined")) {
12241224 linker_allow_shlib_undefined = false;
12251225 } else if (mem.eql(u8, arg, "-z")) {
1226 const next_arg = getNextArg(&process_args_iter, &resp_file_args_iter) orelse {
1226 const next_arg = args_iter.next() orelse {
12271227 fatal("expected parameter after {s}", .{arg});
12281228 };
12291229 const z_arg = next_arg;