Commit b423f7b7b6da6f88301b14eaed5f9f8a4924847c | zig

author	Frank Denis <124872+jedisct1@users.noreply.github.com> 2026-10-04 17:09:47+02:00
committer	Frank Denis <124872+jedisct1@users.noreply.github.com> 2026-10-16 08:22:49+02:00
log	b423f7b7b6da6f88301b14eaed5f9f8a4924847c
tree	187d95955a0f33c6c0c87ed40acb96b05ac8baf0
parent	bd51e91a9a934c915219b985549bb4fc060c0357

std.base64: fix bogus decoderWithIgnore() definitions

standard_no_pad.decoderWithIgnore() constructed a decoder with
padding enabled, so it would accept padded base64 even when the
decoder was explicitly configured to reject padding.

And url_safe.decoderWithIgnore() constructed a decoder without
padding, so it would accept unpadded URL-safe Base64 even when
we require padding.

1 files changed, 8 insertions(+), 2 deletions(-)

lib
- std
  - base64.zig

lib/std/base64.zig+8-2

...	...	@@ -31,6 +31,9 @@ pub const standard_alphabet_chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopq
31	31	fn standardBase64DecoderWithIgnore(ignore: []const u8) Base64DecoderWithIgnore {
32	32	return Base64DecoderWithIgnore.init(standard_alphabet_chars, '=', ignore);
33	33	}
	34	fn standardNoPadBase64DecoderWithIgnore(ignore: []const u8) Base64DecoderWithIgnore {
	35	return Base64DecoderWithIgnore.init(standard_alphabet_chars, null, ignore);
	36	}
34	37
35	38	/// Standard Base64 codecs, with padding, as defined in
36	39	/// [RFC 4648 section 4](https://datatracker.ietf.org/doc/html/rfc4648#section-4).
...	...	@@ -47,7 +50,7 @@ pub const standard = Codecs{
47	50	pub const standard_no_pad = Codecs{
48	51	.alphabet_chars = standard_alphabet_chars,
49	52	.pad_char = null,
50		.decoderWithIgnore = standardBase64DecoderWithIgnore,
	53	.decoderWithIgnore = standardNoPadBase64DecoderWithIgnore,
51	54	.Encoder = Base64Encoder.init(standard_alphabet_chars, null),
52	55	.Decoder = Base64Decoder.init(standard_alphabet_chars, null),
53	56	};
...	...	@@ -56,6 +59,9 @@ pub const standard_no_pad = Codecs{
56	59	/// [RFC 4648 section 5](https://datatracker.ietf.org/doc/html/rfc4648#section-5).
57	60	pub const url_safe_alphabet_chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_".*;
58	61	fn urlSafeBase64DecoderWithIgnore(ignore: []const u8) Base64DecoderWithIgnore {
	62	return Base64DecoderWithIgnore.init(url_safe_alphabet_chars, '=', ignore);
	63	}
	64	fn urlSafeNoPadBase64DecoderWithIgnore(ignore: []const u8) Base64DecoderWithIgnore {
59	65	return Base64DecoderWithIgnore.init(url_safe_alphabet_chars, null, ignore);
60	66	}
61	67
...	...	@@ -74,7 +80,7 @@ pub const url_safe = Codecs{
74	80	pub const url_safe_no_pad = Codecs{
75	81	.alphabet_chars = url_safe_alphabet_chars,
76	82	.pad_char = null,
77		.decoderWithIgnore = urlSafeBase64DecoderWithIgnore,
	83	.decoderWithIgnore = urlSafeNoPadBase64DecoderWithIgnore,
78	84	.Encoder = Base64Encoder.init(url_safe_alphabet_chars, null),
79	85	.Decoder = Base64Decoder.init(url_safe_alphabet_chars, null),
80	86	};