| ... | ... | @@ -163,7 +163,6 @@ const Module = switch (native_os) { |
| 163 | 163 | const syms = syms_ptr[0..symtab.nsyms]; |
| 164 | 164 | const strings = mapped_mem[symtab.stroff..][0 .. symtab.strsize - 1 :0]; |
| 165 | 165 | |
| 166 | | // MLUGG TODO: does it really make sense to initCapacity here? how many of syms are omitted? |
| 167 | 166 | var symbols: std.ArrayList(MachoSymbol) = try .initCapacity(gpa, syms.len); |
| 168 | 167 | defer symbols.deinit(gpa); |
| 169 | 168 | |
| ... | ... | @@ -438,7 +437,6 @@ const Module = switch (native_os) { |
| 438 | 437 | const symtab: []align(1) const macho.nlist_64 = @ptrCast(mapped_mem[symtab_cmd.symoff..][0..n_sym_bytes]); |
| 439 | 438 | |
| 440 | 439 | // TODO handle tentative (common) symbols |
| 441 | | // MLUGG TODO: does initCapacity actually make sense? |
| 442 | 440 | var addr_table: std.StringArrayHashMapUnmanaged(u64) = .empty; |
| 443 | 441 | defer addr_table.deinit(gpa); |
| 444 | 442 | try addr_table.ensureUnusedCapacity(gpa, @intCast(symtab.len)); |
| ... | ... | @@ -516,7 +514,7 @@ const Module = switch (native_os) { |
| 516 | 514 | gnu_eh_frame: ?[]const u8, |
| 517 | 515 | const LookupCache = void; |
| 518 | 516 | const DebugInfo = struct { |
| 519 | | loaded_elf: ?Dwarf.ElfModule, // MLUGG TODO: bad field name |
| 517 | loaded_elf: ?Dwarf.ElfModule, |
| 520 | 518 | unwind: ?Dwarf.Unwind, |
| 521 | 519 | const init: DebugInfo = .{ |
| 522 | 520 | .loaded_elf = null, |
Matthew Lugg <mlugg@mlugg.co.uk> 2025-09-02 16:41:09+01:00
Commit is signed but in an unrecognized format.
lib