authorgravatar for mlugg@mlugg.co.ukMatthew Lugg <mlugg@mlugg.co.uk> 2025-09-02 16:41:09+01:00
committergravatar for mlugg@mlugg.co.ukMatthew Lugg <mlugg@mlugg.co.uk> 2025-09-30 13:44:50+01:00
logb762cd30fd3695e6c54b81d71f9adaf7bac1e5be
treeb5f607a83ca1c5c9cf5d1e2a7f53a6fa182f0f50
parente4dbfc109bb32334f8d0dde9277ddd80c9b6f126
signaturelock-open Commit is signed but in an unrecognized format.

remove TODOs which are done or which i'm not actually gonna do lol

1 files changed, 1 insertions(+), 3 deletions(-)

lib/std/debug/SelfInfo.zig+1-3
...@@ -163,7 +163,6 @@ const Module = switch (native_os) {...@@ -163,7 +163,6 @@ const Module = switch (native_os) {
163 const syms = syms_ptr[0..symtab.nsyms];163 const syms = syms_ptr[0..symtab.nsyms];
164 const strings = mapped_mem[symtab.stroff..][0 .. symtab.strsize - 1 :0];164 const strings = mapped_mem[symtab.stroff..][0 .. symtab.strsize - 1 :0];
165165
166 // MLUGG TODO: does it really make sense to initCapacity here? how many of syms are omitted?
167 var symbols: std.ArrayList(MachoSymbol) = try .initCapacity(gpa, syms.len);166 var symbols: std.ArrayList(MachoSymbol) = try .initCapacity(gpa, syms.len);
168 defer symbols.deinit(gpa);167 defer symbols.deinit(gpa);
169168
...@@ -438,7 +437,6 @@ const Module = switch (native_os) {...@@ -438,7 +437,6 @@ const Module = switch (native_os) {
438 const symtab: []align(1) const macho.nlist_64 = @ptrCast(mapped_mem[symtab_cmd.symoff..][0..n_sym_bytes]);437 const symtab: []align(1) const macho.nlist_64 = @ptrCast(mapped_mem[symtab_cmd.symoff..][0..n_sym_bytes]);
439438
440 // TODO handle tentative (common) symbols439 // TODO handle tentative (common) symbols
441 // MLUGG TODO: does initCapacity actually make sense?
442 var addr_table: std.StringArrayHashMapUnmanaged(u64) = .empty;440 var addr_table: std.StringArrayHashMapUnmanaged(u64) = .empty;
443 defer addr_table.deinit(gpa);441 defer addr_table.deinit(gpa);
444 try addr_table.ensureUnusedCapacity(gpa, @intCast(symtab.len));442 try addr_table.ensureUnusedCapacity(gpa, @intCast(symtab.len));
...@@ -516,7 +514,7 @@ const Module = switch (native_os) {...@@ -516,7 +514,7 @@ const Module = switch (native_os) {
516 gnu_eh_frame: ?[]const u8,514 gnu_eh_frame: ?[]const u8,
517 const LookupCache = void;515 const LookupCache = void;
518 const DebugInfo = struct {516 const DebugInfo = struct {
519 loaded_elf: ?Dwarf.ElfModule, // MLUGG TODO: bad field name517 loaded_elf: ?Dwarf.ElfModule,
520 unwind: ?Dwarf.Unwind,518 unwind: ?Dwarf.Unwind,
521 const init: DebugInfo = .{519 const init: DebugInfo = .{
522 .loaded_elf = null,520 .loaded_elf = null,