| ... | @@ -23,6 +23,7 @@ const Color = std.zig.Color; | ... | @@ -23,6 +23,7 @@ const Color = std.zig.Color; |
| 23 | const Client = std.zig.Client; | 23 | const Client = std.zig.Client; |
| 24 | const Server = std.zig.Server; | 24 | const Server = std.zig.Server; |
| 25 | const EnvVar = std.zig.EnvVar; | 25 | const EnvVar = std.zig.EnvVar; |
| | 26 | const ErrorBundle = std.zig.ErrorBundle; |
| 26 | const default_local_zig_cache_basename = std.zig.default_local_zig_cache_basename; | 27 | const default_local_zig_cache_basename = std.zig.default_local_zig_cache_basename; |
| 27 | const stringToEnum = std.meta.stringToEnum; | 28 | const stringToEnum = std.meta.stringToEnum; |
| 28 | | 29 | |
| ... | @@ -35,6 +36,7 @@ const ScannedConfig = @import("Maker/ScannedConfig.zig"); | ... | @@ -35,6 +36,7 @@ const ScannedConfig = @import("Maker/ScannedConfig.zig"); |
| 35 | const PkgConfig = @import("Maker/PkgConfig.zig"); | 36 | const PkgConfig = @import("Maker/PkgConfig.zig"); |
| 36 | const Fetch = @import("Maker/Fetch.zig"); | 37 | const Fetch = @import("Maker/Fetch.zig"); |
| 37 | const Package = @import("Maker/Package.zig"); | 38 | const Package = @import("Maker/Package.zig"); |
| | 39 | const Manifest = Package.Manifest; |
| 38 | | 40 | |
| 39 | pub const std_options: std.Options = .{ | 41 | pub const std_options: std.Options = .{ |
| 40 | .side_channels_mitigations = .none, | 42 | .side_channels_mitigations = .none, |
| ... | @@ -101,8 +103,30 @@ const InstallPaths = struct { | ... | @@ -101,8 +103,30 @@ const InstallPaths = struct { |
| 101 | }; | 103 | }; |
| 102 | | 104 | |
| 103 | const PrintNode = struct { | 105 | const PrintNode = struct { |
| 104 | parent: ?*PrintNode, | 106 | parent: ?*const PrintNode, |
| 105 | last: bool = false, | 107 | last: bool = false, |
| | 108 | |
| | 109 | fn printPrefix(node: *const PrintNode, writer: *Writer, mode: Io.Terminal.Mode) Writer.Error!void { |
| | 110 | const parent = node.parent orelse return; |
| | 111 | if (parent.parent == null) return; |
| | 112 | try printPrefix(parent, writer, mode); |
| | 113 | if (parent.last) { |
| | 114 | try writer.writeAll(" "); |
| | 115 | } else { |
| | 116 | try printTreeSibling(writer, mode); |
| | 117 | } |
| | 118 | } |
| | 119 | |
| | 120 | fn printPrefixedChild(node: *const PrintNode, writer: *Writer, mode: Io.Terminal.Mode) Writer.Error!void { |
| | 121 | try printPrefix(node, writer, mode); |
| | 122 | if (node.parent != null) { |
| | 123 | if (node.last) { |
| | 124 | try printTreeChildLast(writer, mode); |
| | 125 | } else { |
| | 126 | try printTreeChild(writer, mode); |
| | 127 | } |
| | 128 | } |
| | 129 | } |
| 106 | }; | 130 | }; |
| 107 | | 131 | |
| 108 | const ErrorStyle = enum { | 132 | const ErrorStyle = enum { |
| ... | @@ -125,7 +149,7 @@ const ErrorStyle = enum { | ... | @@ -125,7 +149,7 @@ const ErrorStyle = enum { |
| 125 | }; | 149 | }; |
| 126 | const MultilineErrors = enum { indent, newline, none }; | 150 | const MultilineErrors = enum { indent, newline, none }; |
| 127 | const Summary = enum { all, new, failures, line, none }; | 151 | const Summary = enum { all, new, failures, line, none }; |
| 128 | const PrintConfiguration = enum { none, zon, path }; | 152 | const PrintConfiguration = enum { none, zon, path, tree, stop }; |
| 129 | | 153 | |
| 130 | const GeneratedFile = struct { | 154 | const GeneratedFile = struct { |
| 131 | data: ?[]const u8, | 155 | data: ?[]const u8, |
| ... | @@ -276,7 +300,6 @@ pub fn main(init: process.Init.Minimal) !void { | ... | @@ -276,7 +300,6 @@ pub fn main(init: process.Init.Minimal) !void { |
| 276 | var cached_passthru_configure: std.ArrayList(u32) = .empty; | 300 | var cached_passthru_configure: std.ArrayList(u32) = .empty; |
| 277 | var forks: std.ArrayList(Fork) = .empty; | 301 | var forks: std.ArrayList(Fork) = .empty; |
| 278 | var system_pkg_dir_path: ?[]const u8 = null; | 302 | var system_pkg_dir_path: ?[]const u8 = null; |
| 279 | var fetch_only = false; | | |
| 280 | var fetch_mode: Fetch.JobQueue.Mode = .needed; | 303 | var fetch_mode: Fetch.JobQueue.Mode = .needed; |
| 281 | var debug_target: ?[]const u8 = null; | 304 | var debug_target: ?[]const u8 = null; |
| 282 | var cache_poison: std.Build.Graph.CachePoison = .pure; | 305 | var cache_poison: std.Build.Graph.CachePoison = .pure; |
| ... | @@ -361,12 +384,12 @@ pub fn main(init: process.Init.Minimal) !void { | ... | @@ -361,12 +384,12 @@ pub fn main(init: process.Init.Minimal) !void { |
| 361 | override_local_cache_dir = nextArgOrFatal(args, &arg_i); | 384 | override_local_cache_dir = nextArgOrFatal(args, &arg_i); |
| 362 | } else if (mem.eql(u8, arg, "--pkg-dir")) { | 385 | } else if (mem.eql(u8, arg, "--pkg-dir")) { |
| 363 | override_pkg_dir = nextArgOrFatal(args, &arg_i); | 386 | override_pkg_dir = nextArgOrFatal(args, &arg_i); |
| | 387 | } else if (mem.eql(u8, arg, "--print-tree")) { |
| | 388 | print_configuration = .tree; |
| | 389 | } else if (mem.eql(u8, arg, "--configure")) { |
| | 390 | print_configuration = .stop; |
| 364 | } else if (mem.eql(u8, arg, "--fetch")) { | 391 | } else if (mem.eql(u8, arg, "--fetch")) { |
| 365 | fetch_only = true; | 392 | fetch_mode = .all; |
| 366 | } else if (mem.cutPrefix(u8, arg, "--fetch=")) |rest| { | | |
| 367 | fetch_only = true; | | |
| 368 | fetch_mode = stringToEnum(Fetch.JobQueue.Mode, rest) orelse | | |
| 369 | fatal("expected [needed|all] after \"--fetch=\", found {q}", .{rest}); | | |
| 370 | } else if (mem.cutPrefix(u8, arg, "--fork=")) |rest| { | 393 | } else if (mem.cutPrefix(u8, arg, "--fork=")) |rest| { |
| 371 | try forks.append(arena, .init(rest)); | 394 | try forks.append(arena, .init(rest)); |
| 372 | } else if (mem.eql(u8, arg, "--fork")) { | 395 | } else if (mem.eql(u8, arg, "--fork")) { |
| ... | @@ -593,7 +616,7 @@ pub fn main(init: process.Init.Minimal) !void { | ... | @@ -593,7 +616,7 @@ pub fn main(init: process.Init.Minimal) !void { |
| 593 | } | 616 | } |
| 594 | } | 617 | } |
| 595 | | 618 | |
| 596 | const early_exit_mode = fetch_only or help_menu or steps_menu or print_configuration != .none; | 619 | const early_exit_mode = fetch_mode == .all or help_menu or steps_menu or print_configuration != .none; |
| 597 | const server_mode = !early_exit_mode and (watch_flag or webui_listen != null or fuzz != null or listen); | 620 | const server_mode = !early_exit_mode and (watch_flag or webui_listen != null or fuzz != null or listen); |
| 598 | | 621 | |
| 599 | process.raiseFileDescriptorLimit(); | 622 | process.raiseFileDescriptorLimit(); |
| ... | @@ -601,10 +624,16 @@ pub fn main(init: process.Init.Minimal) !void { | ... | @@ -601,10 +624,16 @@ pub fn main(init: process.Init.Minimal) !void { |
| 601 | const cwd_path = std.zig.getResolvedCwd(io, arena) catch |err| | 624 | const cwd_path = std.zig.getResolvedCwd(io, arena) catch |err| |
| 602 | fatal("resolving current directory path failed: {t}", .{err}); | 625 | fatal("resolving current directory path failed: {t}", .{err}); |
| 603 | | 626 | |
| 604 | var build_root = try findBuildRoot(arena, io, .{ | 627 | var build_root = findBuildRoot(arena, io, .{ |
| 605 | .cwd_path = cwd_path, | 628 | .cwd_path = cwd_path, |
| 606 | .build_file = build_file, | 629 | .build_file = build_file, |
| 607 | }); | 630 | }) catch |err| switch (err) { |
| | 631 | error.BuildZigNotFound => { |
| | 632 | if (help_menu) printUsageWithoutConfiguration(&graph, "build.zig not found"); |
| | 633 | process.exit(1); |
| | 634 | }, |
| | 635 | else => |e| return e, |
| | 636 | }; |
| 608 | defer build_root.deinit(io); | 637 | defer build_root.deinit(io); |
| 609 | | 638 | |
| 610 | graph.build_root_directory = build_root.directory; | 639 | graph.build_root_directory = build_root.directory; |
| ... | @@ -740,7 +769,7 @@ pub fn main(init: process.Init.Minimal) !void { | ... | @@ -740,7 +769,7 @@ pub fn main(init: process.Init.Minimal) !void { |
| 740 | var configure_source_files: Cache.Manifest.SelfContainedFiles = .empty; | 769 | var configure_source_files: Cache.Manifest.SelfContainedFiles = .empty; |
| 741 | defer configure_source_files.deinit(gpa); | 770 | defer configure_source_files.deinit(gpa); |
| 742 | | 771 | |
| 743 | var configure_error_bundle: std.zig.ErrorBundle = .empty; | 772 | var configure_error_bundle: ErrorBundle = .empty; |
| 744 | defer configure_error_bundle.deinit(gpa); | 773 | defer configure_error_bundle.deinit(gpa); |
| 745 | | 774 | |
| 746 | // If this fails, we can still start the server and wait for user | 775 | // If this fails, we can still start the server and wait for user |
| ... | @@ -761,7 +790,6 @@ pub fn main(init: process.Init.Minimal) !void { | ... | @@ -761,7 +790,6 @@ pub fn main(init: process.Init.Minimal) !void { |
| 761 | .parent_progress_node = main_progress_node, | 790 | .parent_progress_node = main_progress_node, |
| 762 | .fetch_mode = fetch_mode, | 791 | .fetch_mode = fetch_mode, |
| 763 | .system_pkg_dir_path = system_pkg_dir_path, | 792 | .system_pkg_dir_path = system_pkg_dir_path, |
| 764 | .fetch_only = fetch_only, | | |
| 765 | .print_configuration = print_configuration, | 793 | .print_configuration = print_configuration, |
| 766 | .forks = forks.items, | 794 | .forks = forks.items, |
| 767 | .src_files = &configure_source_files, | 795 | .src_files = &configure_source_files, |
| ... | @@ -789,6 +817,8 @@ pub fn main(init: process.Init.Minimal) !void { | ... | @@ -789,6 +817,8 @@ pub fn main(init: process.Init.Minimal) !void { |
| 789 | return cleanExit(io, &scanned_config); | 817 | return cleanExit(io, &scanned_config); |
| 790 | }, | 818 | }, |
| 791 | .path => unreachable, | 819 | .path => unreachable, |
| | 820 | .tree => unreachable, |
| | 821 | .stop => return cleanExit(io, &scanned_config), |
| 792 | } | 822 | } |
| 793 | | 823 | |
| 794 | var maker: Maker = .{ | 824 | var maker: Maker = .{ |
| ... | @@ -1043,7 +1073,10 @@ pub fn main(init: process.Init.Minimal) !void { | ... | @@ -1043,7 +1073,10 @@ pub fn main(init: process.Init.Minimal) !void { |
| 1043 | } else |err| { | 1073 | } else |err| { |
| 1044 | const can_fs_watch = switch (err) { | 1074 | const can_fs_watch = switch (err) { |
| 1045 | error.AlreadyReported => false, | 1075 | error.AlreadyReported => false, |
| 1046 | error.FailedButCacheIntact => true, | 1076 | error.FailedButCacheIntact => c: { |
| | 1077 | if (help_menu) printUsageWithoutConfiguration(&graph, "build.zig compilation failure"); |
| | 1078 | break :c true; |
| | 1079 | }, |
| 1047 | else => |e| w: { | 1080 | else => |e| w: { |
| 1048 | log.err("configuration failed: {t}", .{e}); | 1081 | log.err("configuration failed: {t}", .{e}); |
| 1049 | break :w false; | 1082 | break :w false; |
| ... | @@ -1065,6 +1098,17 @@ pub fn main(init: process.Init.Minimal) !void { | ... | @@ -1065,6 +1098,17 @@ pub fn main(init: process.Init.Minimal) !void { |
| 1065 | } | 1098 | } |
| 1066 | } | 1099 | } |
| 1067 | | 1100 | |
| | 1101 | fn printUsageWithoutConfiguration(graph: *Graph, reason: []const u8) noreturn { |
| | 1102 | const io = graph.io; |
| | 1103 | _ = io.lockStderr(&.{}, graph.stderr_mode) catch {}; |
| | 1104 | const writer = initStdoutWriter(io); |
| | 1105 | ScannedConfig.printUsageWithoutConfiguration(graph.zig_exe, writer, reason) catch |err| switch (err) { |
| | 1106 | error.WriteFailed => fatal("failed writing to stdout: {t}", .{stdout_writer_allocation.err.?}), |
| | 1107 | }; |
| | 1108 | stdout_writer_allocation.flush() catch |err| fatal("failed writing to stdout: {t}", .{err}); |
| | 1109 | return process.exit(0); |
| | 1110 | } |
| | 1111 | |
| 1068 | /// Temporarily adds the reconfigure pseudostep to step_stack, calls | 1112 | /// Temporarily adds the reconfigure pseudostep to step_stack, calls |
| 1069 | /// `Watch.update`, and then pops it again. | 1113 | /// `Watch.update`, and then pops it again. |
| 1070 | fn updateWatch(maker: *Maker, watch: *Watch) !void { | 1114 | fn updateWatch(maker: *Maker, watch: *Watch) !void { |
| ... | @@ -1088,11 +1132,10 @@ const ConfigureOptions = struct { | ... | @@ -1088,11 +1132,10 @@ const ConfigureOptions = struct { |
| 1088 | parent_progress_node: std.Progress.Node, | 1132 | parent_progress_node: std.Progress.Node, |
| 1089 | fetch_mode: Fetch.JobQueue.Mode, | 1133 | fetch_mode: Fetch.JobQueue.Mode, |
| 1090 | system_pkg_dir_path: ?[]const u8, | 1134 | system_pkg_dir_path: ?[]const u8, |
| 1091 | fetch_only: bool, | | |
| 1092 | print_configuration: PrintConfiguration, | 1135 | print_configuration: PrintConfiguration, |
| 1093 | forks: []Fork, | 1136 | forks: []Fork, |
| 1094 | src_files: *Cache.Manifest.SelfContainedFiles, | 1137 | src_files: *Cache.Manifest.SelfContainedFiles, |
| 1095 | error_bundle: ?*std.zig.ErrorBundle = null, | 1138 | error_bundle: ?*ErrorBundle = null, |
| 1096 | }; | 1139 | }; |
| 1097 | | 1140 | |
| 1098 | fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig { | 1141 | fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig { |
| ... | @@ -1336,11 +1379,27 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig { | ... | @@ -1336,11 +1379,27 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig { |
| 1336 | return error.FailedButCacheIntact; | 1379 | return error.FailedButCacheIntact; |
| 1337 | } | 1380 | } |
| 1338 | | 1381 | |
| 1339 | if (options.fetch_only) { | 1382 | if (options.print_configuration == .tree) { |
| | 1383 | const NO_COLOR = EnvVar.NO_COLOR.isSet(&graph.environ_map); |
| | 1384 | const CLICOLOR_FORCE = EnvVar.CLICOLOR_FORCE.isSet(&graph.environ_map); |
| | 1385 | printPkgTree(.{ |
| | 1386 | .writer = initStdoutWriter(io), |
| | 1387 | .mode = try .detect(io, .stdout(), NO_COLOR, CLICOLOR_FORCE), |
| | 1388 | }, arena, &job_queue, &fetch) catch |err| switch (err) { |
| | 1389 | error.WriteFailed => return stdout_writer_allocation.err.?, |
| | 1390 | else => |e| return e, |
| | 1391 | }; |
| | 1392 | try stdout_writer_allocation.flush(); |
| | 1393 | process.exit(0); |
| | 1394 | } |
| | 1395 | |
| | 1396 | if (options.fetch_mode == .all) { |
| 1340 | _ = io.lockStderr(&.{}, .no_color) catch {}; | 1397 | _ = io.lockStderr(&.{}, .no_color) catch {}; |
| 1341 | process.exit(0); | 1398 | process.exit(0); |
| 1342 | } | 1399 | } |
| 1343 | | 1400 | |
| | 1401 | try validateFingerprints(gpa, &job_queue); |
| | 1402 | |
| 1344 | // Create the dependencies.zig file for configurer to | 1403 | // Create the dependencies.zig file for configurer to |
| 1345 | // obtain via `@import("@dependencies")`. | 1404 | // obtain via `@import("@dependencies")`. |
| 1346 | { | 1405 | { |
| ... | @@ -1403,7 +1462,7 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig { | ... | @@ -1403,7 +1462,7 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig { |
| 1403 | for (fetches) |f| { | 1462 | for (fetches) |f| { |
| 1404 | if (!f.have_manifest) continue; | 1463 | if (!f.have_manifest) continue; |
| 1405 | if (config_man) |man| { | 1464 | if (config_man) |man| { |
| 1406 | const manifest_path = try f.package_root.join(arena, Package.Manifest.basename); | 1465 | const manifest_path = try f.package_root.join(arena, Manifest.basename); |
| 1407 | _ = try man.addInputPath(manifest_path, .{}); | 1466 | _ = try man.addInputPath(manifest_path, .{}); |
| 1408 | } | 1467 | } |
| 1409 | const mod = f.cli_module orelse continue; | 1468 | const mod = f.cli_module orelse continue; |
| ... | @@ -1619,7 +1678,8 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig { | ... | @@ -1619,7 +1678,8 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig { |
| 1619 | _ = io.lockStderr(&.{}, .no_color) catch {}; | 1678 | _ = io.lockStderr(&.{}, .no_color) catch {}; |
| 1620 | process.exit(0); | 1679 | process.exit(0); |
| 1621 | }, | 1680 | }, |
| 1622 | .none, .zon => {}, | 1681 | .none, .zon, .stop => {}, |
| | 1682 | .tree => unreachable, |
| 1623 | } | 1683 | } |
| 1624 | | 1684 | |
| 1625 | const configuration = c: { | 1685 | const configuration = c: { |
| ... | @@ -1657,6 +1717,147 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig { | ... | @@ -1657,6 +1717,147 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig { |
| 1657 | }; | 1717 | }; |
| 1658 | } | 1718 | } |
| 1659 | | 1719 | |
| | 1720 | const ValidFingerprintKey = struct { |
| | 1721 | project_id: Package.ProjectId, |
| | 1722 | version: std.SemanticVersion, |
| | 1723 | |
| | 1724 | const Context = struct { |
| | 1725 | pub fn hash(this: @This(), a: ValidFingerprintKey) u32 { |
| | 1726 | _ = this; |
| | 1727 | var hasher: std.hash.Wyhash = .init(a.project_id.fingerprint_id); |
| | 1728 | hasher.update(&a.project_id.padded_name); |
| | 1729 | hasher.update(@ptrCast((&a.version.major)[0..1])); |
| | 1730 | hasher.update(@ptrCast((&a.version.minor)[0..1])); |
| | 1731 | hasher.update(@ptrCast((&a.version.patch)[0..1])); |
| | 1732 | if (a.version.pre) |pre| hasher.update(pre); |
| | 1733 | return @truncate(hasher.final()); |
| | 1734 | } |
| | 1735 | pub fn eql(this: @This(), a: ValidFingerprintKey, b: ValidFingerprintKey, i: usize) bool { |
| | 1736 | _ = this; |
| | 1737 | _ = i; |
| | 1738 | return a.project_id.eql(&b.project_id) and a.version.order(b.version) == .eq; |
| | 1739 | } |
| | 1740 | }; |
| | 1741 | }; |
| | 1742 | |
| | 1743 | const ValidFingerprintTable = std.array_hash_map.Custom( |
| | 1744 | ValidFingerprintKey, |
| | 1745 | struct { fetch: *Fetch, pkg_hash: Package.Hash, printed: bool }, |
| | 1746 | ValidFingerprintKey.Context, |
| | 1747 | true, |
| | 1748 | ); |
| | 1749 | |
| | 1750 | /// Ensure that the dependency tree did not have any fingerprint matches with the same semantic version but |
| | 1751 | /// differing package hashes. |
| | 1752 | fn validateFingerprints(gpa: Allocator, job_queue: *const Fetch.JobQueue) !void { |
| | 1753 | var any_errors = false; |
| | 1754 | |
| | 1755 | var table: ValidFingerprintTable = .empty; |
| | 1756 | defer table.deinit(gpa); |
| | 1757 | |
| | 1758 | for (job_queue.table.keys(), job_queue.table.values()) |pkg_hash, fetch| { |
| | 1759 | if (!fetch.have_manifest) continue; |
| | 1760 | const gop = try table.getOrPut(gpa, .{ |
| | 1761 | .project_id = .init(fetch.manifest.name, fetch.manifest.id), |
| | 1762 | .version = fetch.manifest.version, |
| | 1763 | }); |
| | 1764 | if (gop.found_existing) { |
| | 1765 | any_errors = true; |
| | 1766 | const fingerprint: Package.Fingerprint = .init(fetch.manifest.id, fetch.manifest.name); |
| | 1767 | const stripped_version: std.SemanticVersion = .{ |
| | 1768 | .major = fetch.manifest.version.major, |
| | 1769 | .minor = fetch.manifest.version.minor, |
| | 1770 | .patch = fetch.manifest.version.patch, |
| | 1771 | .pre = fetch.manifest.version.pre, |
| | 1772 | }; |
| | 1773 | if (!gop.value_ptr.printed) { |
| | 1774 | gop.value_ptr.printed = true; |
| | 1775 | log.err("contradictory hash for package with fingerprint 0x{x} and version {f}: {s}", .{ |
| | 1776 | fingerprint.int(), stripped_version, gop.value_ptr.pkg_hash.toSlice(), |
| | 1777 | }); |
| | 1778 | } |
| | 1779 | log.err("contradictory hash for package with fingerprint 0x{x} and version {f}: {s}", .{ |
| | 1780 | fingerprint.int(), stripped_version, pkg_hash.toSlice(), |
| | 1781 | }); |
| | 1782 | } else { |
| | 1783 | gop.value_ptr.* = .{ .fetch = fetch, .pkg_hash = pkg_hash, .printed = false }; |
| | 1784 | } |
| | 1785 | } |
| | 1786 | if (any_errors) { |
| | 1787 | log.info("potential cause: package ownership dispute", .{}); |
| | 1788 | log.info("potential cause: maintainer neglected to bump version after making changes", .{}); |
| | 1789 | log.info("potential cause: dependency on unreleased changes", .{}); |
| | 1790 | log.info("hint: use --print-tree to visualize all package versions and hashes", .{}); |
| | 1791 | return error.FailedButCacheIntact; |
| | 1792 | } |
| | 1793 | } |
| | 1794 | |
| | 1795 | fn printPkgTree( |
| | 1796 | terminal: Io.Terminal, |
| | 1797 | arena: Allocator, |
| | 1798 | job_queue: *const Fetch.JobQueue, |
| | 1799 | root_fetch: *const Fetch, |
| | 1800 | ) !void { |
| | 1801 | if (!root_fetch.have_manifest) return; |
| | 1802 | const names = root_fetch.manifest.dependencies.keys(); |
| | 1803 | for (names, root_fetch.manifest.dependencies.values(), 0..) |name, *dep, i| { |
| | 1804 | var print_node: PrintNode = .{ |
| | 1805 | .parent = null, |
| | 1806 | .last = i == names.len - 1, |
| | 1807 | }; |
| | 1808 | try printPkgTreeChild(terminal, arena, job_queue, &print_node, name, dep.hash); |
| | 1809 | } |
| | 1810 | } |
| | 1811 | |
| | 1812 | fn printPkgTreeChild( |
| | 1813 | terminal: Io.Terminal, |
| | 1814 | arena: Allocator, |
| | 1815 | job_queue: *const Fetch.JobQueue, |
| | 1816 | parent_print_node: *const PrintNode, |
| | 1817 | dep_name: []const u8, |
| | 1818 | opt_hash: ?[]const u8, |
| | 1819 | ) !void { |
| | 1820 | const w = terminal.writer; |
| | 1821 | try parent_print_node.printPrefixedChild(w, terminal.mode); |
| | 1822 | try w.writeAll(dep_name); |
| | 1823 | |
| | 1824 | const hash = opt_hash orelse { |
| | 1825 | try terminal.setColor(.red); |
| | 1826 | try w.writeAll(" (missing hash)\n"); |
| | 1827 | try terminal.setColor(.reset); |
| | 1828 | return; |
| | 1829 | }; |
| | 1830 | try terminal.setColor(.dim); |
| | 1831 | try w.print(" {s}", .{hash}); |
| | 1832 | try terminal.setColor(.reset); |
| | 1833 | const child_fetch = job_queue.table.get(.fromSlice(hash)) orelse { |
| | 1834 | try terminal.setColor(.red); |
| | 1835 | try w.writeAll(" (fetch failed)\n"); |
| | 1836 | try terminal.setColor(.reset); |
| | 1837 | return; |
| | 1838 | }; |
| | 1839 | switch (child_fetch.lazy_status) { |
| | 1840 | .eager, .available => {}, |
| | 1841 | .unavailable => { |
| | 1842 | try terminal.setColor(.yellow); |
| | 1843 | try w.writeAll(" (not fetched)\n"); |
| | 1844 | try terminal.setColor(.reset); |
| | 1845 | return; |
| | 1846 | }, |
| | 1847 | } |
| | 1848 | try w.writeByte('\n'); |
| | 1849 | if (!child_fetch.have_manifest) return; |
| | 1850 | |
| | 1851 | const names = child_fetch.manifest.dependencies.keys(); |
| | 1852 | for (names, child_fetch.manifest.dependencies.values(), 0..) |name, *dep, i| { |
| | 1853 | var print_node: PrintNode = .{ |
| | 1854 | .parent = parent_print_node, |
| | 1855 | .last = i == names.len - 1, |
| | 1856 | }; |
| | 1857 | try printPkgTreeChild(terminal, arena, job_queue, &print_node, name, dep.hash); |
| | 1858 | } |
| | 1859 | } |
| | 1860 | |
| 1660 | fn cmdFetch(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { | 1861 | fn cmdFetch(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { |
| 1661 | const environ_map = &graph.environ_map; | 1862 | const environ_map = &graph.environ_map; |
| 1662 | const io = graph.io; | 1863 | const io = graph.io; |
| ... | @@ -1933,8 +2134,8 @@ fn cmdFetch(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { | ... | @@ -1933,8 +2134,8 @@ fn cmdFetch(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { |
| 1933 | try ast.render(gpa, &aw.writer, fixups); | 2134 | try ast.render(gpa, &aw.writer, fixups); |
| 1934 | const rendered = aw.written(); | 2135 | const rendered = aw.written(); |
| 1935 | | 2136 | |
| 1936 | build_root.directory.handle.writeFile(io, .{ .sub_path = Package.Manifest.basename, .data = rendered }) catch |err| { | 2137 | build_root.directory.handle.writeFile(io, .{ .sub_path = Manifest.basename, .data = rendered }) catch |err| { |
| 1937 | fatal("unable to write {s} file: {t}", .{ Package.Manifest.basename, err }); | 2138 | fatal("unable to write {s} file: {t}", .{ Manifest.basename, err }); |
| 1938 | }; | 2139 | }; |
| 1939 | | 2140 | |
| 1940 | return process.cleanExit(io); | 2141 | return process.cleanExit(io); |
| ... | @@ -2136,7 +2337,7 @@ fn cmdInit(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { | ... | @@ -2136,7 +2337,7 @@ fn cmdInit(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { |
| 2136 | const s = Dir.path.sep_str; | 2337 | const s = Dir.path.sep_str; |
| 2137 | const template_paths = [_][]const u8{ | 2338 | const template_paths = [_][]const u8{ |
| 2138 | default_build_zig_basename, | 2339 | default_build_zig_basename, |
| 2139 | Package.Manifest.basename, | 2340 | Manifest.basename, |
| 2140 | "src" ++ s ++ "main.zig", | 2341 | "src" ++ s ++ "main.zig", |
| 2141 | "src" ++ s ++ "root.zig", | 2342 | "src" ++ s ++ "root.zig", |
| 2142 | }; | 2343 | }; |
| ... | @@ -2160,7 +2361,7 @@ fn cmdInit(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { | ... | @@ -2160,7 +2361,7 @@ fn cmdInit(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { |
| 2160 | return process.cleanExit(io); | 2361 | return process.cleanExit(io); |
| 2161 | }, | 2362 | }, |
| 2162 | .minimal => { | 2363 | .minimal => { |
| 2163 | Templates.writeSimpleFile(io, Io.Dir.cwd(), Package.Manifest.basename, | 2364 | Templates.writeSimpleFile(io, Io.Dir.cwd(), Manifest.basename, |
| 2164 | \\.{{ | 2365 | \\.{{ |
| 2165 | \\ .name = .{s}, | 2366 | \\ .name = .{s}, |
| 2166 | \\ .version = "0.0.1", | 2367 | \\ .version = "0.0.1", |
| ... | @@ -2174,8 +2375,8 @@ fn cmdInit(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { | ... | @@ -2174,8 +2375,8 @@ fn cmdInit(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { |
| 2174 | builtin.zig_version_string, | 2375 | builtin.zig_version_string, |
| 2175 | fingerprint.int(), | 2376 | fingerprint.int(), |
| 2176 | }) catch |err| switch (err) { | 2377 | }) catch |err| switch (err) { |
| 2177 | else => fatal("failed to create {q}: {t}", .{ Package.Manifest.basename, err }), | 2378 | else => fatal("failed to create {q}: {t}", .{ Manifest.basename, err }), |
| 2178 | error.PathAlreadyExists => fatal("refusing to overwrite {q}", .{Package.Manifest.basename}), | 2379 | error.PathAlreadyExists => fatal("refusing to overwrite {q}", .{Manifest.basename}), |
| 2179 | }; | 2380 | }; |
| 2180 | Templates.writeSimpleFile(io, Io.Dir.cwd(), default_build_zig_basename, | 2381 | Templates.writeSimpleFile(io, Io.Dir.cwd(), default_build_zig_basename, |
| 2181 | \\const std = @import("std"); | 2382 | \\const std = @import("std"); |
| ... | @@ -2190,12 +2391,12 @@ fn cmdInit(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { | ... | @@ -2190,12 +2391,12 @@ fn cmdInit(gpa: Allocator, graph: *Graph, args: []const []const u8) !void { |
| 2190 | // their `build.zig.zon` *after* writing their `build.zig`. So this one isn't fatal. | 2391 | // their `build.zig.zon` *after* writing their `build.zig`. So this one isn't fatal. |
| 2191 | error.PathAlreadyExists => { | 2392 | error.PathAlreadyExists => { |
| 2192 | log.info("successfully populated {q}, preserving existing {q}", .{ | 2393 | log.info("successfully populated {q}, preserving existing {q}", .{ |
| 2193 | Package.Manifest.basename, default_build_zig_basename, | 2394 | Manifest.basename, default_build_zig_basename, |
| 2194 | }); | 2395 | }); |
| 2195 | return process.cleanExit(io); | 2396 | return process.cleanExit(io); |
| 2196 | }, | 2397 | }, |
| 2197 | }; | 2398 | }; |
| 2198 | log.info("successfully populated {q} and {q}", .{ Package.Manifest.basename, default_build_zig_basename }); | 2399 | log.info("successfully populated {q} and {q}", .{ Manifest.basename, default_build_zig_basename }); |
| 2199 | return process.cleanExit(io); | 2400 | return process.cleanExit(io); |
| 2200 | }, | 2401 | }, |
| 2201 | } | 2402 | } |
| ... | @@ -2928,18 +3129,7 @@ fn printTreeStep( | ... | @@ -2928,18 +3129,7 @@ fn printTreeStep( |
| 2928 | .failures => make_step.state == .success, | 3129 | .failures => make_step.state == .success, |
| 2929 | }; | 3130 | }; |
| 2930 | if (skip) return; | 3131 | if (skip) return; |
| 2931 | try printPrefix(parent_node, stderr); | 3132 | try parent_node.printPrefixedChild(writer, stderr.mode); |
| 2932 | | | |
| 2933 | if (parent_node.parent != null) { | | |
| 2934 | if (parent_node.last) { | | |
| 2935 | try printChildNodePrefix(stderr); | | |
| 2936 | } else { | | |
| 2937 | try writer.writeAll(switch (stderr.mode) { | | |
| 2938 | .escape_codes => "\x1B\x28\x30\x74\x71\x1B\x28\x42 ", // ├─ | | |
| 2939 | else => "+- ", | | |
| 2940 | }); | | |
| 2941 | } | | |
| 2942 | } | | |
| 2943 | | 3133 | |
| 2944 | if (!first) try stderr.setColor(.dim); | 3134 | if (!first) try stderr.setColor(.dim); |
| 2945 | | 3135 | |
| ... | @@ -3168,23 +3358,22 @@ fn printStepFailure( | ... | @@ -3168,23 +3358,22 @@ fn printStepFailure( |
| 3168 | } | 3358 | } |
| 3169 | } | 3359 | } |
| 3170 | | 3360 | |
| 3171 | fn printPrefix(node: *PrintNode, stderr: Io.Terminal) !void { | 3361 | fn printTreeChild(writer: *Writer, mode: Io.Terminal.Mode) Writer.Error!void { |
| 3172 | const parent = node.parent orelse return; | 3362 | return writer.writeAll(switch (mode) { |
| 3173 | const writer = stderr.writer; | 3363 | .escape_codes => "\x1B\x28\x30\x74\x71\x1B\x28\x42 ", // ├─ |
| 3174 | if (parent.parent == null) return; | 3364 | else => "+- ", |
| 3175 | try printPrefix(parent, stderr); | 3365 | }); |
| 3176 | if (parent.last) { | | |
| 3177 | try writer.writeAll(" "); | | |
| 3178 | } else { | | |
| 3179 | try writer.writeAll(switch (stderr.mode) { | | |
| 3180 | .escape_codes => "\x1B\x28\x30\x78\x1B\x28\x42 ", // │ | | |
| 3181 | else => "| ", | | |
| 3182 | }); | | |
| 3183 | } | | |
| 3184 | } | 3366 | } |
| 3185 | | 3367 | |
| 3186 | fn printChildNodePrefix(stderr: Io.Terminal) !void { | 3368 | fn printTreeSibling(writer: *Writer, mode: Io.Terminal.Mode) Writer.Error!void { |
| 3187 | try stderr.writer.writeAll(switch (stderr.mode) { | 3369 | return writer.writeAll(switch (mode) { |
| | 3370 | .escape_codes => "\x1B\x28\x30\x78\x1B\x28\x42 ", // │ |
| | 3371 | else => "| ", |
| | 3372 | }); |
| | 3373 | } |
| | 3374 | |
| | 3375 | fn printTreeChildLast(writer: *Writer, mode: Io.Terminal.Mode) !void { |
| | 3376 | try writer.writeAll(switch (mode) { |
| 3188 | .escape_codes => "\x1B\x28\x30\x6d\x71\x1B\x28\x42 ", // └─ | 3377 | .escape_codes => "\x1B\x28\x30\x6d\x71\x1B\x28\x42 ", // └─ |
| 3189 | else => "+- ", | 3378 | else => "+- ", |
| 3190 | }); | 3379 | }); |
| ... | @@ -3278,7 +3467,7 @@ pub fn invalidateResult(maker: *Maker, step: *Step) error{MustReconfigure}!bool | ... | @@ -3278,7 +3467,7 @@ pub fn invalidateResult(maker: *Maker, step: *Step) error{MustReconfigure}!bool |
| 3278 | pub fn printErrorMessages( | 3467 | pub fn printErrorMessages( |
| 3279 | maker: *Maker, | 3468 | maker: *Maker, |
| 3280 | failing_step_index: Configuration.Step.Index, | 3469 | failing_step_index: Configuration.Step.Index, |
| 3281 | options: std.zig.ErrorBundle.RenderOptions, | 3470 | options: ErrorBundle.RenderOptions, |
| 3282 | stderr: Io.Terminal, | 3471 | stderr: Io.Terminal, |
| 3283 | error_style: ErrorStyle, | 3472 | error_style: ErrorStyle, |
| 3284 | multiline_errors: MultilineErrors, | 3473 | multiline_errors: MultilineErrors, |
| ... | @@ -3304,7 +3493,7 @@ pub fn printErrorMessages( | ... | @@ -3304,7 +3493,7 @@ pub fn printErrorMessages( |
| 3304 | while (step_stack.pop()) |step_index| : (indent += 1) { | 3493 | while (step_stack.pop()) |step_index| : (indent += 1) { |
| 3305 | if (indent > 0) { | 3494 | if (indent > 0) { |
| 3306 | try writer.splatByteAll(' ', (indent - 1) * 3); | 3495 | try writer.splatByteAll(' ', (indent - 1) * 3); |
| 3307 | try printChildNodePrefix(stderr); | 3496 | try printTreeChildLast(writer, stderr.mode); |
| 3308 | } | 3497 | } |
| 3309 | | 3498 | |
| 3310 | try writer.writeAll(step_index.ptr(c).name.slice(c)); | 3499 | try writer.writeAll(step_index.ptr(c).name.slice(c)); |
| ... | @@ -4038,7 +4227,9 @@ const FindBuildRootOptions = struct { | ... | @@ -4038,7 +4227,9 @@ const FindBuildRootOptions = struct { |
| 4038 | cwd_path: []const u8, | 4227 | cwd_path: []const u8, |
| 4039 | }; | 4228 | }; |
| 4040 | | 4229 | |
| 4041 | fn findBuildRoot(arena: Allocator, io: Io, options: FindBuildRootOptions) !BuildRoot { | 4230 | const FindBuildRootError = error{ OutOfMemory, BuildZigNotFound }; |
| | 4231 | |
| | 4232 | fn findBuildRoot(arena: Allocator, io: Io, options: FindBuildRootOptions) FindBuildRootError!BuildRoot { |
| 4042 | const build_zig_basename = if (options.build_file) |bf| | 4233 | const build_zig_basename = if (options.build_file) |bf| |
| 4043 | Dir.path.basename(bf) | 4234 | Dir.path.basename(bf) |
| 4044 | else | 4235 | else |
| ... | @@ -4089,11 +4280,12 @@ fn findBuildRoot(arena: Allocator, io: Io, options: FindBuildRootOptions) !Build | ... | @@ -4089,11 +4280,12 @@ fn findBuildRoot(arena: Allocator, io: Io, options: FindBuildRootOptions) !Build |
| 4089 | dirname = Dir.path.dirname(dirname orelse options.cwd_path) orelse { | 4280 | dirname = Dir.path.dirname(dirname orelse options.cwd_path) orelse { |
| 4090 | log.info("initialize {s} template file with \"zig init\"", .{std.zig.build_zig_basename}); | 4281 | log.info("initialize {s} template file with \"zig init\"", .{std.zig.build_zig_basename}); |
| 4091 | log.info("see \"zig --help\" for more options", .{}); | 4282 | log.info("see \"zig --help\" for more options", .{}); |
| 4092 | fatal("no build.zig file found, in the current directory or any parent directories", .{}); | 4283 | log.err("no build.zig file found, in the current directory or any parent directories", .{}); |
| | 4284 | return error.BuildZigNotFound; |
| 4093 | }; | 4285 | }; |
| 4094 | continue; | 4286 | continue; |
| 4095 | }, | 4287 | }, |
| 4096 | else => |e| return e, | 4288 | else => |e| fatal("accessing {q} while searching for build.zig file failed: {t}", .{ joined_path, e }), |
| 4097 | } | 4289 | } |
| 4098 | } | 4290 | } |
| 4099 | } | 4291 | } |
| ... | @@ -4101,8 +4293,8 @@ fn findBuildRoot(arena: Allocator, io: Io, options: FindBuildRootOptions) !Build | ... | @@ -4101,8 +4293,8 @@ fn findBuildRoot(arena: Allocator, io: Io, options: FindBuildRootOptions) !Build |
| 4101 | const Fork = struct { | 4293 | const Fork = struct { |
| 4102 | path: Path, | 4294 | path: Path, |
| 4103 | manifest_ast: std.zig.Ast, | 4295 | manifest_ast: std.zig.Ast, |
| 4104 | manifest: Package.Manifest, | 4296 | manifest: Manifest, |
| 4105 | error_bundle: std.zig.ErrorBundle.Wip, | 4297 | error_bundle: ErrorBundle.Wip, |
| 4106 | failed: bool, | 4298 | failed: bool, |
| 4107 | arena_allocator: std.heap.ArenaAllocator, | 4299 | arena_allocator: std.heap.ArenaAllocator, |
| 4108 | | 4300 | |
| ... | @@ -4135,12 +4327,12 @@ const Fork = struct { | ... | @@ -4135,12 +4327,12 @@ const Fork = struct { |
| 4135 | fork.arena_allocator = .init(gpa); | 4327 | fork.arena_allocator = .init(gpa); |
| 4136 | const arena = fork.arena_allocator.allocator(); | 4328 | const arena = fork.arena_allocator.allocator(); |
| 4137 | | 4329 | |
| 4138 | var error_bundle: std.zig.ErrorBundle.Wip = try .init(gpa); | 4330 | var error_bundle: ErrorBundle.Wip = try .init(gpa); |
| 4139 | defer error_bundle.deinit(); | 4331 | defer error_bundle.deinit(); |
| 4140 | | 4332 | |
| 4141 | const manifest_path = try fork.path.join(arena, Package.Manifest.basename); | 4333 | const manifest_path = try fork.path.join(arena, Manifest.basename); |
| 4142 | | 4334 | |
| 4143 | Package.Manifest.load( | 4335 | Manifest.load( |
| 4144 | io, | 4336 | io, |
| 4145 | arena, | 4337 | arena, |
| 4146 | manifest_path, | 4338 | manifest_path, |
| ... | @@ -4190,20 +4382,20 @@ fn loadManifest( | ... | @@ -4190,20 +4382,20 @@ fn loadManifest( |
| 4190 | arena: Allocator, | 4382 | arena: Allocator, |
| 4191 | io: Io, | 4383 | io: Io, |
| 4192 | options: LoadManifestOptions, | 4384 | options: LoadManifestOptions, |
| 4193 | ) !struct { Package.Manifest, std.zig.Ast } { | 4385 | ) !struct { Manifest, std.zig.Ast } { |
| 4194 | const rng: std.Random.IoSource = .{ .io = io }; | 4386 | const rng: std.Random.IoSource = .{ .io = io }; |
| 4195 | | 4387 | |
| 4196 | const manifest_bytes = while (true) { | 4388 | const manifest_bytes = while (true) { |
| 4197 | break options.dir.readFileAllocOptions( | 4389 | break options.dir.readFileAllocOptions( |
| 4198 | io, | 4390 | io, |
| 4199 | Package.Manifest.basename, | 4391 | Manifest.basename, |
| 4200 | arena, | 4392 | arena, |
| 4201 | .limited(Package.Manifest.max_bytes), | 4393 | .limited(Manifest.max_bytes), |
| 4202 | .@"1", | 4394 | .@"1", |
| 4203 | 0, | 4395 | 0, |
| 4204 | ) catch |err| switch (err) { | 4396 | ) catch |err| switch (err) { |
| 4205 | error.FileNotFound => { | 4397 | error.FileNotFound => { |
| 4206 | Templates.writeSimpleFile(io, options.dir, Package.Manifest.basename, | 4398 | Templates.writeSimpleFile(io, options.dir, Manifest.basename, |
| 4207 | \\.{{ | 4399 | \\.{{ |
| 4208 | \\ .name = .{s}, | 4400 | \\ .name = .{s}, |
| 4209 | \\ .version = "0.0.1", | 4401 | \\ .version = "0.0.1", |
| ... | @@ -4217,29 +4409,29 @@ fn loadManifest( | ... | @@ -4217,29 +4409,29 @@ fn loadManifest( |
| 4217 | builtin.zig_version_string, | 4409 | builtin.zig_version_string, |
| 4218 | Package.Fingerprint.generate(rng.interface(), options.root_name).int(), | 4410 | Package.Fingerprint.generate(rng.interface(), options.root_name).int(), |
| 4219 | }) catch |e| { | 4411 | }) catch |e| { |
| 4220 | fatal("unable to write {s}: {t}", .{ Package.Manifest.basename, e }); | 4412 | fatal("unable to write {s}: {t}", .{ Manifest.basename, e }); |
| 4221 | }; | 4413 | }; |
| 4222 | continue; | 4414 | continue; |
| 4223 | }, | 4415 | }, |
| 4224 | else => |e| fatal("unable to load {s}: {t}", .{ Package.Manifest.basename, e }), | 4416 | else => |e| fatal("unable to load {s}: {t}", .{ Manifest.basename, e }), |
| 4225 | }; | 4417 | }; |
| 4226 | }; | 4418 | }; |
| 4227 | var ast = try std.zig.Ast.parse(gpa, manifest_bytes, .{ .mode = .zon }); | 4419 | var ast = try std.zig.Ast.parse(gpa, manifest_bytes, .{ .mode = .zon }); |
| 4228 | errdefer ast.deinit(gpa); | 4420 | errdefer ast.deinit(gpa); |
| 4229 | | 4421 | |
| 4230 | if (ast.errors.len > 0) { | 4422 | if (ast.errors.len > 0) { |
| 4231 | try std.zig.printAstErrorsToStderr(gpa, io, ast, Package.Manifest.basename, options.color); | 4423 | try std.zig.printAstErrorsToStderr(gpa, io, ast, Manifest.basename, options.color); |
| 4232 | process.exit(2); | 4424 | process.exit(2); |
| 4233 | } | 4425 | } |
| 4234 | | 4426 | |
| 4235 | var manifest = try Package.Manifest.parse(gpa, &ast, rng.interface(), .{}); | 4427 | var manifest = try Manifest.parse(gpa, &ast, rng.interface(), .{}); |
| 4236 | errdefer manifest.deinit(gpa); | 4428 | errdefer manifest.deinit(gpa); |
| 4237 | | 4429 | |
| 4238 | if (manifest.errors.len > 0) { | 4430 | if (manifest.errors.len > 0) { |
| 4239 | var wip_errors: std.zig.ErrorBundle.Wip = try .init(gpa); | 4431 | var wip_errors: ErrorBundle.Wip = try .init(gpa); |
| 4240 | defer wip_errors.deinit(); | 4432 | defer wip_errors.deinit(); |
| 4241 | | 4433 | |
| 4242 | const src_path = try wip_errors.addString(Package.Manifest.basename); | 4434 | const src_path = try wip_errors.addString(Manifest.basename); |
| 4243 | try manifest.copyErrorsIntoBundle(ast, src_path, &wip_errors); | 4435 | try manifest.copyErrorsIntoBundle(ast, src_path, &wip_errors); |
| 4244 | | 4436 | |
| 4245 | var error_bundle = try wip_errors.toOwnedBundle(""); | 4437 | var error_bundle = try wip_errors.toOwnedBundle(""); |
| ... | @@ -4263,8 +4455,8 @@ fn sanitizeExampleName(arena: Allocator, bytes: []const u8) error{OutOfMemory}![ | ... | @@ -4263,8 +4455,8 @@ fn sanitizeExampleName(arena: Allocator, bytes: []const u8) error{OutOfMemory}![ |
| 4263 | else => continue, | 4455 | else => continue, |
| 4264 | }; | 4456 | }; |
| 4265 | if (!std.zig.isValidId(result.items)) return "foo"; | 4457 | if (!std.zig.isValidId(result.items)) return "foo"; |
| 4266 | if (result.items.len > Package.Manifest.max_name_len) | 4458 | if (result.items.len > Manifest.max_name_len) |
| 4267 | result.shrinkRetainingCapacity(Package.Manifest.max_name_len); | 4459 | result.shrinkRetainingCapacity(Manifest.max_name_len); |
| 4268 | | 4460 | |
| 4269 | return result.toOwnedSlice(arena); | 4461 | return result.toOwnedSlice(arena); |
| 4270 | } | 4462 | } |