authorgravatar for jacoblevgw@gmail.comJacob G-W <jacoblevgw@gmail.com> 2021-03-11 22:53:39-05:00
committergravatar for git@vexu.euVeikka Tuominen <git@vexu.eu> 2021-06-13 22:33:39+03:00
logb9f07b7ac227134001258e5933e3ef61aae80303
treead56b175414566e6ed1ea030d69399ba91d2a922
parentff79b87fa062d602722a6ec17f74550cda42a624

format zig files and add formatting check to ci


5 files changed, 57 insertions(+), 30 deletions(-)

ci/azure/linux_script+3
......@@ -59,6 +59,9 @@ unset CXX
5959
6060make $JOBS install
6161
62# look for formatting errors
63release/bin/zig fmt --check .. || (echo "Please run 'zig fmt' to fix the non-conforming files listed above." && false)
64
6265# Here we rebuild zig but this time using the Zig binary we just now produced to
6366# build zig1.o rather than relying on the one built with stage0. See
6467# https://github.com/ziglang/zig/issues/6830 for more details.
lib/std/Thread/Futex.zig+8-8
......@@ -84,7 +84,7 @@ else
8484
8585const WindowsFutex = struct {
8686 const windows = std.os.windows;
87
87
8888 fn wait(ptr: *const Atomic(u32), expect: u32, timeout: ?u64) error{TimedOut}!void {
8989 var timeout_value: windows.LARGE_INTEGER = undefined;
9090 var timeout_ptr: ?*const windows.LARGE_INTEGER = null;
......@@ -299,7 +299,7 @@ const PosixFutex = struct {
299299 state: State = .empty,
300300 cond: std.c.pthread_cond_t = .{},
301301 mutex: std.c.pthread_mutex_t = .{},
302
302
303303 const Self = @This();
304304 const State = enum {
305305 empty,
......@@ -381,7 +381,7 @@ test "Futex - wait/wake" {
381381
382382 const wait_noop_result = Futex.wait(&value, 0, 0);
383383 try testing.expectError(error.TimedOut, wait_noop_result);
384
384
385385 const wait_longer_result = Futex.wait(&value, 0, std.time.ns_per_ms);
386386 try testing.expectError(error.TimedOut, wait_longer_result);
387387
......@@ -416,7 +416,7 @@ test "Futex - Signal" {
416416 const Thread = struct {
417417 tx: *Self,
418418 rx: *Self,
419
419
420420 const start_value = 1;
421421
422422 fn run(self: Thread) void {
......@@ -472,7 +472,7 @@ test "Futex - Broadcast" {
472472 self.broadcast.store(BROADCAST_RECEIVED, .Release);
473473 Futex.wake(&self.broadcast, 1);
474474 }
475 }
475 }
476476
477477 fn run() !void {
478478 var self = Self{};
......@@ -542,7 +542,7 @@ test "Futex - Chain" {
542542 if (chain.index + 1 < chain.self.threads.len) {
543543 next_signal = &chain.self.threads[chain.index + 1].signal;
544544 }
545
545
546546 this_signal.wait();
547547 next_signal.notify();
548548 }
......@@ -554,7 +554,7 @@ test "Futex - Chain" {
554554 for (self.threads) |*entry, index| {
555555 entry.signal = .{};
556556 entry.thread = try std.Thread.spawn(Chain.run, .{
557 .self = &self,
557 .self = &self,
558558 .index = index,
559559 });
560560 }
......@@ -567,4 +567,4 @@ test "Futex - Chain" {
567567 }
568568 }
569569 }).run();
570}
\ No newline at end of file
570}
lib/std/c/darwin.zig+2-2
......@@ -246,7 +246,7 @@ pub const ULF_WAIT_ADAPTIVE_SPIN = 0x40000;
246246
247247pub extern "c" fn __ulock_wait2(op: u32, addr: ?*const c_void, val: u64, timeout_us: u32, val2: u64) c_int;
248248pub extern "c" fn __ulock_wait(op: u32, addr: ?*const c_void, val: u64, timeout_us: u32) c_int;
249pub extern "c" fn __ulock_wake(op: u32, addr: ?*const c_void, val: u64) c_int;
249pub extern "c" fn __ulock_wake(op: u32, addr: ?*const c_void, val: u64) c_int;
250250
251251pub const OS_UNFAIR_LOCK_INIT = os_unfair_lock{};
252252pub const os_unfair_lock_t = *os_unfair_lock;
......@@ -258,4 +258,4 @@ pub extern "c" fn os_unfair_lock_lock(o: os_unfair_lock_t) void;
258258pub extern "c" fn os_unfair_lock_unlock(o: os_unfair_lock_t) void;
259259pub extern "c" fn os_unfair_lock_trylock(o: os_unfair_lock_t) bool;
260260pub extern "c" fn os_unfair_lock_assert_owner(o: os_unfair_lock_t) void;
261pub extern "c" fn os_unfair_lock_assert_not_owner(o: os_unfair_lock_t) void;
\ No newline at end of file
261pub extern "c" fn os_unfair_lock_assert_not_owner(o: os_unfair_lock_t) void;
lib/std/zig/parse.zig+42-15
......@@ -2005,9 +2005,12 @@ const Parser = struct {
20052005 if (field_init != 0) {
20062006 try p.scratch.append(p.gpa, field_init);
20072007 while (true) {
2008 switch (p.token_tags[p.tok_i]) {
2008 switch (p.token_tags[p.tok_i]) {
20092009 .comma => p.tok_i += 1,
2010 .r_brace => { p.tok_i += 1; break; },
2010 .r_brace => {
2011 p.tok_i += 1;
2012 break;
2013 },
20112014 .colon, .r_paren, .r_bracket => return p.failExpected(.r_brace),
20122015 // Likely just a missing comma; give error but continue parsing.
20132016 else => try p.warnExpected(.comma),
......@@ -2045,7 +2048,10 @@ const Parser = struct {
20452048 try p.scratch.append(p.gpa, elem_init);
20462049 switch (p.token_tags[p.tok_i]) {
20472050 .comma => p.tok_i += 1,
2048 .r_brace => { p.tok_i += 1; break; },
2051 .r_brace => {
2052 p.tok_i += 1;
2053 break;
2054 },
20492055 .colon, .r_paren, .r_bracket => return p.failExpected(.r_brace),
20502056 // Likely just a missing comma; give error but continue parsing.
20512057 else => try p.warnExpected(.comma),
......@@ -2121,7 +2127,10 @@ const Parser = struct {
21212127 try p.scratch.append(p.gpa, param);
21222128 switch (p.token_tags[p.tok_i]) {
21232129 .comma => p.tok_i += 1,
2124 .r_paren => { p.tok_i += 1; break; },
2130 .r_paren => {
2131 p.tok_i += 1;
2132 break;
2133 },
21252134 .colon, .r_brace, .r_bracket => return p.failExpected(.r_paren),
21262135 // Likely just a missing comma; give error but continue parsing.
21272136 else => try p.warnExpected(.comma),
......@@ -2129,7 +2138,7 @@ const Parser = struct {
21292138 }
21302139 const comma = (p.token_tags[p.tok_i - 2] == .comma);
21312140 const params = p.scratch.items[scratch_top..];
2132 switch(params.len) {
2141 switch (params.len) {
21332142 0 => return p.addNode(.{
21342143 .tag = if (comma) .async_call_one_comma else .async_call_one,
21352144 .main_token = lparen,
......@@ -2174,7 +2183,10 @@ const Parser = struct {
21742183 try p.scratch.append(p.gpa, param);
21752184 switch (p.token_tags[p.tok_i]) {
21762185 .comma => p.tok_i += 1,
2177 .r_paren => { p.tok_i += 1; break; },
2186 .r_paren => {
2187 p.tok_i += 1;
2188 break;
2189 },
21782190 .colon, .r_brace, .r_bracket => return p.failExpected(.r_paren),
21792191 // Likely just a missing comma; give error but continue parsing.
21802192 else => try p.warnExpected(.comma),
......@@ -2182,7 +2194,7 @@ const Parser = struct {
21822194 }
21832195 const comma = (p.token_tags[p.tok_i - 2] == .comma);
21842196 const params = p.scratch.items[scratch_top..];
2185 res = switch(params.len) {
2197 res = switch (params.len) {
21862198 0 => try p.addNode(.{
21872199 .tag = if (comma) .call_one_comma else .call_one,
21882200 .main_token = lparen,
......@@ -2448,7 +2460,10 @@ const Parser = struct {
24482460 while (true) {
24492461 switch (p.token_tags[p.tok_i]) {
24502462 .comma => p.tok_i += 1,
2451 .r_brace => { p.tok_i += 1; break; },
2463 .r_brace => {
2464 p.tok_i += 1;
2465 break;
2466 },
24522467 .colon, .r_paren, .r_bracket => return p.failExpected(.r_brace),
24532468 // Likely just a missing comma; give error but continue parsing.
24542469 else => try p.warnExpected(.comma),
......@@ -2497,7 +2512,10 @@ const Parser = struct {
24972512 try p.scratch.append(p.gpa, elem_init);
24982513 switch (p.token_tags[p.tok_i]) {
24992514 .comma => p.tok_i += 1,
2500 .r_brace => { p.tok_i += 1; break; },
2515 .r_brace => {
2516 p.tok_i += 1;
2517 break;
2518 },
25012519 .colon, .r_paren, .r_bracket => return p.failExpected(.r_brace),
25022520 // Likely just a missing comma; give error but continue parsing.
25032521 else => try p.warnExpected(.comma),
......@@ -2555,7 +2573,10 @@ const Parser = struct {
25552573 const identifier = try p.expectToken(.identifier);
25562574 switch (p.token_tags[p.tok_i]) {
25572575 .comma => p.tok_i += 1,
2558 .r_brace => { p.tok_i += 1; break; },
2576 .r_brace => {
2577 p.tok_i += 1;
2578 break;
2579 },
25592580 .colon, .r_paren, .r_bracket => return p.failExpected(.r_brace),
25602581 // Likely just a missing comma; give error but continue parsing.
25612582 else => try p.warnExpected(.comma),
......@@ -2992,14 +3013,14 @@ const Parser = struct {
29923013 _ = try p.parsePtrPayload();
29933014
29943015 const items = p.scratch.items[scratch_top..];
2995 switch(items.len) {
3016 switch (items.len) {
29963017 0 => return p.addNode(.{
29973018 .tag = .switch_case_one,
29983019 .main_token = arrow_token,
29993020 .data = .{
30003021 .lhs = 0,
30013022 .rhs = try p.expectAssignExpr(),
3002 }
3023 },
30033024 }),
30043025 1 => return p.addNode(.{
30053026 .tag = .switch_case_one,
......@@ -3007,7 +3028,7 @@ const Parser = struct {
30073028 .data = .{
30083029 .lhs = items[0],
30093030 .rhs = try p.expectAssignExpr(),
3010 }
3031 },
30113032 }),
30123033 else => return p.addNode(.{
30133034 .tag = .switch_case,
......@@ -3375,7 +3396,10 @@ const Parser = struct {
33753396 }
33763397 switch (p.token_tags[p.tok_i]) {
33773398 .comma => p.tok_i += 1,
3378 .r_paren => { p.tok_i += 1; break; },
3399 .r_paren => {
3400 p.tok_i += 1;
3401 break;
3402 },
33793403 .colon, .r_brace, .r_bracket => return p.failExpected(.r_paren),
33803404 // Likely just a missing comma; give error but continue parsing.
33813405 else => try p.warnExpected(.comma),
......@@ -3444,7 +3468,10 @@ const Parser = struct {
34443468 try p.scratch.append(p.gpa, param);
34453469 switch (p.token_tags[p.tok_i]) {
34463470 .comma => p.tok_i += 1,
3447 .r_paren => { p.tok_i += 1; break; },
3471 .r_paren => {
3472 p.tok_i += 1;
3473 break;
3474 },
34483475 // Likely just a missing comma; give error but continue parsing.
34493476 else => try p.warnExpected(.comma),
34503477 }
test/tests.zig+2-5
......@@ -107,7 +107,6 @@ const test_targets = blk: {
107107 .link_libc = true,
108108 },
109109
110
111110 TestTarget{
112111 .target = .{
113112 .cpu_arch = .aarch64,
......@@ -228,7 +227,6 @@ const test_targets = blk: {
228227 .link_libc = true,
229228 },
230229
231
232230 TestTarget{
233231 .target = .{
234232 .cpu_arch = .riscv64,
......@@ -656,7 +654,7 @@ pub const StackTracesContext = struct {
656654 const b = self.b;
657655 const src_basename = "source.zig";
658656 const write_src = b.addWriteFile(src_basename, source);
659 const exe = b.addExecutableSource("test", write_src.getFileSource(src_basename).?);
657 const exe = b.addExecutableSource("test", write_src.getFileSource(src_basename).?);
660658 exe.setBuildMode(mode);
661659
662660 const run_and_compare = RunAndCompareStep.create(
......@@ -670,7 +668,6 @@ pub const StackTracesContext = struct {
670668 self.step.dependOn(&run_and_compare.step);
671669 }
672670
673
674671 const RunAndCompareStep = struct {
675672 pub const base_id = .custom;
676673
......@@ -1376,4 +1373,4 @@ fn printInvocation(args: []const []const u8) void {
13761373 warn("{s} ", .{arg});
13771374 }
13781375 warn("\n", .{});
1379}
\ No newline at end of file
1376}