authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2022-02-10 23:56:09-07:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2022-02-12 11:18:23+01:00
logba31a9469f48065c9ebf935160faffd0f6c9bfdc
tree4954ac369623951c5390ab9e2da0e089592f8a4c
parentb92e1ab8ccf4e450467dfd5ee8ff9ea87c148c26

Sema: int casting to u0 returns const value

Also shift left with u0 rhs returns lhs even when lhs is runtime known.

1 files changed, 16 insertions(+), 12 deletions(-)

src/Sema.zig+16-12
......@@ -5977,8 +5977,13 @@ fn zirIntCast(sema: *Sema, block: *Block, inst: Zir.Inst.Index) CompileError!Air
59775977 return sema.fail(block, src, "unable to cast runtime value to 'comptime_int'", .{});
59785978 }
59795979
5980 try sema.requireRuntimeBlock(block, operand_src);
59815980 // TODO insert safety check to make sure the value fits in the dest type
5981
5982 if ((try sema.typeHasOnePossibleValue(block, dest_ty_src, dest_ty))) |opv| {
5983 return sema.addConstant(dest_ty, opv);
5984 }
5985
5986 try sema.requireRuntimeBlock(block, operand_src);
59825987 return block.addTyOp(.intcast, dest_ty, operand);
59835988}
59845989
......@@ -7537,17 +7542,21 @@ fn zirShl(
75377542 const maybe_lhs_val = try sema.resolveMaybeUndefVal(block, lhs_src, lhs);
75387543 const maybe_rhs_val = try sema.resolveMaybeUndefVal(block, rhs_src, rhs);
75397544
7545 if (maybe_rhs_val) |rhs_val| {
7546 if (rhs_val.isUndef()) {
7547 return sema.addConstUndef(sema.typeOf(lhs));
7548 }
7549 if (rhs_val.compareWithZero(.eq)) {
7550 return lhs;
7551 }
7552 }
7553
75407554 const runtime_src = if (maybe_lhs_val) |lhs_val| rs: {
75417555 const lhs_ty = sema.typeOf(lhs);
75427556
75437557 if (lhs_val.isUndef()) return sema.addConstUndef(lhs_ty);
75447558 const rhs_val = maybe_rhs_val orelse break :rs rhs_src;
7545 if (rhs_val.isUndef()) return sema.addConstUndef(lhs_ty);
75467559
7547 // If rhs is 0, return lhs without doing any calculations.
7548 if (rhs_val.compareWithZero(.eq)) {
7549 return sema.addConstant(lhs_ty, lhs_val);
7550 }
75517560 const target = sema.mod.getTarget();
75527561 const val = switch (air_tag) {
75537562 .shl_exact => val: {
......@@ -7577,12 +7586,7 @@ fn zirShl(
75777586 };
75787587
75797588 return sema.addConstant(lhs_ty, val);
7580 } else rs: {
7581 if (maybe_rhs_val) |rhs_val| {
7582 if (rhs_val.isUndef()) return sema.addConstUndef(sema.typeOf(lhs));
7583 }
7584 break :rs lhs_src;
7585 };
7589 } else lhs_src;
75867590
75877591 // TODO: insert runtime safety check for shl_exact
75887592