Commit be69e8e871d26973c644cfad5225ae9e337179c9 | zig

author	LeRoyce Pearson <leroycepearson@geemili.xyz> 2020-04-30 19:54:40-06:00
committer	Andrew Kelley <andrew@ziglang.org> 2020-05-25 13:48:43-04:00
log	be69e8e871d26973c644cfad5225ae9e337179c9
tree	d5ebab60fa48be4ff42705731de16d561e80c16d
parent	e6a37ed94193faf6450a0888c23168a83e914955

Remove non-null assertion in `CacheHash.release()`

People using the API as intended would never trigger this assertion
anyway, but if someone has a non standard use case, I see no reason
to make the program panic.

1 files changed, 5 insertions(+), 5 deletions(-)

lib
- std
  - cache_hash.zig

lib/std/cache_hash.zig+5-5

 @@ -349,14 +349,14 @@ pub const CacheHash = struct {
     /// Writing to the manifest file is the only way that this file can return an
     /// error.
     pub fn release(self: *@This()) !void {
-        debug.assert(self.manifest_file != null);
+        if (self.manifest_file) |file| {
+            if (self.manifest_dirty) {
+                try self.write_manifest();
+            }
-        if (self.manifest_dirty) {
+            file.close();
-            try self.write_manifest();
         }
-        self.manifest_file.?.close();
         for (self.files.items) |*file| {
             file.deinit(self.alloc);
         }