authorgravatar for ziga.zeljko@gmail.comzigazeljko <ziga.zeljko@gmail.com> 2020-06-03 01:58:30+08:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2020-07-27 19:51:58+00:00
logbf273b7aec8fe9957967c635bd01b2b92909b192
tree600bd4b6275ccd92ad99189d3934a181dbda115a
parentfb9d5529dad8356de51f09da5da5f36c8fd8bf9c

Add comment explaining --stack-first option

1 files changed, 4 insertions(+), 0 deletions(-)

src/link.cpp+4
...@@ -2107,6 +2107,10 @@ static void construct_linker_job_wasm(LinkJob *lj) {...@@ -2107,6 +2107,10 @@ static void construct_linker_job_wasm(LinkJob *lj) {
2107 lj->args.append("-z");2107 lj->args.append("-z");
2108 lj->args.append(buf_ptr(buf_sprintf("stack-size=%" ZIG_PRI_usize, stack_size)));2108 lj->args.append(buf_ptr(buf_sprintf("stack-size=%" ZIG_PRI_usize, stack_size)));
21092109
2110 // put stack before globals so that stack overflow results in segfault immediately before corrupting globals
2111 // see https://github.com/ziglang/zig/issues/4496
2112 lj->args.append("--stack-first");
2113
2110 if (g->out_type != OutTypeExe) {2114 if (g->out_type != OutTypeExe) {
2111 lj->args.append("--no-entry"); // So lld doesn't look for _start.2115 lj->args.append("--no-entry"); // So lld doesn't look for _start.
21122116