Commit cbed6bb08555222008e87cfb071adeed97b3f8a4 | zig

author	Jacob Young <jacobly@ziglang.org> 2022-11-03 02:42:18-04:00
committer	Andrew Kelley <andrew@ziglang.org> 2022-11-04 00:00:10-04:00
log	cbed6bb08555222008e87cfb071adeed97b3f8a4
tree	e5824a89f3f037909cfceae8fee7b8bfc765af70
parent	42755a1944f4c4a60fc7e5e66cf76e9cbdf1ce84

Sema: make `InferredErrorSet` deterministic

Empirically, this `AutoHashMapUnmanaged` -> `AutoArrayHashMapUnmanaged`
change fixes all non-determinism in `ReleaseFast` build artifacts.

Closes #12183

2 files changed, 3 insertions(+), 7 deletions(-)

src
- Module.zig
- Sema.zig

src/Module.zig+1-1

...	@@ -1578,7 +1578,7 @@ pub const Fn = struct {	...	@@ -1578,7 +1578,7 @@ pub const Fn = struct {
1578	errors: ErrorSet.NameMap = .{},	1578	errors: ErrorSet.NameMap = .{},
1579		1579
1580	/// Other inferred error sets which this inferred error set should include.	1580	/// Other inferred error sets which this inferred error set should include.
1581	inferred_error_sets: std.AutoHashMapUnmanaged(*InferredErrorSet, void) = .{},	1581	inferred_error_sets: std.AutoArrayHashMapUnmanaged(*InferredErrorSet, void) = .{},
1582		1582
1583	/// Whether the function returned anyerror. This is true if either of	1583	/// Whether the function returned anyerror. This is true if either of
1584	/// the dependent functions returns anyerror.	1584	/// the dependent functions returns anyerror.

src/Sema.zig+2-6

 @@ -27509,9 +27509,7 @@ fn analyzeIsNonErrComptimeOnly(
                 // Try to avoid resolving inferred error set if possible.
                 if (ies.errors.count() != 0) break :blk;
                 if (ies.is_anyerror) break :blk;
-                var it = ies.inferred_error_sets.keyIterator();
+                for (ies.inferred_error_sets.keys()) |other_ies| {
-                while (it.next()) |other_error_set_ptr| {
-                    const other_ies: *Module.Fn.InferredErrorSet = other_error_set_ptr.*;
                     if (ies == other_ies) continue;
                     try sema.resolveInferredErrorSet(block, src, other_ies);
                     if (other_ies.is_anyerror) {
 @@ -29432,9 +29430,7 @@ fn resolveInferredErrorSet(
     ies.is_resolved = true;
-    var it = ies.inferred_error_sets.keyIterator();
+    for (ies.inferred_error_sets.keys()) |other_ies| {
-    while (it.next()) |other_error_set_ptr| {
-        const other_ies: *Module.Fn.InferredErrorSet = other_error_set_ptr.*;
         if (ies == other_ies) continue;
         try sema.resolveInferredErrorSet(block, src, other_ies);