Commit cc15c8ae7e0b8d994e818f8275bf73617edefe68 | zig

author	Mason Remaley <mason@gamesbymason.com> 2026-04-07 16:35:10-07:00
committer	Mason Remaley <mason@gamesbymason.com> 2026-04-12 04:01:29-07:00
log	cc15c8ae7e0b8d994e818f8275bf73617edefe68
tree	3fe340d8a4c396c9c57e1b4362a0f77895933944
parent	fa26ab6fa36a5f8d2a6cf11063d42519854d008c

Cleans up binary annotation opcodes that we don't handle

1 files changed, 13 insertions(+), 8 deletions(-)

lib
- std
  - debug
    Pdb.zig

lib/std/debug/Pdb.zig+13-8

 @@ -357,8 +357,8 @@ pub const BinaryAnnotation = union(enum) {
                     .change_file => |file_id| {
                         self.curr.file_id = file_id;
                     },
-                    // LLVM never emits this opcode, but it's clear enough how to interpret it so we may as
+                    // LLVM never emits this opcode, but it's clear enough how to interpret it so we
-                    // well in case they use it in the future
+                    // may as well in case they use it in the future
                     .change_code_length_and_code_offset => |info| {
                         self.curr.code_length = info.length;
                         self.curr.code_offset += info.delta;
 @@ -371,21 +371,24 @@ pub const BinaryAnnotation = union(enum) {
                         self.curr.line_offset += info.line_delta;
                     },
-                    // Not emitted by LLVM at the time of writing, but if we get it from elsewhere it should
+                    // Not emitted by LLVM at the time of writing, and we don't want to add support
-                    // be safe to ignore since we don't use this info. Theoretically we could use column
+                    // without a test csae. Safe to ignore since we don't use this info right now.
-                    // info if it was present, but it's not easy to test since LLVM doesn't output it.
                     .change_line_end_delta,
                     .change_column_start,
                     .change_column_end_delta,
                     .change_column_end,
                      => {},
-                     // Not emitted by LLVM at the time of writing. Various sources conflict on how these
+                     // Not emitted by LLVM at the time of writing. Various sources conflict on how
-                     // instructions should be interpreted, so we make no attempt to handle them.
+                     // these opcodes should be interpreted, so we make no attempt to handle them.
                     .code_offset,
                     .change_code_offset_base,
                     .change_range_kind,
-                    => @panic("unimplemented"),
+                    => {
+                       self.annotations = .empty;
+                       self.prev = null;
+                       return null;
+                    },
                 }
                 switch (annotation) {
 @@ -433,6 +436,8 @@ pub const BinaryAnnotation = union(enum) {
     pub const Iterator = struct {
         reader: Io.Reader,
+        pub const empty: Iterator = .{ .reader = .ending_instance };
         pub fn next(self: *Iterator) error{InvalidDebugInfo}!?BinaryAnnotation {
             return take(&self.reader) catch |err| switch (err) {
                 error.ReadFailed => return error.InvalidDebugInfo,