| author |  Matthew Lugg <mlugg@mlugg.co.uk> 2026-08-11 09:29:14+01:00 |
| committer | Matthew Lugg <mlugg@mlugg.co.uk> 2026-08-11 09:33:35+01:00 |
| log | cecc3e1b917b1c6c5793b6c98783b67239b17682 |
| tree | af9b4c8944a9260fe9bfca37d739a3176c34fdce |
| parent | a6420d9985eeb325f302a1252d32dc30f89f40ee |
| signature |  Commit is signed but in an unrecognized format. |
incr-check: restore stderr printing logic
Jacob just hit this confusing panic while working on DWARF stuff. I'm
not sure how this was regressed---the code prior to build system rework
already handled this case correctly by `break`ing to code after the
loop, which was written specifically to handle this case. All we need to
do is restore that `break`, and everything works again.1 files changed, 1 insertions(+), 3 deletions(-)
tools
tools/incr-check.zig+1-3
| ... | ... | @@ -316,9 +316,7 @@ const Eval = struct { |
| 316 | 316 | while (true) { |
| 317 | 317 | const header = client.receiveMessageWithMultiReader(mr, .none) catch |err| switch (err) { |
| 318 | 318 | error.Timeout => unreachable, |
| 319 | // If this panic triggers it might be helpful to rework this | |
| 320 | // code to print the stderr from the abnormally terminated child. | |
| 321 | error.EndOfStream => @panic("unexpected mid-message end of stream"), | |
| 319 | error.EndOfStream => break, | |
| 322 | 320 | else => |e| return e, |
| 323 | 321 | }; |
| 324 | 322 | const body = client.in.take(header.bytes_len) catch unreachable; |