Commit d2585e68a79b8e43166e797d6adc33282acac046 | zig

author	Andrew Kelley <andrew@ziglang.org> 2026-01-15 13:48:27-08:00
committer	Andrew Kelley <andrew@ziglang.org> 2026-01-15 14:18:21-08:00
log	d2585e68a79b8e43166e797d6adc33282acac046
tree	9f5f630e1db7f3fb8a800874b0ecb9e97e20c43b
parent	de347dd6a981151609f1b9e79183d3f44046abc0

std.Io.Threaded: use NtExtendSection in fileMemoryMapSetLength

is this a good idea? not sure yet. reverting in the next commit

2 files changed, 42 insertions(+), 20 deletions(-)

lib
- std
  - Io
    Threaded.zig
  - os
    windows
    ntdll.zig

lib/std/Io/Threaded.zig+37-20

 @@ -16279,6 +16279,8 @@ fn createFileMap(
             .SUCCESS => {},
             .CONFLICTING_ADDRESSES => return error.MappingAlreadyExists,
             .SECTION_PROTECTION => return error.PermissionDenied,
+            .ACCESS_DENIED => return error.AccessDenied,
+            .INVALID_VIEW_SIZE => |status| return windows.statusBug(status),
             else => |status| return windows.unexpectedStatus(status),
         }
         if (builtin.mode == .Debug) {
 @@ -16392,32 +16394,47 @@ fn fileMemoryMapSetLength(
     const new_len = options.len;
     if (mm.section) |section| {
-        if (alignment.forward(new_len) == alignment.forward(old_memory.len)) {
+        const aligned_old_len = alignment.forward(old_memory.len);
+        const aligned_new_len = alignment.forward(new_len);
+        if (aligned_new_len == aligned_old_len) {
             mm.memory.len = new_len;
             return;
         }
         switch (native_os) {
             .windows => {
-                var contents_ptr: ?[*]align(page_align) u8 = null;
+                if (aligned_new_len > aligned_old_len) {
-                var contents_len = new_len;
+                    var new_section_size: windows.LARGE_INTEGER = @intCast(aligned_new_len);
-                switch (windows.ntdll.NtMapViewOfSection(
+                    switch (windows.ntdll.NtExtendSection(section, &new_section_size)) {
-                    section,
+                        .SUCCESS => {},
-                    windows.current_process,
+                        else => |status| return windows.unexpectedStatus(status),
-                    @ptrCast(&contents_ptr),
+                    }
-                    null,
+                    assert(new_section_size == aligned_new_len);
-                    0,
+                    mm.memory.len = new_len;
-                    null,
+                } else {
-                    &contents_len,
+                    _ = windows.ntdll.NtUnmapViewOfSection(windows.current_process, old_memory.ptr);
-                    .Unmap,
+                    windows.CloseHandle(section);
-                    .{},
+                    var contents_len = aligned_new_len;
-                    .{ .READWRITE = true },
+                    var contents_ptr: ?[*]align(std.heap.page_size_min) u8 = null;
-                )) {
+                    switch (windows.ntdll.NtMapViewOfSection(
-                    .SUCCESS => {},
+                        section,
-                    .SECTION_PROTECTION => return error.PermissionDenied,
+                        windows.current_process,
-                    else => |status| return windows.unexpectedStatus(status),
+                        @ptrCast(&contents_ptr),
+                        null,
+                        0,
+                        null,
+                        &contents_len,
+                        .Unmap,
+                        .{},
+                        .{ .READWRITE = true },
+                    )) {
+                        .SUCCESS => {},
+                        .SECTION_PROTECTION => return error.PermissionDenied,
+                        .INVALID_VIEW_SIZE => |status| return windows.statusBug(status),
+                        else => |status| return windows.unexpectedStatus(status),
+                    }
+                    assert(contents_len == aligned_new_len);
+                    mm.memory = contents_ptr.?[0..new_len];
                 }
-                assert(contents_len == alignment.forward(new_len));
-                mm.memory = contents_ptr.?[0..new_len];
             },
             .wasi => unreachable,
             .linux => {

lib/std/os/windows/ntdll.zig+5

 @@ -253,6 +253,11 @@ pub extern "ntdll" fn NtCreateSection(
     FileHandle: ?HANDLE,
 ) callconv(.winapi) NTSTATUS;
+pub extern "ntdll" fn NtExtendSection(
+    SectionHandle: HANDLE,
+    NewSectionSize: *LARGE_INTEGER,
+) callconv(.winapi) NTSTATUS;
 pub extern "ntdll" fn NtAllocateVirtualMemory(
     ProcessHandle: HANDLE,
     BaseAddress: *PVOID,