| author |  Andrew Kelley <andrew@ziglang.org> 2021-11-29 13:21:36-07:00 |
| committer | Andrew Kelley <andrew@ziglang.org> 2021-11-29 13:21:36-07:00 |
| log | d3426ce634a09ec289480510040b3decfbd38c39 |
| tree | 7fe7bab9732fdd08b5b87cf96cd2d5a376d367fb |
| parent | b613210140f649b11232fae8bad16867d122d0cb |
AstGen: require binary operations to have reachable operands
2 files changed, 8 insertions(+), 3 deletions(-)
src
src/AstGen.zig+2-2
| ... | @@ -4781,8 +4781,8 @@ fn simpleBinOp( | ... | @@ -4781,8 +4781,8 @@ fn simpleBinOp( |
| 4781 | const node_datas = tree.nodes.items(.data); | 4781 | const node_datas = tree.nodes.items(.data); |
| 4782 | 4782 | ||
| 4783 | const result = try gz.addPlNode(op_inst_tag, node, Zir.Inst.Bin{ | 4783 | const result = try gz.addPlNode(op_inst_tag, node, Zir.Inst.Bin{ |
| 4784 | .lhs = try expr(gz, scope, .none, node_datas[node].lhs), | 4784 | .lhs = try reachableExpr(gz, scope, .none, node_datas[node].lhs, node), |
| 4785 | .rhs = try expr(gz, scope, .none, node_datas[node].rhs), | 4785 | .rhs = try reachableExpr(gz, scope, .none, node_datas[node].rhs, node), |
| 4786 | }); | 4786 | }); |
| 4787 | return rvalue(gz, rl, result, node); | 4787 | return rvalue(gz, rl, result, node); |
| 4788 | } | 4788 | } |
test/compile_errors.zig+6-1
| ... | @@ -5033,13 +5033,18 @@ pub fn addCases(ctx: *TestContext) !void { | ... | @@ -5033,13 +5033,18 @@ pub fn addCases(ctx: *TestContext) !void { |
| 5033 | "tmp.zig:2:5: note: control flow is diverted here", | 5033 | "tmp.zig:2:5: note: control flow is diverted here", |
| 5034 | }); | 5034 | }); |
| 5035 | 5035 | ||
| 5036 | ctx.objErrStage1("unreachable code - return return", | 5036 | ctx.objErrStage1("unreachable code - multiple things", |
| 5037 | \\export fn a() i32 { | 5037 | \\export fn a() i32 { |
| 5038 | \\ return return 1; | 5038 | \\ return return 1; |
| 5039 | \\} | 5039 | \\} |
| 5040 | \\export fn b(value: u32) bool { | ||
| 5041 | \\ return 1 < value < 1000; | ||
| 5042 | \\} | ||
| 5040 | , &[_][]const u8{ | 5043 | , &[_][]const u8{ |
| 5041 | "tmp.zig:2:5: error: unreachable code", | 5044 | "tmp.zig:2:5: error: unreachable code", |
| 5042 | "tmp.zig:2:12: note: control flow is diverted here", | 5045 | "tmp.zig:2:12: note: control flow is diverted here", |
| 5046 | "tmp.zig:5:22: error: unreachable code", | ||
| 5047 | "tmp.zig:5:5: note: control flow is diverted here", | ||
| 5043 | }); | 5048 | }); |
| 5044 | 5049 | ||
| 5045 | ctx.objErrStage1("bad import", | 5050 | ctx.objErrStage1("bad import", |