| author |  Andrew Kelley <andrew@ziglang.org> 2015-12-05 21:04:57-07:00 |
| committer | Andrew Kelley <andrew@ziglang.org> 2015-12-05 21:08:20-07:00 |
| log | daa3b6bfa32e3be1c434b20ba91f6a519304c81c |
| tree | 2ffcd73c18ff37b7b6b46148511ffbe92d03ae12 |
| parent | f49e857b9b0063744e9df9481ef7fdef313c56d3 |
add unused label error
4 files changed, 24 insertions(+), 2 deletions(-)
README.md-2
| ... | ... | @@ -42,8 +42,6 @@ make |
| 42 | 42 | |
| 43 | 43 | ## Roadmap |
| 44 | 44 | |
| 45 | * parseh: unreachable <--> noreturn attribute | |
| 46 | * unused label error | |
| 47 | 45 | * loops |
| 48 | 46 | * structs |
| 49 | 47 | * tagged enums |
src/analyze.cpp+18
| ... | ... | @@ -471,6 +471,7 @@ static TypeTableEntry * analyze_expression(CodeGen *g, ImportTableEntry *import, |
| 471 | 471 | assert(!node->codegen_node); |
| 472 | 472 | node->codegen_node = allocate<CodeGenNode>(1); |
| 473 | 473 | node->codegen_node->data.label_entry = table_entry->value; |
| 474 | table_entry->value->used = true; | |
| 474 | 475 | } else { |
| 475 | 476 | add_node_error(g, node, |
| 476 | 477 | buf_sprintf("use of undeclared label '%s'", buf_ptr(&node->data.go_to.name))); |
| ... | ... | @@ -758,6 +759,23 @@ static void analyze_top_level_declaration(CodeGen *g, ImportTableEntry *import, |
| 758 | 759 | node->codegen_node = allocate<CodeGenNode>(1); |
| 759 | 760 | node->codegen_node->data.fn_def_node.implicit_return_type = block_return_type; |
| 760 | 761 | node->codegen_node->data.fn_def_node.block_context = context; |
| 762 | ||
| 763 | { | |
| 764 | FnTableEntry *fn_table_entry = fn_proto_node->codegen_node->data.fn_proto_node.fn_table_entry; | |
| 765 | auto it = fn_table_entry->label_table.entry_iterator(); | |
| 766 | for (;;) { | |
| 767 | auto *entry = it.next(); | |
| 768 | if (!entry) | |
| 769 | break; | |
| 770 | ||
| 771 | LabelTableEntry *label_entry = entry->value; | |
| 772 | if (!label_entry->used) { | |
| 773 | add_node_error(g, label_entry->label_node, | |
| 774 | buf_sprintf("label '%s' defined but not used", | |
| 775 | buf_ptr(&label_entry->label_node->data.label.name))); | |
| 776 | } | |
| 777 | } | |
| 778 | } | |
| 761 | 779 | } |
| 762 | 780 | break; |
| 763 | 781 |
src/semantic_info.hpp+1
| ... | ... | @@ -41,6 +41,7 @@ struct ImportTableEntry { |
| 41 | 41 | struct LabelTableEntry { |
| 42 | 42 | AstNode *label_node; |
| 43 | 43 | LLVMBasicBlockRef basic_block; |
| 44 | bool used; | |
| 44 | 45 | }; |
| 45 | 46 | |
| 46 | 47 | struct FnTableEntry { |
test/run_tests.cpp+5
| ... | ... | @@ -466,6 +466,11 @@ fn f(a : unreachable) {} |
| 466 | 466 | export fn f(a : void) {} |
| 467 | 467 | )SOURCE", 1, ".tmp_source.zig:2:17: error: parameter of type 'void' not allowed on exported functions"); |
| 468 | 468 | |
| 469 | add_compile_fail_case("unused label", R"SOURCE( | |
| 470 | export fn f() { | |
| 471 | a_label: | |
| 472 | } | |
| 473 | )SOURCE", 1, ".tmp_source.zig:3:1: error: label 'a_label' defined but not used"); | |
| 469 | 474 | } |
| 470 | 475 | |
| 471 | 476 | static void print_compiler_invocation(TestCase *test_case, Buf *zig_stderr) { |