Commit dc98009e36a344f8d0330af6b9e9226a2ba6a474 | zig

author	Jakub Konka <kubkon@jakubkonka.com> 2023-03-21 16:12:25+01:00
committer	Jakub Konka <kubkon@jakubkonka.com> 2023-03-21 16:12:25+01:00
log	dc98009e36a344f8d0330af6b9e9226a2ba6a474
tree	ebb3a22b96a6cc9bafba13ca73fe83dce023da6b
parent	cb34d6f4362c8f5d806c0d0b328ea29e877d5c5f

macho+zld: save all defined globals in the export trie

1 files changed, 11 insertions(+), 28 deletions(-)

src
- link
  - MachO
    zld.zig

src/link/MachO/zld.zig+11-28

 @@ -2141,35 +2141,18 @@ pub const Zld = struct {
         const exec_segment = self.segments.items[segment_index];
         const base_address = exec_segment.vmaddr;
-        if (self.options.output_mode == .Exe) {
+        for (self.globals.items) |global| {
-            for (&[_]SymbolWithLoc{
+            const sym = self.getSymbol(global);
-                self.getEntryPoint(),
+            if (sym.undf()) continue;
-                self.globals.items[self.mh_execute_header_index.?],
+            if (sym.n_desc == N_DEAD) continue;
-            }) |global| {
-                const sym = self.getSymbol(global);
-                const sym_name = self.getSymbolName(global);
-                log.debug("  (putting '{s}' defined at 0x{x})", .{ sym_name, sym.n_value });
-                try trie.put(gpa, .{
-                    .name = sym_name,
-                    .vmaddr_offset = sym.n_value - base_address,
-                    .export_flags = macho.EXPORT_SYMBOL_FLAGS_KIND_REGULAR,
-                });
-            }
-        } else {
-            assert(self.options.output_mode == .Lib);
-            for (self.globals.items) |global| {
-                const sym = self.getSymbol(global);
-                if (sym.undf()) continue;
-                if (sym.n_desc == N_DEAD) continue;
-                const sym_name = self.getSymbolName(global);
+            const sym_name = self.getSymbolName(global);
-                log.debug("  (putting '{s}' defined at 0x{x})", .{ sym_name, sym.n_value });
+            log.debug("  (putting '{s}' defined at 0x{x})", .{ sym_name, sym.n_value });
-                try trie.put(gpa, .{
+            try trie.put(gpa, .{
-                    .name = sym_name,
+                .name = sym_name,
-                    .vmaddr_offset = sym.n_value - base_address,
+                .vmaddr_offset = sym.n_value - base_address,
-                    .export_flags = macho.EXPORT_SYMBOL_FLAGS_KIND_REGULAR,
+                .export_flags = macho.EXPORT_SYMBOL_FLAGS_KIND_REGULAR,
-                });
+            });
-            }
         }
         try trie.finalize(gpa);