authorgravatar for r00ster91@proton.meWooster <r00ster91@proton.me> 2023-04-29 02:12:42+02:00
committergravatar for git@vexu.euVeikka Tuominen <git@vexu.eu> 2023-04-29 14:28:36+03:00
logdff6efe3697581beffa2604f68900768da5c0297
tree07d96f941d5deff564c18bddabd5b8dff535c7ea
parent05f9608115a48fb7312ebf38c1240ae10b770c88

Sema: disallow indexing non-tuple struct

Fixes #15497

2 files changed, 18 insertions(+), 1 deletions(-)

src/Sema.zig+7-1
......@@ -24597,10 +24597,15 @@ fn elemPtr(
2459724597 const indexable_ptr_src = src; // TODO better source location
2459824598 const indexable_ptr_ty = sema.typeOf(indexable_ptr);
2459924599 const target = sema.mod.getTarget();
24600
2460024601 const indexable_ty = switch (indexable_ptr_ty.zigTypeTag()) {
2460124602 .Pointer => indexable_ptr_ty.elemType(),
2460224603 else => return sema.fail(block, indexable_ptr_src, "expected pointer, found '{}'", .{indexable_ptr_ty.fmt(sema.mod)}),
2460324604 };
24605 if (!indexable_ty.isIndexable()) {
24606 return sema.fail(block, src, "element access of non-indexable type '{}'", .{indexable_ty.fmt(sema.mod)});
24607 }
24608
2460424609 switch (indexable_ty.zigTypeTag()) {
2460524610 .Array, .Vector => return sema.elemPtrArray(block, src, indexable_ptr_src, indexable_ptr, elem_index_src, elem_index, init, oob_safety),
2460624611 .Struct => {
......@@ -24629,10 +24634,11 @@ fn elemPtrOneLayerOnly(
2462924634) CompileError!Air.Inst.Ref {
2463024635 const indexable_src = src; // TODO better source location
2463124636 const indexable_ty = sema.typeOf(indexable);
24637 const target = sema.mod.getTarget();
24638
2463224639 if (!indexable_ty.isIndexable()) {
2463324640 return sema.fail(block, src, "element access of non-indexable type '{}'", .{indexable_ty.fmt(sema.mod)});
2463424641 }
24635 const target = sema.mod.getTarget();
2463624642
2463724643 switch (indexable_ty.ptrSize()) {
2463824644 .Slice => return sema.elemPtrSlice(block, src, indexable_src, indexable, elem_index_src, elem_index, oob_safety),
test/cases/compile_errors/indexing_non-tuple_struct.zig created+11
......@@ -0,0 +1,11 @@
1export fn a() void {
2 const S = struct { x: i32, y: i32 };
3 var s: S = undefined;
4 s[0] = 10;
5}
6
7// error
8// backend=stage2
9// target=native
10//
11// :4:6: error: element access of non-indexable type 'tmp.a.S'