authorgravatar for alex@alexrp.comAlex Rønne Petersen <alex@alexrp.com> 2025-11-17 16:31:44+01:00
committergravatar for alex@alexrp.comAlex Rønne Petersen <alex@alexrp.com> 2025-11-19 01:42:45+01:00
loge09ba67161738e2fad2e699b27f9772a35dfdc16
treedd44d80d26ef2915ecb8d88d959f1992e12248ca
parent092299036705eb597f6c9c3c1cb9939d5fb9d131
signaturebadge-check Signed by SSH key SHA256:7B/LJ7bpR1eX8aCXSr4mtd5M45VMPKcx9zY8e95b5QM

std.Build.Step.Run: read/write messages as little endian


1 files changed, 44 insertions(+), 31 deletions(-)

lib/std/Build/Step/Run.zig+44-31
......@@ -1927,6 +1927,7 @@ fn pollZigTest(
19271927 .ns_elapsed = if (timer) |*t| t.read() else 0,
19281928 } };
19291929 const body = stdout.take(header.bytes_len) catch unreachable;
1930 var body_r: std.Io.Reader = .fixed(body);
19301931 switch (header.tag) {
19311932 .zig_version => {
19321933 if (!std.mem.eql(u8, builtin.zig_version_string, body)) return run.step.fail(
......@@ -1942,29 +1943,23 @@ fn pollZigTest(
19421943 // restart the test runner).
19431944 assert(opt_metadata.* == null);
19441945
1945 const TmHdr = std.zig.Server.Message.TestMetadata;
1946 const tm_hdr: *align(1) const TmHdr = @ptrCast(body);
1946 const tm_hdr = body_r.takeStruct(std.zig.Server.Message.TestMetadata, .little) catch unreachable;
19471947 results.test_count = tm_hdr.tests_len;
19481948
1949 const names_bytes = body[@sizeOf(TmHdr)..][0 .. results.test_count * @sizeOf(u32)];
1950 const expected_panic_msgs_bytes = body[@sizeOf(TmHdr) + names_bytes.len ..][0 .. results.test_count * @sizeOf(u32)];
1951 const string_bytes = body[@sizeOf(TmHdr) + names_bytes.len + expected_panic_msgs_bytes.len ..][0..tm_hdr.string_bytes_len];
1949 const names = try arena.alloc(u32, results.test_count);
1950 for (names) |*dest| dest.* = body_r.takeInt(u32, .little) catch unreachable;
19521951
1953 const names = std.mem.bytesAsSlice(u32, names_bytes);
1954 const expected_panic_msgs = std.mem.bytesAsSlice(u32, expected_panic_msgs_bytes);
1952 const expected_panic_msgs = try arena.alloc(u32, results.test_count);
1953 for (expected_panic_msgs) |*dest| dest.* = body_r.takeInt(u32, .little) catch unreachable;
19551954
1956 const names_aligned = try arena.alloc(u32, names.len);
1957 for (names_aligned, names) |*dest, src| dest.* = src;
1958
1959 const expected_panic_msgs_aligned = try arena.alloc(u32, expected_panic_msgs.len);
1960 for (expected_panic_msgs_aligned, expected_panic_msgs) |*dest, src| dest.* = src;
1955 const string_bytes = body_r.take(tm_hdr.string_bytes_len) catch unreachable;
19611956
19621957 options.progress_node.setEstimatedTotalItems(names.len);
19631958 opt_metadata.* = .{
19641959 .string_bytes = try arena.dupe(u8, string_bytes),
19651960 .ns_per_test = try arena.alloc(u64, results.test_count),
1966 .names = names_aligned,
1967 .expected_panic_msgs = expected_panic_msgs_aligned,
1961 .names = names,
1962 .expected_panic_msgs = expected_panic_msgs,
19681963 .next_index = 0,
19691964 .prog_node = options.progress_node,
19701965 };
......@@ -1983,8 +1978,7 @@ fn pollZigTest(
19831978 assert(fuzz_context == null);
19841979 const md = &opt_metadata.*.?;
19851980
1986 const TrHdr = std.zig.Server.Message.TestResults;
1987 const tr_hdr: *align(1) const TrHdr = @ptrCast(body);
1981 const tr_hdr = body_r.takeStruct(std.zig.Server.Message.TestResults, .little) catch unreachable;
19881982 assert(tr_hdr.index == active_test_index);
19891983
19901984 switch (tr_hdr.flags.status) {
......@@ -2026,18 +2020,21 @@ fn pollZigTest(
20262020 requestNextTest(child.stdin.?, md, &sub_prog_node) catch |err| return .{ .write_failed = err };
20272021 },
20282022 .coverage_id => {
2029 const fuzz = fuzz_context.?.fuzz;
2030 const msg_ptr: *align(1) const [4]u64 = @ptrCast(body);
2031 coverage_id = msg_ptr[0];
2023 coverage_id = body_r.takeInt(u64, .little) catch unreachable;
2024 const cumulative_runs = body_r.takeInt(u64, .little) catch unreachable;
2025 const cumulative_unique = body_r.takeInt(u64, .little) catch unreachable;
2026 const cumulative_coverage = body_r.takeInt(u64, .little) catch unreachable;
2027
20322028 {
2029 const fuzz = fuzz_context.?.fuzz;
20332030 fuzz.queue_mutex.lock();
20342031 defer fuzz.queue_mutex.unlock();
20352032 try fuzz.msg_queue.append(fuzz.gpa, .{ .coverage = .{
20362033 .id = coverage_id.?,
20372034 .cumulative = .{
2038 .runs = msg_ptr[1],
2039 .unique = msg_ptr[2],
2040 .coverage = msg_ptr[3],
2035 .runs = cumulative_runs,
2036 .unique = cumulative_unique,
2037 .coverage = cumulative_coverage,
20412038 },
20422039 .run = run,
20432040 } });
......@@ -2046,8 +2043,7 @@ fn pollZigTest(
20462043 },
20472044 .fuzz_start_addr => {
20482045 const fuzz = fuzz_context.?.fuzz;
2049 const msg_ptr: *align(1) const u64 = @ptrCast(body);
2050 const addr = msg_ptr.*;
2046 const addr = body_r.takeInt(u64, .little) catch unreachable;
20512047 {
20522048 fuzz.queue_mutex.lock();
20532049 defer fuzz.queue_mutex.unlock();
......@@ -2116,7 +2112,10 @@ fn sendMessage(file: std.fs.File, tag: std.zig.Client.Message.Tag) !void {
21162112 .tag = tag,
21172113 .bytes_len = 0,
21182114 };
2119 try file.writeAll(@ptrCast(&header));
2115 var w = file.writer(&.{});
2116 w.interface.writeStruct(header, .little) catch |err| switch (err) {
2117 error.WriteFailed => return w.err.?,
2118 };
21202119}
21212120
21222121fn sendRunTestMessage(file: std.fs.File, tag: std.zig.Client.Message.Tag, index: u32) !void {
......@@ -2124,8 +2123,13 @@ fn sendRunTestMessage(file: std.fs.File, tag: std.zig.Client.Message.Tag, index:
21242123 .tag = tag,
21252124 .bytes_len = 4,
21262125 };
2127 const full_msg = std.mem.asBytes(&header) ++ std.mem.asBytes(&index);
2128 try file.writeAll(full_msg);
2126 var w = file.writer(&.{});
2127 w.interface.writeStruct(header, .little) catch |err| switch (err) {
2128 error.WriteFailed => return w.err.?,
2129 };
2130 w.interface.writeInt(u32, index, .little) catch |err| switch (err) {
2131 error.WriteFailed => return w.err.?,
2132 };
21292133}
21302134
21312135fn sendRunFuzzTestMessage(
......@@ -2138,10 +2142,19 @@ fn sendRunFuzzTestMessage(
21382142 .tag = .start_fuzzing,
21392143 .bytes_len = 4 + 1 + 8,
21402144 };
2141 const full_msg = std.mem.asBytes(&header) ++ std.mem.asBytes(&index) ++
2142 std.mem.asBytes(&kind) ++ std.mem.asBytes(&amount_or_instance);
2143
2144 try file.writeAll(full_msg);
2145 var w = file.writer(&.{});
2146 w.interface.writeStruct(header, .little) catch |err| switch (err) {
2147 error.WriteFailed => return w.err.?,
2148 };
2149 w.interface.writeInt(u32, index, .little) catch |err| switch (err) {
2150 error.WriteFailed => return w.err.?,
2151 };
2152 w.interface.writeByte(@intFromEnum(kind)) catch |err| switch (err) {
2153 error.WriteFailed => return w.err.?,
2154 };
2155 w.interface.writeInt(u64, amount_or_instance, .little) catch |err| switch (err) {
2156 error.WriteFailed => return w.err.?,
2157 };
21452158}
21462159
21472160fn evalGeneric(run: *Run, child: *std.process.Child) !EvalGenericResult {