authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2020-04-03 22:31:15-04:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2020-04-03 22:31:15-04:00
loge89c42655cf9851cdf02065bc75cda0e27884966
treeb25e26e53ceda1ac03e65de5d483491ee46e7c0e
parent1568470c44eafb59425c070ea9884b78cc2516b2
parent7a28c644aa8eb3d27dee113338af8278f8f6334f
signaturebadge-question-mark Signed by PGP key 4AEE18F83AFDEB23

Merge pull request #4868 from xackus/new-arraylist-api

new ArrayList API

21 files changed, 185 insertions(+), 161 deletions(-)

lib/std/array_list.zig+114-89
......@@ -20,11 +20,9 @@ pub fn AlignedArrayList(comptime T: type, comptime alignment: ?u29) type {
2020 return struct {
2121 const Self = @This();
2222
23 /// Use `span` instead of slicing this directly, because if you don't
24 /// specify the end position of the slice, this will potentially give
25 /// you uninitialized memory.
23 /// Content of the ArrayList
2624 items: Slice,
27 len: usize,
25 capacity: usize,
2826 allocator: *Allocator,
2927
3028 pub const Slice = if (alignment) |a| ([]align(a) T) else []T;
......@@ -34,7 +32,7 @@ pub fn AlignedArrayList(comptime T: type, comptime alignment: ?u29) type {
3432 pub fn init(allocator: *Allocator) Self {
3533 return Self{
3634 .items = &[_]T{},
37 .len = 0,
35 .capacity = 0,
3836 .allocator = allocator,
3937 };
4038 }
......@@ -49,60 +47,55 @@ pub fn AlignedArrayList(comptime T: type, comptime alignment: ?u29) type {
4947
5048 /// Release all allocated memory.
5149 pub fn deinit(self: Self) void {
52 self.allocator.free(self.items);
50 self.allocator.free(self.allocatedSlice());
5351 }
5452
53 /// Deprecated: use `items` field directly.
5554 /// Return contents as a slice. Only valid while the list
5655 /// doesn't change size.
57 pub fn span(self: var) @TypeOf(self.items[0..self.len]) {
58 return self.items[0..self.len];
56 pub fn span(self: var) @TypeOf(self.items) {
57 return self.items;
5958 }
6059
61 /// Deprecated: use `span`.
60 /// Deprecated: use `items` field directly.
6261 pub fn toSlice(self: Self) Slice {
63 return self.span();
62 return self.items;
6463 }
6564
66 /// Deprecated: use `span`.
65 /// Deprecated: use `items` field directly.
6766 pub fn toSliceConst(self: Self) SliceConst {
68 return self.span();
67 return self.items;
6968 }
7069
71 /// Deprecated: use `span()[i]`.
70 /// Deprecated: use `list.items[i]`.
7271 pub fn at(self: Self, i: usize) T {
73 return self.span()[i];
72 return self.items[i];
7473 }
7574
76 /// Deprecated: use `&span()[i]`.
75 /// Deprecated: use `&list.items[i]`.
7776 pub fn ptrAt(self: Self, i: usize) *T {
78 return &self.span()[i];
77 return &self.items[i];
7978 }
8079
81 /// Deprecated: use `if (i >= list.len) return error.OutOfBounds else span()[i] = item`.
80 /// Deprecated: use `if (i >= list.items.len) return error.OutOfBounds else list.items[i] = item`.
8281 pub fn setOrError(self: Self, i: usize, item: T) !void {
83 if (i >= self.len) return error.OutOfBounds;
82 if (i >= self.items.len) return error.OutOfBounds;
8483 self.items[i] = item;
8584 }
8685
87 /// Deprecated: use `list.span()[i] = item`.
86 /// Deprecated: use `list.items[i] = item`.
8887 pub fn set(self: *Self, i: usize, item: T) void {
89 assert(i < self.len);
88 assert(i < self.items.len);
9089 self.items[i] = item;
9190 }
9291
93 /// Return the maximum number of items the list can hold
94 /// without allocating more memory.
95 pub fn capacity(self: Self) usize {
96 return self.items.len;
97 }
98
9992 /// ArrayList takes ownership of the passed in slice. The slice must have been
10093 /// allocated with `allocator`.
10194 /// Deinitialize with `deinit` or use `toOwnedSlice`.
10295 pub fn fromOwnedSlice(allocator: *Allocator, slice: Slice) Self {
10396 return Self{
10497 .items = slice,
105 .len = slice.len,
98 .capacity = slice.len,
10699 .allocator = allocator,
107100 };
108101 }
......@@ -110,7 +103,7 @@ pub fn AlignedArrayList(comptime T: type, comptime alignment: ?u29) type {
110103 /// The caller owns the returned memory. ArrayList becomes empty.
111104 pub fn toOwnedSlice(self: *Self) Slice {
112105 const allocator = self.allocator;
113 const result = allocator.shrink(self.items, self.len);
106 const result = allocator.shrink(self.allocatedSlice(), self.items.len);
114107 self.* = init(allocator);
115108 return result;
116109 }
......@@ -118,10 +111,10 @@ pub fn AlignedArrayList(comptime T: type, comptime alignment: ?u29) type {
118111 /// Insert `item` at index `n`. Moves `list[n .. list.len]`
119112 /// to make room.
120113 pub fn insert(self: *Self, n: usize, item: T) !void {
121 try self.ensureCapacity(self.len + 1);
122 self.len += 1;
114 try self.ensureCapacity(self.items.len + 1);
115 self.items.len += 1;
123116
124 mem.copyBackwards(T, self.items[n + 1 .. self.len], self.items[n .. self.len - 1]);
117 mem.copyBackwards(T, self.items[n + 1 .. self.items.len], self.items[n .. self.items.len - 1]);
125118 self.items[n] = item;
126119 }
127120
......@@ -129,10 +122,10 @@ pub fn AlignedArrayList(comptime T: type, comptime alignment: ?u29) type {
129122 /// `list[i .. list.len]` to make room.
130123 /// This operation is O(N).
131124 pub fn insertSlice(self: *Self, i: usize, items: SliceConst) !void {
132 try self.ensureCapacity(self.len + items.len);
133 self.len += items.len;
125 try self.ensureCapacity(self.items.len + items.len);
126 self.items.len += items.len;
134127
135 mem.copyBackwards(T, self.items[i + items.len .. self.len], self.items[i .. self.len - items.len]);
128 mem.copyBackwards(T, self.items[i + items.len .. self.items.len], self.items[i .. self.items.len - items.len]);
136129 mem.copy(T, self.items[i .. i + items.len], items);
137130 }
138131
......@@ -153,13 +146,13 @@ pub fn AlignedArrayList(comptime T: type, comptime alignment: ?u29) type {
153146 /// Asserts the array has at least one item.
154147 /// This operation is O(N).
155148 pub fn orderedRemove(self: *Self, i: usize) T {
156 const newlen = self.len - 1;
149 const newlen = self.items.len - 1;
157150 if (newlen == i) return self.pop();
158151
159 const old_item = self.at(i);
152 const old_item = self.items[i];
160153 for (self.items[i..newlen]) |*b, j| b.* = self.items[i + 1 + j];
161154 self.items[newlen] = undefined;
162 self.len = newlen;
155 self.items.len = newlen;
163156 return old_item;
164157 }
165158
......@@ -167,26 +160,28 @@ pub fn AlignedArrayList(comptime T: type, comptime alignment: ?u29) type {
167160 /// The empty slot is filled from the end of the list.
168161 /// This operation is O(1).
169162 pub fn swapRemove(self: *Self, i: usize) T {
170 if (self.len - 1 == i) return self.pop();
163 if (self.items.len - 1 == i) return self.pop();
171164
172 const slice = self.span();
173 const old_item = slice[i];
174 slice[i] = self.pop();
165 const old_item = self.items[i];
166 self.items[i] = self.pop();
175167 return old_item;
176168 }
177169
178 /// Deprecated: use `if (i >= list.len) return error.OutOfBounds else list.swapRemove(i)`.
170 /// Deprecated: use `if (i >= list.items.len) return error.OutOfBounds else list.swapRemove(i)`.
179171 pub fn swapRemoveOrError(self: *Self, i: usize) !T {
180 if (i >= self.len) return error.OutOfBounds;
172 if (i >= self.items.len) return error.OutOfBounds;
181173 return self.swapRemove(i);
182174 }
183175
184176 /// Append the slice of items to the list. Allocates more
185177 /// memory as necessary.
186178 pub fn appendSlice(self: *Self, items: SliceConst) !void {
187 try self.ensureCapacity(self.len + items.len);
188 mem.copy(T, self.items[self.len..], items);
189 self.len += items.len;
179 const oldlen = self.items.len;
180 const newlen = self.items.len + items.len;
181
182 try self.ensureCapacity(newlen);
183 self.items.len = newlen;
184 mem.copy(T, self.items[oldlen..], items);
190185 }
191186
192187 /// Same as `append` except it returns the number of bytes written, which is always the same
......@@ -206,50 +201,58 @@ pub fn AlignedArrayList(comptime T: type, comptime alignment: ?u29) type {
206201 /// Append a value to the list `n` times.
207202 /// Allocates more memory as necessary.
208203 pub fn appendNTimes(self: *Self, value: T, n: usize) !void {
209 const old_len = self.len;
210 try self.resize(self.len + n);
211 mem.set(T, self.items[old_len..self.len], value);
204 const old_len = self.items.len;
205 try self.resize(self.items.len + n);
206 mem.set(T, self.items[old_len..self.items.len], value);
212207 }
213208
214209 /// Adjust the list's length to `new_len`.
215210 /// Does not initialize added items if any.
216211 pub fn resize(self: *Self, new_len: usize) !void {
217212 try self.ensureCapacity(new_len);
218 self.len = new_len;
213 self.items.len = new_len;
219214 }
220215
221216 /// Reduce allocated capacity to `new_len`.
222217 /// Invalidates element pointers.
223218 pub fn shrink(self: *Self, new_len: usize) void {
224 assert(new_len <= self.len);
225 self.len = new_len;
226 self.items = self.allocator.realloc(self.items, new_len) catch |e| switch (e) {
227 error.OutOfMemory => return, // no problem, capacity is still correct then.
219 assert(new_len <= self.items.len);
220
221 self.items = self.allocator.realloc(self.allocatedSlice(), new_len) catch |e| switch (e) {
222 error.OutOfMemory => { // no problem, capacity is still correct then.
223 self.items.len = new_len;
224 return;
225 },
228226 };
227 self.capacity = new_len;
229228 }
230229
231230 pub fn ensureCapacity(self: *Self, new_capacity: usize) !void {
232 var better_capacity = self.capacity();
231 var better_capacity = self.capacity;
233232 if (better_capacity >= new_capacity) return;
233
234234 while (true) {
235235 better_capacity += better_capacity / 2 + 8;
236236 if (better_capacity >= new_capacity) break;
237237 }
238 self.items = try self.allocator.realloc(self.items, better_capacity);
238
239 const new_memory = try self.allocator.realloc(self.allocatedSlice(), better_capacity);
240 self.items.ptr = new_memory.ptr;
241 self.capacity = new_memory.len;
239242 }
240243
241244 /// Increases the array's length to match the full capacity that is already allocated.
242245 /// The new elements have `undefined` values. This operation does not invalidate any
243246 /// element pointers.
244247 pub fn expandToCapacity(self: *Self) void {
245 self.len = self.items.len;
248 self.items.len = self.capacity;
246249 }
247250
248251 /// Increase length by 1, returning pointer to the new item.
249252 /// The returned pointer becomes invalid when the list is resized.
250253 pub fn addOne(self: *Self) !*T {
251 const new_length = self.len + 1;
252 try self.ensureCapacity(new_length);
254 const newlen = self.items.len + 1;
255 try self.ensureCapacity(newlen);
253256 return self.addOneAssumeCapacity();
254257 }
255258
......@@ -257,25 +260,32 @@ pub fn AlignedArrayList(comptime T: type, comptime alignment: ?u29) type {
257260 /// Asserts that there is already space for the new item without allocating more.
258261 /// The returned pointer becomes invalid when the list is resized.
259262 pub fn addOneAssumeCapacity(self: *Self) *T {
260 assert(self.len < self.capacity());
261 const result = &self.items[self.len];
262 self.len += 1;
263 return result;
263 assert(self.items.len < self.capacity);
264
265 self.items.len += 1;
266 return &self.items[self.items.len - 1];
264267 }
265268
266269 /// Remove and return the last element from the list.
267270 /// Asserts the list has at least one item.
268271 pub fn pop(self: *Self) T {
269 self.len -= 1;
270 return self.items[self.len];
272 const val = self.items[self.items.len - 1];
273 self.items.len -= 1;
274 return val;
271275 }
272276
273277 /// Remove and return the last element from the list.
274278 /// If the list is empty, returns `null`.
275279 pub fn popOrNull(self: *Self) ?T {
276 if (self.len == 0) return null;
280 if (self.items.len == 0) return null;
277281 return self.pop();
278282 }
283
284 // For a nicer API, `items.len` is the length, not the capacity.
285 // This requires "unsafe" slicing.
286 fn allocatedSlice(self: Self) Slice {
287 return self.items.ptr[0..self.capacity];
288 }
279289 };
280290}
281291
......@@ -283,15 +293,15 @@ test "std.ArrayList.init" {
283293 var list = ArrayList(i32).init(testing.allocator);
284294 defer list.deinit();
285295
286 testing.expect(list.len == 0);
287 testing.expect(list.capacity() == 0);
296 testing.expect(list.items.len == 0);
297 testing.expect(list.capacity == 0);
288298}
289299
290300test "std.ArrayList.initCapacity" {
291301 var list = try ArrayList(i8).initCapacity(testing.allocator, 200);
292302 defer list.deinit();
293 testing.expect(list.len == 0);
294 testing.expect(list.capacity() >= 200);
303 testing.expect(list.items.len == 0);
304 testing.expect(list.capacity >= 200);
295305}
296306
297307test "std.ArrayList.basic" {
......@@ -315,7 +325,7 @@ test "std.ArrayList.basic" {
315325 }
316326 }
317327
318 for (list.span()) |v, i| {
328 for (list.items) |v, i| {
319329 testing.expect(v == @intCast(i32, i + 1));
320330 }
321331
......@@ -324,19 +334,19 @@ test "std.ArrayList.basic" {
324334 }
325335
326336 testing.expect(list.pop() == 10);
327 testing.expect(list.len == 9);
337 testing.expect(list.items.len == 9);
328338
329339 list.appendSlice(&[_]i32{ 1, 2, 3 }) catch unreachable;
330 testing.expect(list.len == 12);
340 testing.expect(list.items.len == 12);
331341 testing.expect(list.pop() == 3);
332342 testing.expect(list.pop() == 2);
333343 testing.expect(list.pop() == 1);
334 testing.expect(list.len == 9);
344 testing.expect(list.items.len == 9);
335345
336346 list.appendSlice(&[_]i32{}) catch unreachable;
337 testing.expect(list.len == 9);
347 testing.expect(list.items.len == 9);
338348
339 // can only set on indices < self.len
349 // can only set on indices < self.items.len
340350 list.set(7, 33);
341351 list.set(8, 42);
342352
......@@ -352,8 +362,8 @@ test "std.ArrayList.appendNTimes" {
352362 defer list.deinit();
353363
354364 try list.appendNTimes(2, 10);
355 testing.expectEqual(@as(usize, 10), list.len);
356 for (list.span()) |element| {
365 testing.expectEqual(@as(usize, 10), list.items.len);
366 for (list.items) |element| {
357367 testing.expectEqual(@as(i32, 2), element);
358368 }
359369}
......@@ -378,17 +388,17 @@ test "std.ArrayList.orderedRemove" {
378388
379389 //remove from middle
380390 testing.expectEqual(@as(i32, 4), list.orderedRemove(3));
381 testing.expectEqual(@as(i32, 5), list.at(3));
382 testing.expectEqual(@as(usize, 6), list.len);
391 testing.expectEqual(@as(i32, 5), list.items[3]);
392 testing.expectEqual(@as(usize, 6), list.items.len);
383393
384394 //remove from end
385395 testing.expectEqual(@as(i32, 7), list.orderedRemove(5));
386 testing.expectEqual(@as(usize, 5), list.len);
396 testing.expectEqual(@as(usize, 5), list.items.len);
387397
388398 //remove from front
389399 testing.expectEqual(@as(i32, 1), list.orderedRemove(0));
390 testing.expectEqual(@as(i32, 2), list.at(0));
391 testing.expectEqual(@as(usize, 4), list.len);
400 testing.expectEqual(@as(i32, 2), list.items[0]);
401 testing.expectEqual(@as(usize, 4), list.items.len);
392402}
393403
394404test "std.ArrayList.swapRemove" {
......@@ -405,17 +415,17 @@ test "std.ArrayList.swapRemove" {
405415
406416 //remove from middle
407417 testing.expect(list.swapRemove(3) == 4);
408 testing.expect(list.at(3) == 7);
409 testing.expect(list.len == 6);
418 testing.expect(list.items[3] == 7);
419 testing.expect(list.items.len == 6);
410420
411421 //remove from end
412422 testing.expect(list.swapRemove(5) == 6);
413 testing.expect(list.len == 5);
423 testing.expect(list.items.len == 5);
414424
415425 //remove from front
416426 testing.expect(list.swapRemove(0) == 1);
417 testing.expect(list.at(0) == 5);
418 testing.expect(list.len == 4);
427 testing.expect(list.items[0] == 5);
428 testing.expect(list.items.len == 4);
419429}
420430
421431test "std.ArrayList.swapRemoveOrError" {
......@@ -478,7 +488,7 @@ test "std.ArrayList.insertSlice" {
478488
479489 const items = [_]i32{1};
480490 try list.insertSlice(0, items[0..0]);
481 testing.expect(list.len == 6);
491 testing.expect(list.items.len == 6);
482492 testing.expect(list.items[0] == 1);
483493}
484494
......@@ -504,3 +514,18 @@ test "std.ArrayList(u8) implements outStream" {
504514
505515 testing.expectEqualSlices(u8, "x: 42\ny: 1234\n", buffer.span());
506516}
517
518test "std.ArrayList.shrink still sets length on error.OutOfMemory" {
519 // use an arena allocator to make sure realloc returns error.OutOfMemory
520 var arena = std.heap.ArenaAllocator.init(testing.allocator);
521 defer arena.deinit();
522
523 var list = ArrayList(i32).init(&arena.allocator);
524
525 try list.append(1);
526 try list.append(2);
527 try list.append(3);
528
529 list.shrink(1);
530 testing.expect(list.items.len == 1);
531}
lib/std/array_list_sentineled.zig+8-8
......@@ -82,8 +82,8 @@ pub fn ArrayListSentineled(comptime T: type, comptime sentinel: T) type {
8282 self.list.deinit();
8383 }
8484
85 pub fn span(self: var) @TypeOf(self.list.items[0 .. self.list.len - 1 :sentinel]) {
86 return self.list.span()[0..self.len() :sentinel];
85 pub fn span(self: var) @TypeOf(self.list.items[0..:sentinel]) {
86 return self.list.items[0..self.len() :sentinel];
8787 }
8888
8989 pub fn shrink(self: *Self, new_len: usize) void {
......@@ -98,16 +98,16 @@ pub fn ArrayListSentineled(comptime T: type, comptime sentinel: T) type {
9898 }
9999
100100 pub fn isNull(self: Self) bool {
101 return self.list.len == 0;
101 return self.list.items.len == 0;
102102 }
103103
104104 pub fn len(self: Self) usize {
105 return self.list.len - 1;
105 return self.list.items.len - 1;
106106 }
107107
108108 pub fn capacity(self: Self) usize {
109 return if (self.list.items.len > 0)
110 self.list.items.len - 1
109 return if (self.list.capacity > 0)
110 self.list.capacity - 1
111111 else
112112 0;
113113 }
......@@ -115,13 +115,13 @@ pub fn ArrayListSentineled(comptime T: type, comptime sentinel: T) type {
115115 pub fn appendSlice(self: *Self, m: []const T) !void {
116116 const old_len = self.len();
117117 try self.resize(old_len + m.len);
118 mem.copy(T, self.list.span()[old_len..], m);
118 mem.copy(T, self.list.items[old_len..], m);
119119 }
120120
121121 pub fn append(self: *Self, byte: T) !void {
122122 const old_len = self.len();
123123 try self.resize(old_len + 1);
124 self.list.span()[old_len] = byte;
124 self.list.items[old_len] = byte;
125125 }
126126
127127 pub fn eql(self: Self, m: []const T) bool {
lib/std/build.zig+2-2
......@@ -1779,7 +1779,7 @@ pub const LibExeObjStep = struct {
17791779 const self = @fieldParentPtr(LibExeObjStep, "step", step);
17801780 const builder = self.builder;
17811781
1782 if (self.root_src == null and self.link_objects.len == 0) {
1782 if (self.root_src == null and self.link_objects.items.len == 0) {
17831783 warn("{}: linker needs 1 or more objects to link\n", .{self.step.name});
17841784 return error.NeedAnObject;
17851785 }
......@@ -1847,7 +1847,7 @@ pub const LibExeObjStep = struct {
18471847 }
18481848 }
18491849
1850 if (self.build_options_contents.len > 0) {
1850 if (self.build_options_contents.items.len > 0) {
18511851 const build_options_file = try fs.path.join(
18521852 builder.allocator,
18531853 &[_][]const u8{ builder.cache_root, builder.fmt("{}_build_options.zig", .{self.name}) },
lib/std/build/emit_raw.zig+1-1
......@@ -94,7 +94,7 @@ const BinaryElfOutput = struct {
9494
9595 sort.sort(*BinaryElfSegment, self.segments.span(), segmentSortCompare);
9696
97 if (self.segments.len > 0) {
97 if (self.segments.items.len > 0) {
9898 const firstSegment = self.segments.at(0);
9999 if (firstSegment.firstSection) |firstSection| {
100100 const diff = firstSection.elfOffset - firstSegment.elfOffset;
lib/std/coff.zig+1-1
......@@ -181,7 +181,7 @@ pub const Coff = struct {
181181 }
182182
183183 pub fn loadSections(self: *Coff) !void {
184 if (self.sections.len == self.coff_header.number_of_sections)
184 if (self.sections.items.len == self.coff_header.number_of_sections)
185185 return;
186186
187187 try self.sections.ensureCapacity(self.coff_header.number_of_sections);
lib/std/debug.zig+1-1
......@@ -1478,7 +1478,7 @@ pub const ModuleDebugInfo = switch (builtin.os.tag) {
14781478
14791479 var coff_section: *coff.Section = undefined;
14801480 const mod_index = for (self.sect_contribs) |sect_contrib| {
1481 if (sect_contrib.Section > self.coff.sections.len) continue;
1481 if (sect_contrib.Section > self.coff.sections.items.len) continue;
14821482 // Remember that SectionContribEntry.Section is 1-based.
14831483 coff_section = &self.coff.sections.span()[sect_contrib.Section - 1];
14841484
lib/std/dwarf.zig+4-4
......@@ -206,7 +206,7 @@ const LineNumberProgram = struct {
206206 if (self.target_address >= self.prev_address and self.target_address < self.address) {
207207 const file_entry = if (self.prev_file == 0) {
208208 return error.MissingDebugInfo;
209 } else if (self.prev_file - 1 >= self.file_entries.len) {
209 } else if (self.prev_file - 1 >= self.file_entries.items.len) {
210210 return error.InvalidDebugInfo;
211211 } else
212212 &self.file_entries.items[self.prev_file - 1];
......@@ -645,7 +645,7 @@ pub const DwarfInfo = struct {
645645 .offset = abbrev_offset,
646646 .table = try di.parseAbbrevTable(abbrev_offset),
647647 });
648 return &di.abbrev_table_list.items[di.abbrev_table_list.len - 1].table;
648 return &di.abbrev_table_list.items[di.abbrev_table_list.items.len - 1].table;
649649 }
650650
651651 fn parseAbbrevTable(di: *DwarfInfo, offset: u64) !AbbrevTable {
......@@ -665,7 +665,7 @@ pub const DwarfInfo = struct {
665665 .has_children = (try in.readByte()) == CHILDREN_yes,
666666 .attrs = ArrayList(AbbrevAttr).init(di.allocator()),
667667 });
668 const attrs = &result.items[result.len - 1].attrs;
668 const attrs = &result.items[result.items.len - 1].attrs;
669669
670670 while (true) {
671671 const attr_id = try leb.readULEB128(u64, in);
......@@ -689,7 +689,7 @@ pub const DwarfInfo = struct {
689689 .has_children = table_entry.has_children,
690690 .attrs = ArrayList(Die.Attr).init(di.allocator()),
691691 };
692 try result.attrs.resize(table_entry.attrs.len);
692 try result.attrs.resize(table_entry.attrs.items.len);
693693 for (table_entry.attrs.span()) |attr, i| {
694694 result.attrs.items[i] = Die.Attr{
695695 .id = attr.attr_id,
lib/std/fs.zig+3-3
......@@ -1440,9 +1440,9 @@ pub const Walker = struct {
14401440 /// a reference to the path.
14411441 pub fn next(self: *Walker) !?Entry {
14421442 while (true) {
1443 if (self.stack.len == 0) return null;
1443 if (self.stack.items.len == 0) return null;
14441444 // `top` becomes invalid after appending to `self.stack`.
1445 const top = &self.stack.span()[self.stack.len - 1];
1445 const top = &self.stack.span()[self.stack.items.len - 1];
14461446 const dirname_len = top.dirname_len;
14471447 if (try top.dir_it.next()) |base| {
14481448 self.name_buffer.shrink(dirname_len);
......@@ -1457,7 +1457,7 @@ pub const Walker = struct {
14571457 errdefer new_dir.close();
14581458 try self.stack.append(StackItem{
14591459 .dir_it = new_dir.iterate(),
1460 .dirname_len = self.name_buffer.len,
1460 .dirname_len = self.name_buffer.items.len,
14611461 });
14621462 }
14631463 }
lib/std/http/headers.zig+12-12
......@@ -139,7 +139,7 @@ pub const Headers = struct {
139139 pub fn clone(self: Self, allocator: *Allocator) !Self {
140140 var other = Headers.init(allocator);
141141 errdefer other.deinit();
142 try other.data.ensureCapacity(self.data.len);
142 try other.data.ensureCapacity(self.data.items.len);
143143 try other.index.initCapacity(self.index.entries.len);
144144 for (self.data.span()) |entry| {
145145 try other.append(entry.name, entry.value, entry.never_index);
......@@ -152,7 +152,7 @@ pub const Headers = struct {
152152 }
153153
154154 pub fn append(self: *Self, name: []const u8, value: []const u8, never_index: ?bool) !void {
155 const n = self.data.len + 1;
155 const n = self.data.items.len + 1;
156156 try self.data.ensureCapacity(n);
157157 var entry: HeaderEntry = undefined;
158158 if (self.index.get(name)) |kv| {
......@@ -197,7 +197,7 @@ pub const Headers = struct {
197197 if (self.index.remove(name)) |kv| {
198198 var dex = &kv.value;
199199 // iterate backwards
200 var i = dex.len;
200 var i = dex.items.len;
201201 while (i > 0) {
202202 i -= 1;
203203 const data_index = dex.at(i);
......@@ -220,18 +220,18 @@ pub const Headers = struct {
220220 const removed = self.data.orderedRemove(i);
221221 const kv = self.index.get(removed.name).?;
222222 var dex = &kv.value;
223 if (dex.len == 1) {
223 if (dex.items.len == 1) {
224224 // was last item; delete the index
225225 _ = self.index.remove(kv.key);
226226 dex.deinit();
227227 removed.deinit();
228228 self.allocator.free(kv.key);
229229 } else {
230 dex.shrink(dex.len - 1);
230 dex.shrink(dex.items.len - 1);
231231 removed.deinit();
232232 }
233233 // if it was the last item; no need to rebuild index
234 if (i != self.data.len) {
234 if (i != self.data.items.len) {
235235 self.rebuild_index();
236236 }
237237 }
......@@ -242,18 +242,18 @@ pub const Headers = struct {
242242 const removed = self.data.swapRemove(i);
243243 const kv = self.index.get(removed.name).?;
244244 var dex = &kv.value;
245 if (dex.len == 1) {
245 if (dex.items.len == 1) {
246246 // was last item; delete the index
247247 _ = self.index.remove(kv.key);
248248 dex.deinit();
249249 removed.deinit();
250250 self.allocator.free(kv.key);
251251 } else {
252 dex.shrink(dex.len - 1);
252 dex.shrink(dex.items.len - 1);
253253 removed.deinit();
254254 }
255255 // if it was the last item; no need to rebuild index
256 if (i != self.data.len) {
256 if (i != self.data.items.len) {
257257 self.rebuild_index();
258258 }
259259 }
......@@ -277,7 +277,7 @@ pub const Headers = struct {
277277 pub fn get(self: Self, allocator: *Allocator, name: []const u8) !?[]const HeaderEntry {
278278 const dex = self.getIndices(name) orelse return null;
279279
280 const buf = try allocator.alloc(HeaderEntry, dex.len);
280 const buf = try allocator.alloc(HeaderEntry, dex.items.len);
281281 var n: usize = 0;
282282 for (dex.span()) |idx| {
283283 buf[n] = self.data.at(idx);
......@@ -301,7 +301,7 @@ pub const Headers = struct {
301301
302302 // adapted from mem.join
303303 const total_len = blk: {
304 var sum: usize = dex.len - 1; // space for separator(s)
304 var sum: usize = dex.items.len - 1; // space for separator(s)
305305 for (dex.span()) |idx|
306306 sum += self.data.at(idx).value.len;
307307 break :blk sum;
......@@ -330,7 +330,7 @@ pub const Headers = struct {
330330 var it = self.index.iterator();
331331 while (it.next()) |kv| {
332332 var dex = &kv.value;
333 dex.len = 0; // keeps capacity available
333 dex.items.len = 0; // keeps capacity available
334334 }
335335 }
336336 { // fill up indexes again; we know capacity is fine from before
lib/std/io/in_stream.zig+2-2
......@@ -54,7 +54,7 @@ pub fn InStream(
5454 /// and the `std.ArrayList` has exactly `max_append_size` bytes appended.
5555 pub fn readAllArrayList(self: Self, array_list: *std.ArrayList(u8), max_append_size: usize) !void {
5656 try array_list.ensureCapacity(math.min(max_append_size, 4096));
57 const original_len = array_list.len;
57 const original_len = array_list.items.len;
5858 var start_index: usize = original_len;
5959 while (true) {
6060 array_list.expandToCapacity();
......@@ -106,7 +106,7 @@ pub fn InStream(
106106 return;
107107 }
108108
109 if (array_list.len == max_size) {
109 if (array_list.items.len == max_size) {
110110 return error.StreamTooLong;
111111 }
112112
lib/std/json.zig+10-10
......@@ -1556,7 +1556,7 @@ fn parseInternal(comptime T: type, token: Token, tokens: *TokenStream, options:
15561556 else => {},
15571557 }
15581558
1559 try arraylist.ensureCapacity(arraylist.len + 1);
1559 try arraylist.ensureCapacity(arraylist.items.len + 1);
15601560 const v = try parseInternal(ptrInfo.child, tok, tokens, options);
15611561 arraylist.appendAssumeCapacity(v);
15621562 }
......@@ -1874,7 +1874,7 @@ pub const Parser = struct {
18741874 try p.transition(&arena.allocator, input, s.i - 1, token);
18751875 }
18761876
1877 debug.assert(p.stack.len == 1);
1877 debug.assert(p.stack.items.len == 1);
18781878
18791879 return ValueTree{
18801880 .arena = arena,
......@@ -1888,7 +1888,7 @@ pub const Parser = struct {
18881888 switch (p.state) {
18891889 .ObjectKey => switch (token) {
18901890 .ObjectEnd => {
1891 if (p.stack.len == 1) {
1891 if (p.stack.items.len == 1) {
18921892 return;
18931893 }
18941894
......@@ -1907,8 +1907,8 @@ pub const Parser = struct {
19071907 },
19081908 },
19091909 .ObjectValue => {
1910 var object = &p.stack.items[p.stack.len - 2].Object;
1911 var key = p.stack.items[p.stack.len - 1].String;
1910 var object = &p.stack.items[p.stack.items.len - 2].Object;
1911 var key = p.stack.items[p.stack.items.len - 1].String;
19121912
19131913 switch (token) {
19141914 .ObjectBegin => {
......@@ -1950,11 +1950,11 @@ pub const Parser = struct {
19501950 }
19511951 },
19521952 .ArrayValue => {
1953 var array = &p.stack.items[p.stack.len - 1].Array;
1953 var array = &p.stack.items[p.stack.items.len - 1].Array;
19541954
19551955 switch (token) {
19561956 .ArrayEnd => {
1957 if (p.stack.len == 1) {
1957 if (p.stack.items.len == 1) {
19581958 return;
19591959 }
19601960
......@@ -2021,12 +2021,12 @@ pub const Parser = struct {
20212021 }
20222022
20232023 fn pushToParent(p: *Parser, value: *const Value) !void {
2024 switch (p.stack.span()[p.stack.len - 1]) {
2024 switch (p.stack.span()[p.stack.items.len - 1]) {
20252025 // Object Parent -> [ ..., object, <key>, value ]
20262026 Value.String => |key| {
20272027 _ = p.stack.pop();
20282028
2029 var object = &p.stack.items[p.stack.len - 1].Object;
2029 var object = &p.stack.items[p.stack.items.len - 1].Object;
20302030 _ = try object.put(key, value.*);
20312031 p.state = .ObjectKey;
20322032 },
......@@ -2165,7 +2165,7 @@ test "json.parser.dynamic" {
21652165 testing.expect(animated.Bool == false);
21662166
21672167 const array_of_object = image.Object.get("ArrayOfObject").?.value;
2168 testing.expect(array_of_object.Array.len == 1);
2168 testing.expect(array_of_object.Array.items.len == 1);
21692169
21702170 const obj0 = array_of_object.Array.at(0).Object.get("n").?.value;
21712171 testing.expect(mem.eql(u8, obj0.String, "m"));
lib/std/math/big/rational.zig-1
......@@ -4,7 +4,6 @@ const math = std.math;
44const mem = std.mem;
55const testing = std.testing;
66const Allocator = mem.Allocator;
7const ArrayList = std.ArrayList;
87
98const bn = @import("int.zig");
109const Limb = bn.Limb;
lib/std/net.zig+8-8
......@@ -509,7 +509,7 @@ pub fn getAddressList(allocator: *mem.Allocator, name: []const u8, port: u16) !*
509509
510510 try linuxLookupName(&lookup_addrs, &canon, name, family, flags, port);
511511
512 result.addrs = try arena.alloc(Address, lookup_addrs.len);
512 result.addrs = try arena.alloc(Address, lookup_addrs.items.len);
513513 if (!canon.isNull()) {
514514 result.canon_name = canon.toOwnedSlice();
515515 }
......@@ -554,7 +554,7 @@ fn linuxLookupName(
554554 return name_err;
555555 } else {
556556 try linuxLookupNameFromHosts(addrs, canon, name, family, port);
557 if (addrs.len == 0) {
557 if (addrs.items.len == 0) {
558558 try linuxLookupNameFromDnsSearch(addrs, canon, name, family, port);
559559 }
560560 }
......@@ -562,11 +562,11 @@ fn linuxLookupName(
562562 try canon.resize(0);
563563 try linuxLookupNameFromNull(addrs, family, flags, port);
564564 }
565 if (addrs.len == 0) return error.UnknownHostName;
565 if (addrs.items.len == 0) return error.UnknownHostName;
566566
567567 // No further processing is needed if there are fewer than 2
568568 // results or if there are only IPv4 results.
569 if (addrs.len == 1 or family == os.AF_INET) return;
569 if (addrs.items.len == 1 or family == os.AF_INET) return;
570570 const all_ip4 = for (addrs.span()) |addr| {
571571 if (addr.addr.any.family != os.AF_INET) break false;
572572 } else true;
......@@ -908,7 +908,7 @@ fn linuxLookupNameFromDnsSearch(
908908 canon.shrink(canon_name.len + 1);
909909 try canon.appendSlice(tok);
910910 try linuxLookupNameFromDns(addrs, canon, canon.span(), family, rc, port);
911 if (addrs.len != 0) return;
911 if (addrs.items.len != 0) return;
912912 }
913913
914914 canon.shrink(canon_name.len);
......@@ -967,7 +967,7 @@ fn linuxLookupNameFromDns(
967967 dnsParse(ap[i], ctx, dnsParseCallback) catch {};
968968 }
969969
970 if (addrs.len != 0) return;
970 if (addrs.items.len != 0) return;
971971 if (ap[0].len < 4 or (ap[0][3] & 15) == 2) return error.TemporaryNameServerFailure;
972972 if ((ap[0][3] & 15) == 0) return error.UnknownHostName;
973973 if ((ap[0][3] & 15) == 3) return;
......@@ -1049,7 +1049,7 @@ fn getResolvConf(allocator: *mem.Allocator, rc: *ResolvConf) !void {
10491049 }
10501050 }
10511051
1052 if (rc.ns.len == 0) {
1052 if (rc.ns.items.len == 0) {
10531053 return linuxLookupNameFromNumericUnspec(&rc.ns, "127.0.0.1", 53);
10541054 }
10551055}
......@@ -1078,7 +1078,7 @@ fn resMSendRc(
10781078 var ns_list = std.ArrayList(Address).init(rc.ns.allocator);
10791079 defer ns_list.deinit();
10801080
1081 try ns_list.resize(rc.ns.len);
1081 try ns_list.resize(rc.ns.items.len);
10821082 const ns = ns_list.span();
10831083
10841084 for (rc.ns.span()) |iplit, i| {
lib/std/special/build_runner.zig+1-1
......@@ -171,7 +171,7 @@ fn usage(builder: *Builder, already_ran_build: bool, out_stream: var) !void {
171171 \\
172172 );
173173
174 if (builder.available_options_list.len == 0) {
174 if (builder.available_options_list.items.len == 0) {
175175 try out_stream.print(" (none)\n", .{});
176176 } else {
177177 for (builder.available_options_list.span()) |option| {
lib/std/unicode.zig+2-2
......@@ -475,7 +475,7 @@ pub fn utf16leToUtf8Alloc(allocator: *mem.Allocator, utf16le: []const u16) ![]u8
475475 var it = Utf16LeIterator.init(utf16le);
476476 while (try it.nextCodepoint()) |codepoint| {
477477 const utf8_len = utf8CodepointSequenceLength(codepoint) catch unreachable;
478 try result.resize(result.len + utf8_len);
478 try result.resize(result.items.len + utf8_len);
479479 assert((utf8Encode(codepoint, result.items[out_index..]) catch unreachable) == utf8_len);
480480 out_index += utf8_len;
481481 }
......@@ -571,7 +571,7 @@ pub fn utf8ToUtf16LeWithNull(allocator: *mem.Allocator, utf8: []const u8) ![:0]u
571571 }
572572 }
573573
574 const len = result.len;
574 const len = result.items.len;
575575 try result.append(0);
576576 return result.toOwnedSlice()[0..len :0];
577577}
src-self-hosted/libc_installation.zig+3-3
......@@ -268,7 +268,7 @@ pub const LibCInstallation = struct {
268268 try search_paths.append(line);
269269 }
270270 }
271 if (search_paths.len == 0) {
271 if (search_paths.items.len == 0) {
272272 return error.CCompilerCannotFindHeaders;
273273 }
274274
......@@ -276,9 +276,9 @@ pub const LibCInstallation = struct {
276276 const sys_include_dir_example_file = if (is_windows) "sys\\types.h" else "sys/errno.h";
277277
278278 var path_i: usize = 0;
279 while (path_i < search_paths.len) : (path_i += 1) {
279 while (path_i < search_paths.items.len) : (path_i += 1) {
280280 // search in reverse order
281 const search_path_untrimmed = search_paths.at(search_paths.len - path_i - 1);
281 const search_path_untrimmed = search_paths.at(search_paths.items.len - path_i - 1);
282282 const search_path = std.mem.trimLeft(u8, search_path_untrimmed, " ");
283283 var search_dir = fs.cwd().openDir(search_path, .{}) catch |err| switch (err) {
284284 error.FileNotFound,
src-self-hosted/stage2.zig+2-2
......@@ -239,7 +239,7 @@ fn fmtMain(argc: c_int, argv: [*]const [*:0]const u8) !void {
239239 }
240240
241241 if (stdin_flag) {
242 if (input_files.len != 0) {
242 if (input_files.items.len != 0) {
243243 try stderr.writeAll("cannot use --stdin with positional arguments\n");
244244 process.exit(1);
245245 }
......@@ -273,7 +273,7 @@ fn fmtMain(argc: c_int, argv: [*]const [*:0]const u8) !void {
273273 return;
274274 }
275275
276 if (input_files.len == 0) {
276 if (input_files.items.len == 0) {
277277 try stderr.writeAll("expected at least one source file argument\n");
278278 process.exit(1);
279279 }
src-self-hosted/translate_c.zig+3-3
......@@ -4309,7 +4309,7 @@ fn makeRestorePoint(c: *Context) RestorePoint {
43094309 return RestorePoint{
43104310 .c = c,
43114311 .token_index = c.tree.tokens.len,
4312 .src_buf_index = c.source_buffer.len,
4312 .src_buf_index = c.source_buffer.items.len,
43134313 };
43144314}
43154315
......@@ -4771,11 +4771,11 @@ fn appendToken(c: *Context, token_id: Token.Id, bytes: []const u8) !ast.TokenInd
47714771
47724772fn appendTokenFmt(c: *Context, token_id: Token.Id, comptime format: []const u8, args: var) !ast.TokenIndex {
47734773 assert(token_id != .Invalid);
4774 const start_index = c.source_buffer.len;
4774 const start_index = c.source_buffer.items.len;
47754775 errdefer c.source_buffer.shrink(start_index);
47764776
47774777 try c.source_buffer.outStream().print(format, args);
4778 const end_index = c.source_buffer.len;
4778 const end_index = c.source_buffer.items.len;
47794779 const token_index = c.tree.tokens.len;
47804780 const new_token = try c.tree.tokens.addOne();
47814781 errdefer c.tree.tokens.shrink(token_index);
test/standalone/brace_expansion/main.zig+2-2
......@@ -113,7 +113,7 @@ fn parse(tokens: *const ArrayList(Token), token_index: *usize) ParseError!Node {
113113
114114fn expandString(input: []const u8, output: *ArrayListSentineled(u8, 0)) !void {
115115 const tokens = try tokenize(input);
116 if (tokens.len == 1) {
116 if (tokens.items.len == 1) {
117117 return output.resize(0);
118118 }
119119
......@@ -142,7 +142,7 @@ fn expandString(input: []const u8, output: *ArrayListSentineled(u8, 0)) !void {
142142const ExpandNodeError = error{OutOfMemory};
143143
144144fn expandNode(node: Node, output: *ArrayList(ArrayListSentineled(u8, 0))) ExpandNodeError!void {
145 assert(output.len == 0);
145 assert(output.items.len == 0);
146146 switch (node) {
147147 Node.Scalar => |scalar| {
148148 try output.append(try ArrayListSentineled(u8, 0).init(global_allocator, scalar));
test/tests.zig+2-2
......@@ -879,13 +879,13 @@ pub const CompileErrorContext = struct {
879879 var err_iter = ErrLineIter.init(stderr);
880880 var i: usize = 0;
881881 ok = while (err_iter.next()) |line| : (i += 1) {
882 if (i >= self.case.expected_errors.len) break false;
882 if (i >= self.case.expected_errors.items.len) break false;
883883 const expected = self.case.expected_errors.at(i);
884884 if (mem.indexOf(u8, line, expected) == null) break false;
885885 continue;
886886 } else true;
887887
888 ok = ok and i == self.case.expected_errors.len;
888 ok = ok and i == self.case.expected_errors.items.len;
889889
890890 if (!ok) {
891891 warn("\n======== Expected these compile errors: ========\n", .{});
tools/merge_anal_dumps.zig+4-4
......@@ -194,7 +194,7 @@ const Dump = struct {
194194 for (other_files) |other_file, i| {
195195 const gop = try self.file_map.getOrPut(other_file.String);
196196 if (!gop.found_existing) {
197 gop.kv.value = self.file_list.len;
197 gop.kv.value = self.file_list.items.len;
198198 try self.file_list.append(other_file.String);
199199 }
200200 try other_file_to_mine.putNoClobber(i, gop.kv.value);
......@@ -213,7 +213,7 @@ const Dump = struct {
213213 };
214214 const gop = try self.node_map.getOrPut(other_node);
215215 if (!gop.found_existing) {
216 gop.kv.value = self.node_list.len;
216 gop.kv.value = self.node_list.items.len;
217217 try self.node_list.append(other_node);
218218 }
219219 try other_ast_node_to_mine.putNoClobber(i, gop.kv.value);
......@@ -243,7 +243,7 @@ const Dump = struct {
243243 };
244244 const gop = try self.error_map.getOrPut(other_error);
245245 if (!gop.found_existing) {
246 gop.kv.value = self.error_list.len;
246 gop.kv.value = self.error_list.items.len;
247247 try self.error_list.append(other_error);
248248 }
249249 try other_error_to_mine.putNoClobber(i, gop.kv.value);
......@@ -304,7 +304,7 @@ const Dump = struct {
304304 ) !void {
305305 const gop = try self.type_map.getOrPut(other_type);
306306 if (!gop.found_existing) {
307 gop.kv.value = self.type_list.len;
307 gop.kv.value = self.type_list.items.len;
308308 try self.type_list.append(other_type);
309309 }
310310 try other_types_to_mine.putNoClobber(other_type_index, gop.kv.value);