Commit e9e43ed0d39f623d424f87fbd035f949cf5a3227 | zig

author	daurnimator <quae@daurnimator.com> 2020-04-05 14:08:25+10:00
committer	daurnimator <quae@daurnimator.com> 2020-04-05 14:08:25+10:00
log	e9e43ed0d39f623d424f87fbd035f949cf5a3227
tree	eb06e5334edfbd3be008fd9287f07b11a8336833
parent	f9474443620c9c654c0a888a928557f8ec2815c8
signature	Commit is signed but in an unrecognized format.

compiler_rt/atomics: be consistent with `const value`

1 files changed, 11 insertions(+), 10 deletions(-)

lib
- std
  - special
    compiler_rt
    atomics.zig

lib/std/special/compiler_rt/atomics.zig+11-10

 @@ -154,7 +154,7 @@ fn atomicExchangeFn(comptime T: type) fn (*T, T, i32) callconv(.C) T {
             if (@sizeOf(T) > largest_atomic_size) {
                 var sl = spinlocks.get(@ptrToInt(ptr));
                 defer sl.release();
-                var value = ptr.*;
+                const value = ptr.*;
                 ptr.* = val;
                 return value;
             } else {
 @@ -177,11 +177,12 @@ fn atomicCompareExchangeFn(comptime T: type) fn (*T, *T, T, i32, i32) callconv(.
             if (@sizeOf(T) > largest_atomic_size) {
                 var sl = spinlocks.get(@ptrToInt(ptr));
                 defer sl.release();
-                if (ptr.* == expected.*) {
+                const value = ptr.*;
+                if (value == expected.*) {
                     ptr.* = desired;
                     return 1;
                 }
-                expected.* = ptr.*;
+                expected.* = value;
                 return 0;
             } else {
                 if (@cmpxchgStrong(T, ptr, expected.*, desired, .SeqCst, .SeqCst)) |old_value| {
 @@ -208,14 +209,14 @@ fn fetchFn(comptime T: type, comptime op: builtin.AtomicRmwOp) fn (*T, T, i32) c
                 var sl = spinlocks.get(@ptrToInt(ptr));
                 defer sl.release();
-                var value = ptr.*;
+                const value = ptr.*;
                 ptr.* = switch (op) {
-                    .Add => ptr.* +% val,
+                    .Add => value +% val,
-                    .Sub => ptr.* -% val,
+                    .Sub => value -% val,
-                    .And => ptr.* & val,
+                    .And => value & val,
-                    .Nand => ~(ptr.* & val),
+                    .Nand => ~(value & val),
-                    .Or => ptr.* | val,
+                    .Or => value | val,
-                    .Xor => ptr.* ^ val,
+                    .Xor => value ^ val,
                     else => @compileError("unsupported atomic op"),
                 };