Commit edb6486b3bf7a1c333d7cc3348f88ab121b72830 | zig

author	Jacob Young <jacobly@ziglang.org> 2024-02-24 16:59:00+01:00
committer	Jacob Young <jacobly@ziglang.org> 2024-02-24 17:00:36+01:00
log	edb6486b3bf7a1c333d7cc3348f88ab121b72830
tree	47469b8cfb262fbf9e6a1ddfc89748fd4fa67916
parent	7e9f321f53b53dcefaf3b771720c9c25529c39ef

BitcodeWriter: cleanup type widths

2 files changed, 9 insertions(+), 13 deletions(-)

src
- codegen
  - llvm
    Builder.zig
    bitcode_writer.zig

src/codegen/llvm/Builder.zig+1-1

...	@@ -12944,7 +12944,7 @@ fn debugConstantAssumeCapacity(self: *Builder, constant: Constant) Metadata {	...	@@ -12944,7 +12944,7 @@ fn debugConstantAssumeCapacity(self: *Builder, constant: Constant) Metadata {
12944		12944
12945	pub fn toBitcode(self: *Builder, allocator: Allocator) bitcode_writer.Error![]const u32 {	12945	pub fn toBitcode(self: *Builder, allocator: Allocator) bitcode_writer.Error![]const u32 {
12946	const BitcodeWriter = bitcode_writer.BitcodeWriter(&.{ Type, FunctionAttributes });	12946	const BitcodeWriter = bitcode_writer.BitcodeWriter(&.{ Type, FunctionAttributes });
12947	var bitcode = BitcodeWriter.init(allocator, &.{	12947	var bitcode = BitcodeWriter.init(allocator, .{
12948	std.math.log2_int_ceil(usize, self.type_items.items.len),	12948	std.math.log2_int_ceil(usize, self.type_items.items.len),
12949	std.math.log2_int_ceil(usize, 1 + self.function_attributes_set.count()),	12949	std.math.log2_int_ceil(usize, 1 + self.function_attributes_set.count()),
12950	});	12950	});

src/codegen/llvm/bitcode_writer.zig+8-12

 @@ -23,17 +23,13 @@ pub fn BitcodeWriter(comptime types: []const type) type {
         bit_buffer: u32 = 0,
         bit_count: u5 = 0,
-        widths: []const u16,
+        widths: [types.len]u16,
-        pub fn getTypeIndex(comptime ty: type) usize {
+        pub fn getTypeWidth(self: BcWriter, comptime Type: type) u16 {
-            inline for (types, 0..) |t, i| {
+            return self.widths[comptime std.mem.indexOfScalar(type, types, Type).?];
-                if (t == ty) return i;
-            }
-            unreachable;
         }
-        pub fn init(allocator: std.mem.Allocator, widths: []const u16) BcWriter {
+        pub fn init(allocator: std.mem.Allocator, widths: [types.len]u16) BcWriter {
-            std.debug.assert(widths.len == types.len);
             return .{
                 .buffer = std.ArrayList(u32).init(allocator),
                 .widths = widths,
 @@ -250,7 +246,7 @@ pub fn BitcodeWriter(comptime types: []const type) type {
                             .fixed => |len| try self.bitcode.writeBits(adapter.get(param, field_name), len),
                             .fixed_runtime => |width_ty| try self.bitcode.writeBits(
                                 adapter.get(param, field_name),
-                                self.bitcode.widths[getTypeIndex(width_ty)],
+                                self.bitcode.getTypeWidth(width_ty),
                             ),
                             .vbr => |len| try self.bitcode.writeVBR(adapter.get(param, field_name), len),
                             .char6 => try self.bitcode.write6BitChar(adapter.get(param, field_name)),
 @@ -273,7 +269,7 @@ pub fn BitcodeWriter(comptime types: []const type) type {
                                 for (param) |x| {
                                     try self.bitcode.writeBits(
                                         adapter.get(x, field_name),
-                                        self.bitcode.widths[getTypeIndex(width_ty)],
+                                        self.bitcode.getTypeWidth(width_ty),
                                     );
                                 }
                             },
 @@ -324,7 +320,7 @@ pub fn BitcodeWriter(comptime types: []const type) type {
                             .fixed_runtime => |width_ty| {
                                 try bitcode.writeBits(0, 1);
                                 try bitcode.writeBits(1, 3);
-                                try bitcode.writeVBR(bitcode.widths[getTypeIndex(width_ty)], 5);
+                                try bitcode.writeVBR(bitcode.getTypeWidth(width_ty), 5);
                             },
                             .vbr => |width| {
                                 try bitcode.writeBits(0, 1);
 @@ -357,7 +353,7 @@ pub fn BitcodeWriter(comptime types: []const type) type {
                                 // Fixed or VBR op
                                 try bitcode.writeBits(0, 1);
                                 try bitcode.writeBits(1, 3);
-                                try bitcode.writeVBR(bitcode.widths[getTypeIndex(width_ty)], 5);
+                                try bitcode.writeVBR(bitcode.getTypeWidth(width_ty), 5);
                             },
                             .array_vbr => |width| {
                                 // Array op