Commit f2778f7ca07cdfd599c65185dbcc6a648740fd5d | zig

author	Andrew Kelley <andrew@ziglang.org> 2023-05-29 16:52:21-07:00
committer	Andrew Kelley <andrew@ziglang.org> 2023-06-10 20:47:56-07:00
log	f2778f7ca07cdfd599c65185dbcc6a648740fd5d
tree	db62e2ecc46ae0f927ec1243bc722ab4b45b42b9
parent	b336866fbc1edd4c999d3cd5d62ae7230d176fa7

InternPool: avoid indexToKey recursion for only_possible_value

This is a hot function, and recursion makes it more difficult to
profile, as well as likely making it more difficult to optimize.

1 files changed, 15 insertions(+), 7 deletions(-)

src
- InternPool.zig

src/InternPool.zig+15-7

 @@ -2765,8 +2765,9 @@ pub fn indexToKey(ip: *const InternPool, index: Index) Key {
         .func => .{ .func = ip.extraData(Key.Func, data) },
         .only_possible_value => {
             const ty = @intToEnum(Index, data);
-            return switch (ip.indexToKey(ty)) {
+            const ty_item = ip.items.get(@enumToInt(ty));
-                .array_type, .vector_type => .{ .aggregate = .{
+            return switch (ty_item.tag) {
+                .type_array_big, .type_array_small, .type_vector => .{ .aggregate = .{
                     .ty = ty,
                     .storage = .{ .elems = &.{} },
                 } },
 @@ -2775,16 +2776,23 @@ pub fn indexToKey(ip: *const InternPool, index: Index) Key {
                 // have a slice of comptime values that can be used here for when
                 // the struct has one possible value due to all fields comptime (same
                 // as the tuple case below).
-                .struct_type => .{ .aggregate = .{
+                .type_struct, .type_struct_ns => .{ .aggregate = .{
                     .ty = ty,
                     .storage = .{ .elems = &.{} },
                 } },
                 // There is only one possible value precisely due to the
                 // fact that this values slice is fully populated!
-                .anon_struct_type => |anon_struct_type| .{ .aggregate = .{
+                .type_struct_anon, .type_tuple_anon => {
-                    .ty = ty,
+                    const type_struct_anon = ip.extraDataTrail(TypeStructAnon, ty_item.data);
-                    .storage = .{ .elems = anon_struct_type.values },
+                    const fields_len = type_struct_anon.data.fields_len;
-                } },
+                    const values = ip.extra.items[type_struct_anon.end + fields_len ..][0..fields_len];
+                    return .{ .aggregate = .{
+                        .ty = ty,
+                        .storage = .{ .elems = @ptrCast([]const Index, values) },
+                    } };
+                },
                 else => unreachable,
             };
         },