Commit f3da54f53c1db1484b00657de18e3677358549cd | zig

author	Alex Rønne Petersen <alex@alexrp.com> 2025-03-26 15:50:31+01:00
committer	Alex Rønne Petersen <alex@alexrp.com> 2025-10-18 11:13:28+02:00
log	f3da54f53c1db1484b00657de18e3677358549cd
tree	e356155b2f652c7a434ada3e3600529ef1a41e4b
parent	631915ad961c83b8a2e4e36f11a278dae054372e

std.Target: move Cpu.supportsAddressSpace() up to here

This allows us to rule out support for certain address spaces based on the OS.
This commit is just a refactor, however, and doesn't actually make use of that
opportunity yet.

3 files changed, 33 insertions(+), 33 deletions(-)

lib
- std
  - Target.zig
src
- Sema.zig
- target.zig

lib/std/Target.zig+29-29

 @@ -1944,35 +1944,6 @@ pub const Cpu = struct {
         return Model.baseline(arch, os).toCpu(arch);
     }
-    /// Returns whether this architecture supports `address_space`. If `context` is `null`, this
-    /// function simply answers the general question of whether the architecture has any concept
-    /// of `address_space`; if non-`null`, the function additionally checks whether
-    /// `address_space` is valid in that context.
-    pub fn supportsAddressSpace(
-        cpu: Cpu,
-        address_space: std.builtin.AddressSpace,
-        context: ?std.builtin.AddressSpace.Context,
-    ) bool {
-        const arch = cpu.arch;
-        const is_nvptx = arch.isNvptx();
-        const is_spirv = arch.isSpirV();
-        const is_gpu = is_nvptx or is_spirv or arch == .amdgcn;
-        return switch (address_space) {
-            .generic => true,
-            .fs, .gs, .ss => (arch == .x86_64 or arch == .x86) and (context == null or context == .pointer),
-            .flash, .flash1, .flash2, .flash3, .flash4, .flash5 => arch == .avr, // TODO this should also check how many flash banks the cpu has
-            .cog, .hub => arch == .propeller,
-            .lut => arch == .propeller and cpu.has(.propeller, .p2),
-            .global, .local, .shared => is_gpu,
-            .constant => is_gpu and (context == null or context == .constant),
-            .param => is_nvptx,
-            .input, .output, .uniform, .push_constant, .storage_buffer, .physical_storage_buffer => is_spirv,
-        };
-    }
     /// Returns true if `feature` is enabled.
     pub fn has(cpu: Cpu, comptime family: Arch.Family, feature: @field(Target, @tagName(family)).Feature) bool {
         if (family != cpu.arch.family()) return false;
 @@ -2132,6 +2103,35 @@ pub fn requiresLibC(target: *const Target) bool {
     };
 }
+/// Returns whether this target supports `address_space`. If `context` is `null`, this
+/// function simply answers the general question of whether the target has any concept
+/// of `address_space`; if non-`null`, the function additionally checks whether
+/// `address_space` is valid in that context.
+pub fn supportsAddressSpace(
+    target: Target,
+    address_space: std.builtin.AddressSpace,
+    context: ?std.builtin.AddressSpace.Context,
+) bool {
+    const arch = target.cpu.arch;
+    const is_nvptx = arch.isNvptx();
+    const is_spirv = arch.isSpirV();
+    const is_gpu = is_nvptx or is_spirv or arch == .amdgcn;
+    return switch (address_space) {
+        .generic => true,
+        .fs, .gs, .ss => (arch == .x86_64 or arch == .x86) and (context == null or context == .pointer),
+        .flash, .flash1, .flash2, .flash3, .flash4, .flash5 => arch == .avr, // TODO this should also check how many flash banks the cpu has
+        .cog, .hub => arch == .propeller,
+        .lut => arch == .propeller and std.Target.propeller.featureSetHas(target.cpu.features, .p2),
+        .global, .local, .shared => is_gpu,
+        .constant => is_gpu and (context == null or context == .constant),
+        .param => is_nvptx,
+        .input, .output, .uniform, .push_constant, .storage_buffer, .physical_storage_buffer => is_spirv,
+    };
+}
 pub const DynamicLinker = struct {
     /// Contains the memory used to store the dynamic linker path. This field
     /// should not be used directly. See `get` and `set`. This field exists so

src/Sema.zig+1-1

...	@@ -36508,7 +36508,7 @@ pub fn analyzeAsAddressSpace(	...	@@ -36508,7 +36508,7 @@ pub fn analyzeAsAddressSpace(
36508	const address_space = try sema.interpretBuiltinType(block, src, addrspace_val, std.builtin.AddressSpace);	36508	const address_space = try sema.interpretBuiltinType(block, src, addrspace_val, std.builtin.AddressSpace);
36509	const target = pt.zcu.getTarget();	36509	const target = pt.zcu.getTarget();
36510		36510
36511	if (!target.cpu.supportsAddressSpace(address_space, ctx)) {	36511	if (!target.supportsAddressSpace(address_space, ctx)) {
36512	// TODO error messages could be made more elaborate here	36512	// TODO error messages could be made more elaborate here
36513	const entity = switch (ctx) {	36513	const entity = switch (ctx) {
36514	.function => "functions",	36514	.function => "functions",

src/target.zig+3-3

...	@@ -539,10 +539,10 @@ pub fn addrSpaceCastIsValid(	...	@@ -539,10 +539,10 @@ pub fn addrSpaceCastIsValid(
539	to: AddressSpace,	539	to: AddressSpace,
540	) bool {	540	) bool {
541	switch (target.cpu.arch) {	541	switch (target.cpu.arch) {
542	.x86_64, .x86 => return target.cpu.supportsAddressSpace(from, null) and target.cpu.supportsAddressSpace(to, null),	542	.x86_64, .x86 => return target.supportsAddressSpace(from, null) and target.supportsAddressSpace(to, null),
543	.nvptx64, .nvptx, .amdgcn => {	543	.nvptx64, .nvptx, .amdgcn => {
544	const to_generic = target.cpu.supportsAddressSpace(from, null) and to == .generic;	544	const to_generic = target.supportsAddressSpace(from, null) and to == .generic;
545	const from_generic = target.cpu.supportsAddressSpace(to, null) and from == .generic;	545	const from_generic = target.supportsAddressSpace(to, null) and from == .generic;
546	return to_generic or from_generic;	546	return to_generic or from_generic;
547	},	547	},
548	else => return from == .generic and to == .generic,	548	else => return from == .generic and to == .generic,